On Sat, May 15, 2021 at 09:11:16AM +0530, Shreyansh Chouhan wrote:
> Prefixed the names of all the macros that were used for declaring things
> with 'declare_'. This should help with clarifying about what these
> macros do.
Thanks, but I think I will leave the code as-is. It's a good "test" for
people who try to modify the code without actually building it :)
greg k-h
On Sat, May 15, 2021 at 07:33:03AM +0200, Greg KH wrote:
> On Sat, May 15, 2021 at 09:11:16AM +0530, Shreyansh Chouhan wrote:
> > Prefixed the names of all the macros that were used for declaring things
> > with 'declare_'. This should help with clarifying about what these
> > macros do.
>
> Thanks, but I think I will leave the code as-is. It's a good "test" for
> people who try to modify the code without actually building it :)
>
Oh. Okay, I will try fixing something that might actually be a coding
style issue this time then. :)
> greg k-h
Regards,
Shreyansh Chouhan.
On Sat, 2021-05-15 at 07:33 +0200, Greg KH wrote:
> On Sat, May 15, 2021 at 09:11:16AM +0530, Shreyansh Chouhan wrote:
> > Prefixed the names of all the macros that were used for declaring things
> > with 'declare_'. This should help with clarifying about what these
> > macros do.
>
> Thanks, but I think I will leave the code as-is. It's a good "test" for
> people who try to modify the code without actually building it :)
This improves the code for the human reader.
I think wherever reasonable, code should be improved.
In any case, it's a test as checkpatch will emit the same message.