2021-05-13 09:01:57

by Zou Wei

Subject: [PATCH -next] staging: greybus: audio: Add missing MODULE_DEVICE_TABLE

This patch adds missing MODULE_DEVICE_TABLE definition which generates
correct modalias for automatic loading of this driver when it is built
as an external module.

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Zou Wei <[email protected]>
---
drivers/staging/greybus/audio_codec.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/staging/greybus/audio_codec.c
index b589cf6..6fa9781 100644
--- a/drivers/staging/greybus/audio_codec.c
+++ b/drivers/staging/greybus/audio_codec.c
@@ -1086,6 +1086,7 @@ static const struct of_device_id greybus_asoc_machine_of_match[] = {
{ .compatible = "toshiba,apb-dummy-codec", },
{},
};
+MODULE_DEVICE_TABLE(of, greybus_asoc_machine_of_match);

static struct platform_driver gbaudio_codec_driver = {
.driver = {
--
2.6.2

2021-05-13 11:20:28

by Greg Kroah-Hartman

Subject: Re: [PATCH -next] staging: greybus: audio: Add missing MODULE_DEVICE_TABLE

On Thu, May 13, 2021 at 04:49:32PM +0800, Zou Wei wrote:
> This patch adds missing MODULE_DEVICE_TABLE definition which generates
> correct modalias for automatic loading of this driver when it is built
> as an external module.
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Zou Wei <[email protected]>
> ---
> drivers/staging/greybus/audio_codec.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/staging/greybus/audio_codec.c
> index b589cf6..6fa9781 100644
> --- a/drivers/staging/greybus/audio_codec.c
> +++ b/drivers/staging/greybus/audio_codec.c
> @@ -1086,6 +1086,7 @@ static const struct of_device_id greybus_asoc_machine_of_match[] = {
> { .compatible = "toshiba,apb-dummy-codec", },
> {},
> };
> +MODULE_DEVICE_TABLE(of, greybus_asoc_machine_of_match);
>
> static struct platform_driver gbaudio_codec_driver = {
> .driver = {
> --
> 2.6.2
>
>

I think I will just start rejecting all of thes "missing
MODULE_DEVICE_TABLE()" patches as they make no sense at all.

If the driver authors had wanted these MODULE_DEVICE_TABLES added, they
would have done so. That means they were not using dynamically loaded
modules because usually, the module is built in, OR it doesn't matter.

So please, only add this if you have a system that needs them, do not
add them just based on a rule you have generated by a tool, as that is
pointless.

thanks,

greg k-h