Enable the flexible TX FIFO resize logic on SM8150. Using a larger TX FIFO
SZ can help account for situations when system latency is greater than the
USB bus transmission latency.
Reviewed-by: Rob Herring <[email protected]>
Signed-off-by: Wesley Cheng <[email protected]>
---
arch/arm64/boot/dts/qcom/sm8150.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi
index 51235a9..8f532cb 100644
--- a/arch/arm64/boot/dts/qcom/sm8150.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi
@@ -2275,6 +2275,7 @@
iommus = <&apps_smmu 0x140 0>;
snps,dis_u2_susphy_quirk;
snps,dis_enblslpm_quirk;
+ tx-fifo-resize;
phys = <&usb_1_hsphy>, <&usb_1_ssphy>;
phy-names = "usb2-phy", "usb3-phy";
};
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
On Wed 19 May 02:43 CDT 2021, Wesley Cheng wrote:
> Enable the flexible TX FIFO resize logic on SM8150. Using a larger TX FIFO
> SZ can help account for situations when system latency is greater than the
> USB bus transmission latency.
>
> Reviewed-by: Rob Herring <[email protected]>
> Signed-off-by: Wesley Cheng <[email protected]>
Based on my previous request of always adding this for the Qualcomm
platforms that supports it, which is implemented in patch 4, I don't see
a need for this patch.
Am I missing something?
Regards,
Bjorn
> ---
> arch/arm64/boot/dts/qcom/sm8150.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi
> index 51235a9..8f532cb 100644
> --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi
> @@ -2275,6 +2275,7 @@
> iommus = <&apps_smmu 0x140 0>;
> snps,dis_u2_susphy_quirk;
> snps,dis_enblslpm_quirk;
> + tx-fifo-resize;
> phys = <&usb_1_hsphy>, <&usb_1_ssphy>;
> phy-names = "usb2-phy", "usb3-phy";
> };
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
Hi Bjorn,
On Sat, May 29, 2021 at 12:07:31PM -0500, Bjorn Andersson wrote:
> On Wed 19 May 02:43 CDT 2021, Wesley Cheng wrote:
>
> > Enable the flexible TX FIFO resize logic on SM8150. Using a larger TX FIFO
> > SZ can help account for situations when system latency is greater than the
> > USB bus transmission latency.
> >
> > Reviewed-by: Rob Herring <[email protected]>
> > Signed-off-by: Wesley Cheng <[email protected]>
>
> Based on my previous request of always adding this for the Qualcomm
> platforms that supports it, which is implemented in patch 4, I don't see
> a need for this patch.
>
> Am I missing something?
Looks like Wesley had quickly sent a V9 of the series right after V8,
and the DTSI change is dropped.
https://lore.kernel.org/linux-usb/[email protected]/T/#t
Thanks,
Jack
> > ---
> > arch/arm64/boot/dts/qcom/sm8150.dtsi | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi
> > index 51235a9..8f532cb 100644
> > --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi
> > @@ -2275,6 +2275,7 @@
> > iommus = <&apps_smmu 0x140 0>;
> > snps,dis_u2_susphy_quirk;
> > snps,dis_enblslpm_quirk;
> > + tx-fifo-resize;
> > phys = <&usb_1_hsphy>, <&usb_1_ssphy>;
> > phy-names = "usb2-phy", "usb3-phy";
> > };
--
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project