2021-06-01 14:09:08

by Zheng Yongjun

Subject: [PATCH -next] ibft: Remove unneeded semicolon

Remove unneeded semicolon.

Signed-off-by: Zheng Yongjun <[email protected]>
---
drivers/firmware/iscsi_ibft.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/firmware/iscsi_ibft.c b/drivers/firmware/iscsi_ibft.c
index 7127a04bca19..d46da640f484 100644
--- a/drivers/firmware/iscsi_ibft.c
+++ b/drivers/firmware/iscsi_ibft.c
@@ -802,7 +802,7 @@ static void ibft_unregister(void)
ibft_kobj = boot_kobj->data;
if (ibft_kobj->hdr && ibft_kobj->hdr->id == id_nic)
sysfs_remove_link(&boot_kobj->kobj, "device");
- };
+ }
}

static void ibft_cleanup(void)
--
2.25.1

2021-06-03 01:56:10

by Konrad Rzeszutek Wilk

Subject: Re: [PATCH -next] ibft: Remove unneeded semicolon

On Tue, Jun 01, 2021 at 10:21:32PM +0800, Zheng Yongjun wrote:
> Remove unneeded semicolon.

Heya,

Please bear with me - but this semicolon does not seem to be hurting
anyone so not sure what bug this patch is trying to fix?

I would prefer to leave the code as is (with all its warts) unless
there are bugs or features to be added.

Thank you.
>
> Signed-off-by: Zheng Yongjun <[email protected]>
> ---
> drivers/firmware/iscsi_ibft.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/iscsi_ibft.c b/drivers/firmware/iscsi_ibft.c
> index 7127a04bca19..d46da640f484 100644
> --- a/drivers/firmware/iscsi_ibft.c
> +++ b/drivers/firmware/iscsi_ibft.c
> @@ -802,7 +802,7 @@ static void ibft_unregister(void)
> ibft_kobj = boot_kobj->data;
> if (ibft_kobj->hdr && ibft_kobj->hdr->id == id_nic)
> sysfs_remove_link(&boot_kobj->kobj, "device");
> - };
> + }
> }
>
> static void ibft_cleanup(void)
> --
> 2.25.1
>