hi,
This patch series adds a driver for the i.MX8MQ CSI MIPI receiver / controller.
It includes the driver, the dt-bindings and the DT addition to the SoC dtsi.
I test it using libcamera. Thanks to Laurent who helped a lot. I'm happy for
any feedback,
martin
revision history
----------------
v10: (thank you Dafna)
* improve send_level documentation.
* add some comments to 0x180 and 0x184
* after re-reading I could eliminate the unneeded setting of 0x184 (ignored
by setting 0x180 to 1).
v9: (thank you Laurent)
* improve getting the esc clock rate for hs_settle
https://lore.kernel.org/linux-media/[email protected]/
v8: (thank you Laurent)
* calculate hs_settle for any clk rate and mode
* add reviewed-by tag
https://lore.kernel.org/linux-media/[email protected]/T/
v7: (thank you Laurent and Rob)
* fix the binding example (include the reset driver)
* use pm_runtime_resume_and_get()
* fix some logic in init_cfg()
* add some useful code comments and fix minor bits found by Laurent in v6
https://lore.kernel.org/linux-media/[email protected]/T/#t
v6: (thank you Laurent and Rob)
* add reviewed-by tag to binding
* statically allocate clk_bulk_data
* fix how the hs_settle value is applied
* remove s_power calls
* remove the link_setup() callback implementation and make the link immutable
* more cleanups according to Laurents' review from v5
https://lore.kernel.org/linux-media/[email protected]/
v5: (thank you Laurent)
* fix reset usage by using the already supported reset controller driver
* remove clko2 (totally unrelated clock / had been included by accident)
* rename pxl clock to ui
https://lore.kernel.org/linux-media/[email protected]/
v4: (thank you Rob and Marco)
* create fsl,mipi-phy-gpr custom dt property instead of confusing "phy"
* add imx8mq-specific compatibile to imx8mq.dtsi for future use
https://lore.kernel.org/linux-media/[email protected]/
v3: (thank you, Rob and Laurent)
among minor other things according to v2 review, changes include:
* better describe the clocks
* rename DT property "phy-reset" to "reset" and "phy-gpr" to "phy"
https://lore.kernel.org/linux-media/[email protected]/T/#t
v2: (thank you, Dan and Guido)
among fixes according to v1 reviews, changes include:
* remove status property from dt-bindings example
* define a few bits in order to have less magic values
* use "imx8mq_mipi_csi_" as local function prefix
* read DT properties only during probe()
* remove dead code (log_status)
* add imx8mq_mipi_csi_release_icc()
* fix imx8mq_mipi_csi_init_icc()
https://lore.kernel.org/linux-media/[email protected]/
v1:
https://lore.kernel.org/linux-media/[email protected]/T/#t
Martin Kepplinger (3):
dt-bindings: media: document the nxp,imx8mq-mipi-csi2 receiver phy and
controller
media: imx: add a driver for i.MX8MQ mipi csi rx phy and controller
arm64: dts: imx8mq: add mipi csi phy and csi bridge descriptions
.../bindings/media/nxp,imx8mq-mipi-csi2.yaml | 174 +++
arch/arm64/boot/dts/freescale/imx8mq.dtsi | 104 ++
drivers/staging/media/imx/Makefile | 1 +
drivers/staging/media/imx/imx8mq-mipi-csi2.c | 991 ++++++++++++++++++
4 files changed, 1270 insertions(+)
create mode 100644 Documentation/devicetree/bindings/media/nxp,imx8mq-mipi-csi2.yaml
create mode 100644 drivers/staging/media/imx/imx8mq-mipi-csi2.c
--
2.30.2
Hi Martin,
On Wed, Jul 28, 2021 at 11:12:42AM +0200, Martin Kepplinger wrote:
> hi,
>
> This patch series adds a driver for the i.MX8MQ CSI MIPI receiver / controller.
>
> It includes the driver, the dt-bindings and the DT addition to the SoC dtsi.
> I test it using libcamera. Thanks to Laurent who helped a lot. I'm happy for
> any feedback,
Thank you for the series. I've submitted a pull request that contains
patches 1/3 and 2/3.
Shawn, Sascha, how would you like to handle 3/3 ?
> revision history
> ----------------
> v10: (thank you Dafna)
> * improve send_level documentation.
> * add some comments to 0x180 and 0x184
> * after re-reading I could eliminate the unneeded setting of 0x184 (ignored
> by setting 0x180 to 1).
>
> v9: (thank you Laurent)
> * improve getting the esc clock rate for hs_settle
> https://lore.kernel.org/linux-media/[email protected]/
>
> v8: (thank you Laurent)
> * calculate hs_settle for any clk rate and mode
> * add reviewed-by tag
> https://lore.kernel.org/linux-media/[email protected]/T/
>
> v7: (thank you Laurent and Rob)
> * fix the binding example (include the reset driver)
> * use pm_runtime_resume_and_get()
> * fix some logic in init_cfg()
> * add some useful code comments and fix minor bits found by Laurent in v6
> https://lore.kernel.org/linux-media/[email protected]/T/#t
>
> v6: (thank you Laurent and Rob)
> * add reviewed-by tag to binding
> * statically allocate clk_bulk_data
> * fix how the hs_settle value is applied
> * remove s_power calls
> * remove the link_setup() callback implementation and make the link immutable
> * more cleanups according to Laurents' review from v5
> https://lore.kernel.org/linux-media/[email protected]/
>
> v5: (thank you Laurent)
> * fix reset usage by using the already supported reset controller driver
> * remove clko2 (totally unrelated clock / had been included by accident)
> * rename pxl clock to ui
> https://lore.kernel.org/linux-media/[email protected]/
>
> v4: (thank you Rob and Marco)
> * create fsl,mipi-phy-gpr custom dt property instead of confusing "phy"
> * add imx8mq-specific compatibile to imx8mq.dtsi for future use
> https://lore.kernel.org/linux-media/[email protected]/
>
> v3: (thank you, Rob and Laurent)
> among minor other things according to v2 review, changes include:
> * better describe the clocks
> * rename DT property "phy-reset" to "reset" and "phy-gpr" to "phy"
> https://lore.kernel.org/linux-media/[email protected]/T/#t
>
> v2: (thank you, Dan and Guido)
> among fixes according to v1 reviews, changes include:
> * remove status property from dt-bindings example
> * define a few bits in order to have less magic values
> * use "imx8mq_mipi_csi_" as local function prefix
> * read DT properties only during probe()
> * remove dead code (log_status)
> * add imx8mq_mipi_csi_release_icc()
> * fix imx8mq_mipi_csi_init_icc()
> https://lore.kernel.org/linux-media/[email protected]/
>
> v1:
> https://lore.kernel.org/linux-media/[email protected]/T/#t
>
>
> Martin Kepplinger (3):
> dt-bindings: media: document the nxp,imx8mq-mipi-csi2 receiver phy and
> controller
> media: imx: add a driver for i.MX8MQ mipi csi rx phy and controller
> arm64: dts: imx8mq: add mipi csi phy and csi bridge descriptions
>
> .../bindings/media/nxp,imx8mq-mipi-csi2.yaml | 174 +++
> arch/arm64/boot/dts/freescale/imx8mq.dtsi | 104 ++
> drivers/staging/media/imx/Makefile | 1 +
> drivers/staging/media/imx/imx8mq-mipi-csi2.c | 991 ++++++++++++++++++
> 4 files changed, 1270 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/media/nxp,imx8mq-mipi-csi2.yaml
> create mode 100644 drivers/staging/media/imx/imx8mq-mipi-csi2.c
--
Regards,
Laurent Pinchart
Am Mittwoch, dem 04.08.2021 um 17:31 +0800 schrieb Shawn Guo:
> On Wed, Jul 28, 2021 at 04:32:45PM +0300, Laurent Pinchart wrote:
> > Hi Martin,
> >
> > On Wed, Jul 28, 2021 at 11:12:42AM +0200, Martin Kepplinger wrote:
> > > hi,
> > >
> > > This patch series adds a driver for the i.MX8MQ CSI MIPI receiver
> > > / controller.
> > >
> > > It includes the driver, the dt-bindings and the DT addition to
> > > the SoC dtsi.
> > > I test it using libcamera. Thanks to Laurent who helped a lot.
> > > I'm happy for
> > > any feedback,
> >
> > Thank you for the series. I've submitted a pull request that
> > contains
> > patches 1/3 and 2/3.
> >
> > Shawn, Sascha, how would you like to handle 3/3 ?
>
> I picked up the 3/3 in v9, which I think is identical to this
> version.
> Otherwise, please let me know.
>
> Shawn
it's identical, yes. thank you very much,
martin
On Wed, Jul 28, 2021 at 04:32:45PM +0300, Laurent Pinchart wrote:
> Hi Martin,
>
> On Wed, Jul 28, 2021 at 11:12:42AM +0200, Martin Kepplinger wrote:
> > hi,
> >
> > This patch series adds a driver for the i.MX8MQ CSI MIPI receiver / controller.
> >
> > It includes the driver, the dt-bindings and the DT addition to the SoC dtsi.
> > I test it using libcamera. Thanks to Laurent who helped a lot. I'm happy for
> > any feedback,
>
> Thank you for the series. I've submitted a pull request that contains
> patches 1/3 and 2/3.
>
> Shawn, Sascha, how would you like to handle 3/3 ?
I picked up the 3/3 in v9, which I think is identical to this version.
Otherwise, please let me know.
Shawn