2021-08-16 23:44:17

by Nathan Chancellor

Subject: [PATCH] f2fs: Add missing inline to f2fs_sanity_check_cluster() stub

Without this, there is a warning in nearly every fs/f2fs/ file when
F2FS_FS_COMPRESSION is not set:

In file included from fs/f2fs/super.c:31:
fs/f2fs/f2fs.h:4251:13: warning: unused function 'f2fs_sanity_check_cluster' [-Wunused-function]
static bool f2fs_sanity_check_cluster(struct dnode_of_data *dn) { return false; }
^
1 warning generated.

Fixes: 1495870233e7 ("f2fs: compress: do sanity check on cluster")
Signed-off-by: Nathan Chancellor <[email protected]>
---
fs/f2fs/f2fs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
index 0c978f934dcc..fe1097e678da 100644
--- a/fs/f2fs/f2fs.h
+++ b/fs/f2fs/f2fs.h
@@ -4248,7 +4248,7 @@ static inline void f2fs_put_page_dic(struct page *page)
WARN_ON_ONCE(1);
}
static inline unsigned int f2fs_cluster_blocks_are_contiguous(struct dnode_of_data *dn) { return 0; }
-static bool f2fs_sanity_check_cluster(struct dnode_of_data *dn) { return false; }
+static inline bool f2fs_sanity_check_cluster(struct dnode_of_data *dn) { return false; }
static inline int f2fs_init_compress_inode(struct f2fs_sb_info *sbi) { return 0; }
static inline void f2fs_destroy_compress_inode(struct f2fs_sb_info *sbi) { }
static inline int f2fs_init_page_array_cache(struct f2fs_sb_info *sbi) { return 0; }

base-commit: f4b05791dda93edb03ebb6b48f1be104b2e64274
--
2.33.0.rc2

2021-08-17 00:35:27

by Jaegeuk Kim

Subject: Re: [PATCH] f2fs: Add missing inline to f2fs_sanity_check_cluster() stub

Hi Nathan,

On 08/16, Nathan Chancellor wrote:
> Without this, there is a warning in nearly every fs/f2fs/ file when
> F2FS_FS_COMPRESSION is not set:
>
> In file included from fs/f2fs/super.c:31:
> fs/f2fs/f2fs.h:4251:13: warning: unused function 'f2fs_sanity_check_cluster' [-Wunused-function]
> static bool f2fs_sanity_check_cluster(struct dnode_of_data *dn) { return false; }
> ^
> 1 warning generated.
>
> Fixes: 1495870233e7 ("f2fs: compress: do sanity check on cluster")

This has not been merged yet, so if you don't mind, can I integrate your fix in
the original patch?

Thanks,

> Signed-off-by: Nathan Chancellor <[email protected]>
> ---
> fs/f2fs/f2fs.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
> index 0c978f934dcc..fe1097e678da 100644
> --- a/fs/f2fs/f2fs.h
> +++ b/fs/f2fs/f2fs.h
> @@ -4248,7 +4248,7 @@ static inline void f2fs_put_page_dic(struct page *page)
> WARN_ON_ONCE(1);
> }
> static inline unsigned int f2fs_cluster_blocks_are_contiguous(struct dnode_of_data *dn) { return 0; }
> -static bool f2fs_sanity_check_cluster(struct dnode_of_data *dn) { return false; }
> +static inline bool f2fs_sanity_check_cluster(struct dnode_of_data *dn) { return false; }
> static inline int f2fs_init_compress_inode(struct f2fs_sb_info *sbi) { return 0; }
> static inline void f2fs_destroy_compress_inode(struct f2fs_sb_info *sbi) { }
> static inline int f2fs_init_page_array_cache(struct f2fs_sb_info *sbi) { return 0; }
>
> base-commit: f4b05791dda93edb03ebb6b48f1be104b2e64274
> --
> 2.33.0.rc2

2021-08-17 00:36:43

by Nathan Chancellor

Subject: Re: [PATCH] f2fs: Add missing inline to f2fs_sanity_check_cluster() stub

On 8/16/2021 5:33 PM, Jaegeuk Kim wrote:
> Hi Nathan,
>
> On 08/16, Nathan Chancellor wrote:
>> Without this, there is a warning in nearly every fs/f2fs/ file when
>> F2FS_FS_COMPRESSION is not set:
>>
>> In file included from fs/f2fs/super.c:31:
>> fs/f2fs/f2fs.h:4251:13: warning: unused function 'f2fs_sanity_check_cluster' [-Wunused-function]
>> static bool f2fs_sanity_check_cluster(struct dnode_of_data *dn) { return false; }
>> ^
>> 1 warning generated.
>>
>> Fixes: 1495870233e7 ("f2fs: compress: do sanity check on cluster")
>
> This has not been merged yet, so if you don't mind, can I integrate your fix in
> the original patch?

Sure thing!

Cheers,
Nathan

2021-08-17 19:02:20

by Jaegeuk Kim

Subject: Re: [PATCH] f2fs: Add missing inline to f2fs_sanity_check_cluster() stub

On 08/16, Nathan Chancellor wrote:
> On 8/16/2021 5:33 PM, Jaegeuk Kim wrote:
> > Hi Nathan,
> >
> > On 08/16, Nathan Chancellor wrote:
> > > Without this, there is a warning in nearly every fs/f2fs/ file when
> > > F2FS_FS_COMPRESSION is not set:
> > >
> > > In file included from fs/f2fs/super.c:31:
> > > fs/f2fs/f2fs.h:4251:13: warning: unused function 'f2fs_sanity_check_cluster' [-Wunused-function]
> > > static bool f2fs_sanity_check_cluster(struct dnode_of_data *dn) { return false; }
> > > ^
> > > 1 warning generated.
> > >
> > > Fixes: 1495870233e7 ("f2fs: compress: do sanity check on cluster")
> >
> > This has not been merged yet, so if you don't mind, can I integrate your fix in
> > the original patch?
>
> Sure thing!

Thanks~ :)

>
> Cheers,
> Nathan