2021-08-29 07:36:35

by Saurav Girepunje

Subject: [PATCH v3] staging: r8188eu: core: remove null check before vfree

Remove NULL check. NULL check before freeing function is not needed.
Correct the indentation.

ChangeLog V3:
-Added change log.

ChangeLog V2:
-Correct the indentation.

Signed-off-by: Saurav Girepunje <[email protected]>
---
drivers/staging/r8188eu/core/rtw_sta_mgt.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/r8188eu/core/rtw_sta_mgt.c b/drivers/staging/r8188eu/core/rtw_sta_mgt.c
index f6dffed53a60..c3600cb1790a 100644
--- a/drivers/staging/r8188eu/core/rtw_sta_mgt.c
+++ b/drivers/staging/r8188eu/core/rtw_sta_mgt.c
@@ -155,9 +155,8 @@ u32 _rtw_free_sta_priv(struct sta_priv *pstapriv)
spin_unlock_bh(&pstapriv->sta_hash_lock);
/*===============================*/

- if (pstapriv->pallocated_stainfo_buf)
- vfree(pstapriv->pallocated_stainfo_buf);
- }
+ vfree(pstapriv->pallocated_stainfo_buf);
+ }

return _SUCCESS;
}
--
2.32.0

2021-08-29 08:13:38

by Greg Kroah-Hartman

Subject: Re: [PATCH v3] staging: r8188eu: core: remove null check before vfree

On Sun, Aug 29, 2021 at 01:04:22PM +0530, Saurav Girepunje wrote:
> Remove NULL check. NULL check before freeing function is not needed.
> Correct the indentation.
>
> ChangeLog V3:
> -Added change log.
>
> ChangeLog V2:
> -Correct the indentation.

Please put this information below the --- line, as the documentation
says to do.

thanks,

greg k-h