tree: https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git 20210908-firmware-builtin-v4
head: 1c69d6a17750179d68bcaf6b16f9a08d2e475989
commit: 79e9fce20ee88ffe37542a66277628e6c53dde14 [2/11] firmware_loader: formalize built-in firmware API
config: hexagon-buildonly-randconfig-r004-20210910 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 261cbe98c38f8c1ee1a482fe76511110e790f58a)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git/commit/?id=79e9fce20ee88ffe37542a66277628e6c53dde14
git remote add mcgrof-next https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git
git fetch --no-tags mcgrof-next 20210908-firmware-builtin-v4
git checkout 79e9fce20ee88ffe37542a66277628e6c53dde14
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=hexagon
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>
All errors (new ones prefixed by >>):
>> drivers/base/firmware_loader/builtin/main.c:36:6: error: no previous prototype for function 'firmware_is_builtin' [-Werror,-Wmissing-prototypes]
bool firmware_is_builtin(const struct firmware *fw)
^
drivers/base/firmware_loader/builtin/main.c:36:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
bool firmware_is_builtin(const struct firmware *fw)
^
static
1 error generated.
vim +/firmware_is_builtin +36 drivers/base/firmware_loader/builtin/main.c
35
> 36 bool firmware_is_builtin(const struct firmware *fw)
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected]
On Fri, Sep 10, 2021 at 03:41:31PM +0800, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git 20210908-firmware-builtin-v4
> head: 1c69d6a17750179d68bcaf6b16f9a08d2e475989
> commit: 79e9fce20ee88ffe37542a66277628e6c53dde14 [2/11] firmware_loader: formalize built-in firmware API
> config: hexagon-buildonly-randconfig-r004-20210910 (attached as .config)
> compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 261cbe98c38f8c1ee1a482fe76511110e790f58a)
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git/commit/?id=79e9fce20ee88ffe37542a66277628e6c53dde14
> git remote add mcgrof-next https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git
> git fetch --no-tags mcgrof-next 20210908-firmware-builtin-v4
> git checkout 79e9fce20ee88ffe37542a66277628e6c53dde14
> # save the attached .config to linux build tree
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=hexagon
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <[email protected]>
>
> All errors (new ones prefixed by >>):
>
> >> drivers/base/firmware_loader/builtin/main.c:36:6: error: no previous prototype for function 'firmware_is_builtin' [-Werror,-Wmissing-prototypes]
> bool firmware_is_builtin(const struct firmware *fw)
This is a lie though its defined on drivers/base/firmware_loader/firmware.h
> ^
> drivers/base/firmware_loader/builtin/main.c:36:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
> bool firmware_is_builtin(const struct firmware *fw)
> ^
> static
> 1 error generated.
I get these odd errors:
Compiler will be installed in /home/mcgrof/0day
cd: received redirection to
`https://download.01.org/0day-ci/cross-package/'
lftpget -c
https://download.01.org/0day-ci/cross-package/./clang_hexagon/clang+llvm-12.0.0-cross-hexagon-unknown-linux-musl.tar.xz
tar Jxf
clang_hexagon/clang+llvm-12.0.0-cross-hexagon-unknown-linux-musl.tar.xz
-C /home/mcgrof/0day
make --keep-going
HOSTCC=/home/mcgrof/0day/clang+llvm-12.0.0-cross-hexagon-unknown-linux-musl/x86_64-linux-gnu/bin/clang
CC=/home/mcgrof/0day/clang+llvm-12.0.0-cross-hexagon-unknown-linux-musl/x86_64-linux-gnu/bin/clang
LD=/home/mcgrof/0day/clang+llvm-12.0.0-cross-hexagon-unknown-linux-musl/x86_64-linux-gnu/bin/ld.lld
HOSTLD=/home/mcgrof/0day/clang+llvm-12.0.0-cross-hexagon-unknown-linux-musl/x86_64-linux-gnu/bin/ld.lld
AR=llvm-ar NM=llvm-nm STRIP=llvm-strip OBJDUMP=llvm-objdump
OBJSIZE=llvm-size READELF=llvm-readelf HOSTCXX=clang++ HOSTAR=llvm-ar
LLVM_IAS=1 CROSS_COMPILE=hexagon-unknown-linux-musl- --jobs=24
ARCH=hexagon
SYNC include/config/auto.conf.cmd
HOSTCC scripts/basic/fixdep
/home/mcgrof/0day/clang+llvm-12.0.0-cross-hexagon-unknown-linux-musl/x86_64-linux-gnu/bin/clang:
error while loading shared libraries: libtinfo.so.5: cannot open
shared object file: No such file or directory
make[2]: *** [scripts/Makefile.host:95: scripts/basic/fixdep] Error
127
make[2]: Target '__build' not remade because of errors.
make[1]: *** [Makefile:594: scripts_basic] Error 2
make[1]: Target 'syncconfig' not remade because of errors.
make: *** [Makefile:771: include/config/auto.conf.cmd] Error 2
make: Failed to remake makefile 'include/config/auto.conf.cmd'.
make: Failed to remake makefile 'include/config/auto.conf'.
HOSTCC scripts/basic/fixdep
/home/mcgrof/0day/clang+llvm-12.0.0-cross-hexagon-unknown-linux-musl/x86_64-linux-gnu/bin/clang:
error while loading shared libraries: libtinfo.so.5: cannot open
shared object file: No such file or directory
make[1]: *** [scripts/Makefile.host:95: scripts/basic/fixdep]
Error 127
I have a feeling these issues are not correct...
Luis
On Fri, Sep 10, 2021 at 05:48:23PM -0700, Luis Chamberlain wrote:
> On Fri, Sep 10, 2021 at 03:41:31PM +0800, kernel test robot wrote:
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git 20210908-firmware-builtin-v4
> > head: 1c69d6a17750179d68bcaf6b16f9a08d2e475989
> > commit: 79e9fce20ee88ffe37542a66277628e6c53dde14 [2/11] firmware_loader: formalize built-in firmware API
> > config: hexagon-buildonly-randconfig-r004-20210910 (attached as .config)
> > compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 261cbe98c38f8c1ee1a482fe76511110e790f58a)
> > reproduce (this is a W=1 build):
> > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > chmod +x ~/bin/make.cross
> > # https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git/commit/?id=79e9fce20ee88ffe37542a66277628e6c53dde14
> > git remote add mcgrof-next https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git
> > git fetch --no-tags mcgrof-next 20210908-firmware-builtin-v4
> > git checkout 79e9fce20ee88ffe37542a66277628e6c53dde14
> > # save the attached .config to linux build tree
> > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=hexagon
> >
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <[email protected]>
> >
> > All errors (new ones prefixed by >>):
> >
> > >> drivers/base/firmware_loader/builtin/main.c:36:6: error: no previous prototype for function 'firmware_is_builtin' [-Werror,-Wmissing-prototypes]
> > bool firmware_is_builtin(const struct firmware *fw)
>
> This is a lie though its defined on drivers/base/firmware_loader/firmware.h
>
> > ^
> > drivers/base/firmware_loader/builtin/main.c:36:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
> > bool firmware_is_builtin(const struct firmware *fw)
> > ^
> > static
> > 1 error generated.
>
> I get these odd errors:
>
> Compiler will be installed in /home/mcgrof/0day
hi Luis, would you mind to download the make.cross tool again to give a try, it
was updated recently to use latest clang instead of this 12.0.0?
> cd: received redirection to
> `https://download.01.org/0day-ci/cross-package/'
> lftpget -c
> https://download.01.org/0day-ci/cross-package/./clang_hexagon/clang+llvm-12.0.0-cross-hexagon-unknown-linux-musl.tar.xz
> tar Jxf
> clang_hexagon/clang+llvm-12.0.0-cross-hexagon-unknown-linux-musl.tar.xz
> -C /home/mcgrof/0day
> make --keep-going
> HOSTCC=/home/mcgrof/0day/clang+llvm-12.0.0-cross-hexagon-unknown-linux-musl/x86_64-linux-gnu/bin/clang
> CC=/home/mcgrof/0day/clang+llvm-12.0.0-cross-hexagon-unknown-linux-musl/x86_64-linux-gnu/bin/clang
> LD=/home/mcgrof/0day/clang+llvm-12.0.0-cross-hexagon-unknown-linux-musl/x86_64-linux-gnu/bin/ld.lld
> HOSTLD=/home/mcgrof/0day/clang+llvm-12.0.0-cross-hexagon-unknown-linux-musl/x86_64-linux-gnu/bin/ld.lld
> AR=llvm-ar NM=llvm-nm STRIP=llvm-strip OBJDUMP=llvm-objdump
> OBJSIZE=llvm-size READELF=llvm-readelf HOSTCXX=clang++ HOSTAR=llvm-ar
> LLVM_IAS=1 CROSS_COMPILE=hexagon-unknown-linux-musl- --jobs=24
> ARCH=hexagon
> SYNC include/config/auto.conf.cmd
> HOSTCC scripts/basic/fixdep
> /home/mcgrof/0day/clang+llvm-12.0.0-cross-hexagon-unknown-linux-musl/x86_64-linux-gnu/bin/clang:
> error while loading shared libraries: libtinfo.so.5: cannot open
> shared object file: No such file or directory
> make[2]: *** [scripts/Makefile.host:95: scripts/basic/fixdep] Error
> 127
> make[2]: Target '__build' not remade because of errors.
> make[1]: *** [Makefile:594: scripts_basic] Error 2
> make[1]: Target 'syncconfig' not remade because of errors.
> make: *** [Makefile:771: include/config/auto.conf.cmd] Error 2
> make: Failed to remake makefile 'include/config/auto.conf.cmd'.
> make: Failed to remake makefile 'include/config/auto.conf'.
> HOSTCC scripts/basic/fixdep
> /home/mcgrof/0day/clang+llvm-12.0.0-cross-hexagon-unknown-linux-musl/x86_64-linux-gnu/bin/clang:
> error while loading shared libraries: libtinfo.so.5: cannot open
> shared object file: No such file or directory
> make[1]: *** [scripts/Makefile.host:95: scripts/basic/fixdep]
> Error 127
>
>
> I have a feeling these issues are not correct...
>
> Luis
> _______________________________________________
> kbuild-all mailing list -- [email protected]
> To unsubscribe send an email to [email protected]
On Fri, Sep 10, 2021 at 05:48:23PM -0700, Luis Chamberlain wrote:
> On Fri, Sep 10, 2021 at 03:41:31PM +0800, kernel test robot wrote:
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git 20210908-firmware-builtin-v4
> > head: 1c69d6a17750179d68bcaf6b16f9a08d2e475989
> > commit: 79e9fce20ee88ffe37542a66277628e6c53dde14 [2/11] firmware_loader: formalize built-in firmware API
> > config: hexagon-buildonly-randconfig-r004-20210910 (attached as .config)
> > compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 261cbe98c38f8c1ee1a482fe76511110e790f58a)
> > reproduce (this is a W=1 build):
> > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > chmod +x ~/bin/make.cross
> > # https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git/commit/?id=79e9fce20ee88ffe37542a66277628e6c53dde14
> > git remote add mcgrof-next https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git
> > git fetch --no-tags mcgrof-next 20210908-firmware-builtin-v4
> > git checkout 79e9fce20ee88ffe37542a66277628e6c53dde14
> > # save the attached .config to linux build tree
> > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=hexagon
> >
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <[email protected]>
> >
> > All errors (new ones prefixed by >>):
> >
> > >> drivers/base/firmware_loader/builtin/main.c:36:6: error: no previous prototype for function 'firmware_is_builtin' [-Werror,-Wmissing-prototypes]
> > bool firmware_is_builtin(const struct firmware *fw)
>
> This is a lie though its defined on drivers/base/firmware_loader/firmware.h
Unless I am missing something, you don't include the firmware_loader
copy of firmware.h in builtin/main.c (only the linux one)? Isn't that
the source of the warning?
Cheers,
Nathan
On Fri, Sep 10, 2021 at 06:52:03PM -0700, Nathan Chancellor wrote:
> On Fri, Sep 10, 2021 at 05:48:23PM -0700, Luis Chamberlain wrote:
> > On Fri, Sep 10, 2021 at 03:41:31PM +0800, kernel test robot wrote:
> > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git 20210908-firmware-builtin-v4
> > > head: 1c69d6a17750179d68bcaf6b16f9a08d2e475989
> > > commit: 79e9fce20ee88ffe37542a66277628e6c53dde14 [2/11] firmware_loader: formalize built-in firmware API
> > > config: hexagon-buildonly-randconfig-r004-20210910 (attached as .config)
> > > compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 261cbe98c38f8c1ee1a482fe76511110e790f58a)
> > > reproduce (this is a W=1 build):
> > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > > chmod +x ~/bin/make.cross
> > > # https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git/commit/?id=79e9fce20ee88ffe37542a66277628e6c53dde14
> > > git remote add mcgrof-next https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git
> > > git fetch --no-tags mcgrof-next 20210908-firmware-builtin-v4
> > > git checkout 79e9fce20ee88ffe37542a66277628e6c53dde14
> > > # save the attached .config to linux build tree
> > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=hexagon
> > >
> > > If you fix the issue, kindly add following tag as appropriate
> > > Reported-by: kernel test robot <[email protected]>
> > >
> > > All errors (new ones prefixed by >>):
> > >
> > > >> drivers/base/firmware_loader/builtin/main.c:36:6: error: no previous prototype for function 'firmware_is_builtin' [-Werror,-Wmissing-prototypes]
> > > bool firmware_is_builtin(const struct firmware *fw)
> >
> > This is a lie though its defined on drivers/base/firmware_loader/firmware.h
>
> Unless I am missing something, you don't include the firmware_loader
> copy of firmware.h in builtin/main.c (only the linux one)? Isn't that
> the source of the warning?
You would think, but nope, its there:
#include "firmware.h"
Luis
On Sat, Sep 11, 2021 at 09:28:53AM +0800, Philip Li wrote:
> On Fri, Sep 10, 2021 at 05:48:23PM -0700, Luis Chamberlain wrote:
> > On Fri, Sep 10, 2021 at 03:41:31PM +0800, kernel test robot wrote:
> > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git 20210908-firmware-builtin-v4
> > > head: 1c69d6a17750179d68bcaf6b16f9a08d2e475989
> > > commit: 79e9fce20ee88ffe37542a66277628e6c53dde14 [2/11] firmware_loader: formalize built-in firmware API
> > > config: hexagon-buildonly-randconfig-r004-20210910 (attached as .config)
> > > compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 261cbe98c38f8c1ee1a482fe76511110e790f58a)
> > > reproduce (this is a W=1 build):
> > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > > chmod +x ~/bin/make.cross
> > > # https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git/commit/?id=79e9fce20ee88ffe37542a66277628e6c53dde14
> > > git remote add mcgrof-next https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git
> > > git fetch --no-tags mcgrof-next 20210908-firmware-builtin-v4
> > > git checkout 79e9fce20ee88ffe37542a66277628e6c53dde14
> > > # save the attached .config to linux build tree
> > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=hexagon
> > >
> > > If you fix the issue, kindly add following tag as appropriate
> > > Reported-by: kernel test robot <[email protected]>
> > >
> > > All errors (new ones prefixed by >>):
> > >
> > > >> drivers/base/firmware_loader/builtin/main.c:36:6: error: no previous prototype for function 'firmware_is_builtin' [-Werror,-Wmissing-prototypes]
> > > bool firmware_is_builtin(const struct firmware *fw)
> >
> > This is a lie though its defined on drivers/base/firmware_loader/firmware.h
> >
> > > ^
> > > drivers/base/firmware_loader/builtin/main.c:36:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
> > > bool firmware_is_builtin(const struct firmware *fw)
> > > ^
> > > static
> > > 1 error generated.
> >
> > I get these odd errors:
> >
> > Compiler will be installed in /home/mcgrof/0day
> hi Luis, would you mind to download the make.cross tool again to give a try, it
> was updated recently to use latest clang instead of this 12.0.0?
I had clang+llvm-12.0.0-cross-hexagon-unknown-linux-musl and this was
used already. Is there a more recent one? Just in case I rm -rf'd it
and tried again with the latest make.cross.
Luis
On Mon, Sep 13, 2021 at 08:59:50AM -0700, Luis Chamberlain wrote:
> On Sat, Sep 11, 2021 at 09:28:53AM +0800, Philip Li wrote:
> > On Fri, Sep 10, 2021 at 05:48:23PM -0700, Luis Chamberlain wrote:
> > > On Fri, Sep 10, 2021 at 03:41:31PM +0800, kernel test robot wrote:
> > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git 20210908-firmware-builtin-v4
> > > > head: 1c69d6a17750179d68bcaf6b16f9a08d2e475989
> > > > commit: 79e9fce20ee88ffe37542a66277628e6c53dde14 [2/11] firmware_loader: formalize built-in firmware API
> > > > config: hexagon-buildonly-randconfig-r004-20210910 (attached as .config)
> > > > compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 261cbe98c38f8c1ee1a482fe76511110e790f58a)
> > > > reproduce (this is a W=1 build):
> > > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > > > chmod +x ~/bin/make.cross
> > > > # https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git/commit/?id=79e9fce20ee88ffe37542a66277628e6c53dde14
> > > > git remote add mcgrof-next https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git
> > > > git fetch --no-tags mcgrof-next 20210908-firmware-builtin-v4
> > > > git checkout 79e9fce20ee88ffe37542a66277628e6c53dde14
> > > > # save the attached .config to linux build tree
> > > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=hexagon
> > > >
> > > > If you fix the issue, kindly add following tag as appropriate
> > > > Reported-by: kernel test robot <[email protected]>
> > > >
> > > > All errors (new ones prefixed by >>):
> > > >
> > > > >> drivers/base/firmware_loader/builtin/main.c:36:6: error: no previous prototype for function 'firmware_is_builtin' [-Werror,-Wmissing-prototypes]
> > > > bool firmware_is_builtin(const struct firmware *fw)
> > >
> > > This is a lie though its defined on drivers/base/firmware_loader/firmware.h
> > >
> > > > ^
> > > > drivers/base/firmware_loader/builtin/main.c:36:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
> > > > bool firmware_is_builtin(const struct firmware *fw)
> > > > ^
> > > > static
> > > > 1 error generated.
> > >
> > > I get these odd errors:
> > >
> > > Compiler will be installed in /home/mcgrof/0day
> > hi Luis, would you mind to download the make.cross tool again to give a try, it
> > was updated recently to use latest clang instead of this 12.0.0?
>
> I had clang+llvm-12.0.0-cross-hexagon-unknown-linux-musl and this was
> used already. Is there a more recent one? Just in case I rm -rf'd it
> and tried again with the latest make.cross.
I rm -rf ~/0day and tried again but the failure I get is:
CALL scripts/checksyscalls.sh
<stdin>:1515:2: warning: syscall clone3 not implemented [-W#warnings]
#warning syscall clone3 not implemented
Even if I disable CONFIG_WERROR and COMPILE_TEST this still fails here
and so I can't even test compile the code in question.
Luis
On 9/13/2021 8:56 AM, Luis Chamberlain wrote:
> On Fri, Sep 10, 2021 at 06:52:03PM -0700, Nathan Chancellor wrote:
>> On Fri, Sep 10, 2021 at 05:48:23PM -0700, Luis Chamberlain wrote:
>>> On Fri, Sep 10, 2021 at 03:41:31PM +0800, kernel test robot wrote:
>>>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git 20210908-firmware-builtin-v4
>>>> head: 1c69d6a17750179d68bcaf6b16f9a08d2e475989
>>>> commit: 79e9fce20ee88ffe37542a66277628e6c53dde14 [2/11] firmware_loader: formalize built-in firmware API
>>>> config: hexagon-buildonly-randconfig-r004-20210910 (attached as .config)
>>>> compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 261cbe98c38f8c1ee1a482fe76511110e790f58a)
>>>> reproduce (this is a W=1 build):
>>>> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>>>> chmod +x ~/bin/make.cross
>>>> # https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git/commit/?id=79e9fce20ee88ffe37542a66277628e6c53dde14
>>>> git remote add mcgrof-next https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git
>>>> git fetch --no-tags mcgrof-next 20210908-firmware-builtin-v4
>>>> git checkout 79e9fce20ee88ffe37542a66277628e6c53dde14
>>>> # save the attached .config to linux build tree
>>>> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=hexagon
>>>>
>>>> If you fix the issue, kindly add following tag as appropriate
>>>> Reported-by: kernel test robot <[email protected]>
>>>>
>>>> All errors (new ones prefixed by >>):
>>>>
>>>>>> drivers/base/firmware_loader/builtin/main.c:36:6: error: no previous prototype for function 'firmware_is_builtin' [-Werror,-Wmissing-prototypes]
>>>> bool firmware_is_builtin(const struct firmware *fw)
>>>
>>> This is a lie though its defined on drivers/base/firmware_loader/firmware.h
>>
>> Unless I am missing something, you don't include the firmware_loader
>> copy of firmware.h in builtin/main.c (only the linux one)? Isn't that
>> the source of the warning?
>
> You would think, but nope, its there:
>
> #include "firmware.h"
I see that in drivers/base/firmware_loader/main.c but the warning is
complaining about drivers/base/firmware_loader/builtin/main.c, where I
only see
#include <linux/firmware.h>
Sorry for the issues with reproducing. For what it's worth, I can
reproduce this locally and adding
#include "../firmware.h"
to drivers/base/firmware_loader/builtin/main.c fixes it for me.
Cheers,
Nathan
On Mon, Sep 13, 2021 at 10:25:35AM -0700, Nathan Chancellor wrote:
> On 9/13/2021 8:56 AM, Luis Chamberlain wrote:
> > On Fri, Sep 10, 2021 at 06:52:03PM -0700, Nathan Chancellor wrote:
> > > On Fri, Sep 10, 2021 at 05:48:23PM -0700, Luis Chamberlain wrote:
> > > > On Fri, Sep 10, 2021 at 03:41:31PM +0800, kernel test robot wrote:
> > > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git 20210908-firmware-builtin-v4
> > > > > head: 1c69d6a17750179d68bcaf6b16f9a08d2e475989
> > > > > commit: 79e9fce20ee88ffe37542a66277628e6c53dde14 [2/11] firmware_loader: formalize built-in firmware API
> > > > > config: hexagon-buildonly-randconfig-r004-20210910 (attached as .config)
> > > > > compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 261cbe98c38f8c1ee1a482fe76511110e790f58a)
> > > > > reproduce (this is a W=1 build):
> > > > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > > > > chmod +x ~/bin/make.cross
> > > > > # https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git/commit/?id=79e9fce20ee88ffe37542a66277628e6c53dde14
> > > > > git remote add mcgrof-next https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git
> > > > > git fetch --no-tags mcgrof-next 20210908-firmware-builtin-v4
> > > > > git checkout 79e9fce20ee88ffe37542a66277628e6c53dde14
> > > > > # save the attached .config to linux build tree
> > > > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=hexagon
> > > > >
> > > > > If you fix the issue, kindly add following tag as appropriate
> > > > > Reported-by: kernel test robot <[email protected]>
> > > > >
> > > > > All errors (new ones prefixed by >>):
> > > > >
> > > > > > > drivers/base/firmware_loader/builtin/main.c:36:6: error: no previous prototype for function 'firmware_is_builtin' [-Werror,-Wmissing-prototypes]
> > > > > bool firmware_is_builtin(const struct firmware *fw)
> > > >
> > > > This is a lie though its defined on drivers/base/firmware_loader/firmware.h
> > >
> > > Unless I am missing something, you don't include the firmware_loader
> > > copy of firmware.h in builtin/main.c (only the linux one)? Isn't that
> > > the source of the warning?
> >
> > You would think, but nope, its there:
> >
> > #include "firmware.h"
>
> I see that in drivers/base/firmware_loader/main.c but the warning is
> complaining about drivers/base/firmware_loader/builtin/main.c, where I only
> see
>
> #include <linux/firmware.h>
>
> Sorry for the issues with reproducing. For what it's worth, I can reproduce
> this locally and adding
>
> #include "../firmware.h"
>
> to drivers/base/firmware_loader/builtin/main.c fixes it for me.
Got it, thanks! I've ammended this change.
Luis
On 9/14/2021 12:21 AM, Luis Chamberlain wrote:
> On Mon, Sep 13, 2021 at 08:59:50AM -0700, Luis Chamberlain wrote:
>> On Sat, Sep 11, 2021 at 09:28:53AM +0800, Philip Li wrote:
>>> On Fri, Sep 10, 2021 at 05:48:23PM -0700, Luis Chamberlain wrote:
>>>> On Fri, Sep 10, 2021 at 03:41:31PM +0800, kernel test robot wrote:
>>>>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git 20210908-firmware-builtin-v4
>>>>> head: 1c69d6a17750179d68bcaf6b16f9a08d2e475989
>>>>> commit: 79e9fce20ee88ffe37542a66277628e6c53dde14 [2/11] firmware_loader: formalize built-in firmware API
>>>>> config: hexagon-buildonly-randconfig-r004-20210910 (attached as .config)
>>>>> compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 261cbe98c38f8c1ee1a482fe76511110e790f58a)
>>>>> reproduce (this is a W=1 build):
>>>>> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>>>>> chmod +x ~/bin/make.cross
>>>>> # https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git/commit/?id=79e9fce20ee88ffe37542a66277628e6c53dde14
>>>>> git remote add mcgrof-next https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git
>>>>> git fetch --no-tags mcgrof-next 20210908-firmware-builtin-v4
>>>>> git checkout 79e9fce20ee88ffe37542a66277628e6c53dde14
>>>>> # save the attached .config to linux build tree
>>>>> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=hexagon
>>>>>
>>>>> If you fix the issue, kindly add following tag as appropriate
>>>>> Reported-by: kernel test robot <[email protected]>
>>>>>
>>>>> All errors (new ones prefixed by >>):
>>>>>
>>>>>>> drivers/base/firmware_loader/builtin/main.c:36:6: error: no previous prototype for function 'firmware_is_builtin' [-Werror,-Wmissing-prototypes]
>>>>> bool firmware_is_builtin(const struct firmware *fw)
>>>>
>>>> This is a lie though its defined on drivers/base/firmware_loader/firmware.h
>>>>
>>>>> ^
>>>>> drivers/base/firmware_loader/builtin/main.c:36:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
>>>>> bool firmware_is_builtin(const struct firmware *fw)
>>>>> ^
>>>>> static
>>>>> 1 error generated.
>>>>
>>>> I get these odd errors:
>>>>
>>>> Compiler will be installed in /home/mcgrof/0day
>>> hi Luis, would you mind to download the make.cross tool again to give a try, it
>>> was updated recently to use latest clang instead of this 12.0.0?
>>
>> I had clang+llvm-12.0.0-cross-hexagon-unknown-linux-musl and this was
>> used already. Is there a more recent one? Just in case I rm -rf'd it
>> and tried again with the latest make.cross.
>
> I rm -rf ~/0day and tried again but the failure I get is:
>
> CALL scripts/checksyscalls.sh
> <stdin>:1515:2: warning: syscall clone3 not implemented [-W#warnings]
> #warning syscall clone3 not implemented
>
> Even if I disable CONFIG_WERROR and COMPILE_TEST this still fails here
> and so I can't even test compile the code in question.
>
> Luis
Hi Luis,
Sorry for the inconvenience, the error can be reproduced with W=1,
we'll update the reproduce step.
Best Regards,
Rong Chen