2021-10-05 06:05:20

by Marcel Ziswiler

Subject: [PATCH v1 1/4] dt-bindings: net: dsa: marvell: fix compatible in example

While the MV88E6390 switch chip exists, one is supposed to use a
compatible of "marvell,mv88e6190" for it. Fix this in the given example.

Signed-off-by: Marcel Ziswiler <[email protected]>
---

Documentation/devicetree/bindings/net/dsa/marvell.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/net/dsa/marvell.txt b/Documentation/devicetree/bindings/net/dsa/marvell.txt
index 30c11fea491bd..2363b412410c3 100644
--- a/Documentation/devicetree/bindings/net/dsa/marvell.txt
+++ b/Documentation/devicetree/bindings/net/dsa/marvell.txt
@@ -83,7 +83,7 @@ Example:
#interrupt-cells = <2>;

switch0: switch@0 {
- compatible = "marvell,mv88e6390";
+ compatible = "marvell,mv88e6190";
reg = <0>;
reset-gpios = <&gpio5 1 GPIO_ACTIVE_LOW>;

--
2.26.2

2021-10-05 12:50:11

by Andrew Lunn

Subject: Re: [PATCH v1 1/4] dt-bindings: net: dsa: marvell: fix compatible in example

On Tue, Oct 05, 2021 at 08:03:31AM +0200, Marcel Ziswiler wrote:
> While the MV88E6390 switch chip exists, one is supposed to use a
> compatible of "marvell,mv88e6190" for it. Fix this in the given example.
>
> Signed-off-by: Marcel Ziswiler <[email protected]>

Fixes: a3c53be55c95 ("net: dsa: mv88e6xxx: Support multiple MDIO busses")
Reviewed-by: Andrew Lunn <[email protected]>

Hi Marcel

Since this is a fix, it should be sent separately, and for net, not
net-next.

Thanks

Andrew

2021-10-05 12:59:04

by Andrew Lunn

Subject: Re: [PATCH v1 1/4] dt-bindings: net: dsa: marvell: fix compatible in example

On Tue, Oct 05, 2021 at 02:48:55PM +0200, Andrew Lunn wrote:
> On Tue, Oct 05, 2021 at 08:03:31AM +0200, Marcel Ziswiler wrote:
> > While the MV88E6390 switch chip exists, one is supposed to use a
> > compatible of "marvell,mv88e6190" for it. Fix this in the given example.
> >
> > Signed-off-by: Marcel Ziswiler <[email protected]>
>
> Fixes: a3c53be55c95 ("net: dsa: mv88e6xxx: Support multiple MDIO busses")
> Reviewed-by: Andrew Lunn <[email protected]>
>
> Hi Marcel
>
> Since this is a fix, it should be sent separately, and for net, not
> net-next.

Ah, i need to expand that comment a bit. This patch is effectively to
the networking subsystem, where as the reset are for
mvebu/arm-soc. They have different Maintainers. Please see:

https://www.kernel.org/doc/html/latest/networking/netdev-FAQ.html

Andrew