2021-10-18 06:08:28

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH] counter/counter-sysfs: use sysfs_emit everywhere

On Mon, Oct 18, 2021 at 08:33:34AM +0900, William Breathitt Gray wrote:
> On Sun, Oct 17, 2021 at 02:01:06PM -0500, David Lechner wrote:
> > In the counter subsystem, we are already using sysfs_emit(), but there
> > were a few places where we were still using sprintf() in *_show()
> > functions. For consistency and added protections, use sysfs_emit()
> > everywhere.
> >
> > Suggested-by: Greg KH <[email protected]>
> > Signed-off-by: David Lechner <[email protected]>
>
> Acked-by: William Breathitt Gray <[email protected]>

Thanks, want me to take this directly on top of the previous pull
request?

greg k-h


2021-10-18 08:21:37

by William Breathitt Gray

[permalink] [raw]
Subject: Re: [PATCH] counter/counter-sysfs: use sysfs_emit everywhere

On Mon, Oct 18, 2021 at 08:06:58AM +0200, Greg KH wrote:
> On Mon, Oct 18, 2021 at 08:33:34AM +0900, William Breathitt Gray wrote:
> > On Sun, Oct 17, 2021 at 02:01:06PM -0500, David Lechner wrote:
> > > In the counter subsystem, we are already using sysfs_emit(), but there
> > > were a few places where we were still using sprintf() in *_show()
> > > functions. For consistency and added protections, use sysfs_emit()
> > > everywhere.
> > >
> > > Suggested-by: Greg KH <[email protected]>
> > > Signed-off-by: David Lechner <[email protected]>
> >
> > Acked-by: William Breathitt Gray <[email protected]>
>
> Thanks, want me to take this directly on top of the previous pull
> request?
>
> greg k-h

Yes, that should be a fine path forward for this patch.

Thank you,

William Breathitt Gray


Attachments:
(No filename) (839.00 B)
signature.asc (849.00 B)
Download all attachments

2021-10-18 10:31:42

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH] counter/counter-sysfs: use sysfs_emit everywhere

On Mon, Oct 18, 2021 at 05:19:02PM +0900, William Breathitt Gray wrote:
> On Mon, Oct 18, 2021 at 08:06:58AM +0200, Greg KH wrote:
> > On Mon, Oct 18, 2021 at 08:33:34AM +0900, William Breathitt Gray wrote:
> > > On Sun, Oct 17, 2021 at 02:01:06PM -0500, David Lechner wrote:
> > > > In the counter subsystem, we are already using sysfs_emit(), but there
> > > > were a few places where we were still using sprintf() in *_show()
> > > > functions. For consistency and added protections, use sysfs_emit()
> > > > everywhere.
> > > >
> > > > Suggested-by: Greg KH <[email protected]>
> > > > Signed-off-by: David Lechner <[email protected]>
> > >
> > > Acked-by: William Breathitt Gray <[email protected]>
> >
> > Thanks, want me to take this directly on top of the previous pull
> > request?
> >
> > greg k-h
>
> Yes, that should be a fine path forward for this patch.

Great! Can you also ack the other patch from David as well?

thanks,

greg k-h