2021-10-10 07:10:34

by Saurav Girepunje

Subject: [PATCH] staging: rtl8723bs: hal: remove duplicate check

Remove 'bPerformance' from if condition check. As on previous
if condition it is already check for same variable.

Signed-off-by: Saurav Girepunje <[email protected]>
---
drivers/staging/rtl8723bs/hal/odm_DIG.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/hal/odm_DIG.c b/drivers/staging/rtl8723bs/hal/odm_DIG.c
index beda7b8a7c6a..7e92c373cddb 100644
--- a/drivers/staging/rtl8723bs/hal/odm_DIG.c
+++ b/drivers/staging/rtl8723bs/hal/odm_DIG.c
@@ -544,7 +544,7 @@ void odm_DIG(void *pDM_VOID)
/* 1 Adjust initial gain by false alarm */
if (pDM_Odm->bLinked && bPerformance) {

- if (bFirstTpTarget || (FirstConnect && bPerformance)) {
+ if (bFirstTpTarget || FirstConnect) {
pDM_DigTable->LargeFAHit = 0;

if (pDM_Odm->RSSI_Min < DIG_MaxOfMin) {
--
2.32.0

2021-10-10 13:48:59

by Hans de Goede

Subject: Re: [PATCH] staging: rtl8723bs: hal: remove duplicate check

Hi,

On 10/10/21 9:08 AM, Saurav Girepunje wrote:
> Remove 'bPerformance' from if condition check. As on previous
> if condition it is already check for same variable.
>
> Signed-off-by: Saurav Girepunje <[email protected]>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <[email protected]>

Regards,

Hans

> ---
> drivers/staging/rtl8723bs/hal/odm_DIG.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8723bs/hal/odm_DIG.c b/drivers/staging/rtl8723bs/hal/odm_DIG.c
> index beda7b8a7c6a..7e92c373cddb 100644
> --- a/drivers/staging/rtl8723bs/hal/odm_DIG.c
> +++ b/drivers/staging/rtl8723bs/hal/odm_DIG.c
> @@ -544,7 +544,7 @@ void odm_DIG(void *pDM_VOID)
> /* 1 Adjust initial gain by false alarm */
> if (pDM_Odm->bLinked && bPerformance) {
>
> - if (bFirstTpTarget || (FirstConnect && bPerformance)) {
> + if (bFirstTpTarget || FirstConnect) {
> pDM_DigTable->LargeFAHit = 0;
>
> if (pDM_Odm->RSSI_Min < DIG_MaxOfMin) {
> --
> 2.32.0
>