2021-10-15 15:36:49

by Jiabing Wan

Subject: [PATCH] of/unittest: Add of_node_put() before return

Fix following coccicheck warning:
./drivers/of/unittest.c:3091:1-23: WARNING: Function
for_each_child_of_node should have of_node_put() before return

Early exits from for_each_child_of_node should decrement the
node reference counter.

Signed-off-by: Wan Jiabing <[email protected]>
---
drivers/of/unittest.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c
index 8c056972a6dd..b8d2b669408a 100644
--- a/drivers/of/unittest.c
+++ b/drivers/of/unittest.c
@@ -3094,6 +3094,8 @@ static __init void of_unittest_overlay_high_level(void)
if (!strcmp(np->full_name, base_child->full_name)) {
unittest(0, "illegal node name in overlay_base %pOFn",
np);
+ of_node_put(np);
+ of_node_put(base_child);
return;
}
}
--
2.20.1

2021-10-20 18:00:05

by Rob Herring (Arm)

Subject: Re: [PATCH] of/unittest: Add of_node_put() before return

On Fri, 15 Oct 2021 04:26:58 -0400, Wan Jiabing wrote:
> Fix following coccicheck warning:
> ./drivers/of/unittest.c:3091:1-23: WARNING: Function
> for_each_child_of_node should have of_node_put() before return
>
> Early exits from for_each_child_of_node should decrement the
> node reference counter.
>
> Signed-off-by: Wan Jiabing <[email protected]>
> ---
> drivers/of/unittest.c | 2 ++
> 1 file changed, 2 insertions(+)
>

Applied, thanks!