2021-10-26 16:13:47

by Wang Hai

Subject: [PATCH net v2] usbnet: fix error return code in usbnet_probe()

Return error code if usb_maxpacket() returns 0 in usbnet_probe()

Fixes: 397430b50a36 ("usbnet: sanity check for maxpacket")
Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Wang Hai <[email protected]>
---
v1->v2: change '-EINVAL' to '-ENODEV'
drivers/net/usb/usbnet.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c
index 80432ee0ce69..a33d7fb82a00 100644
--- a/drivers/net/usb/usbnet.c
+++ b/drivers/net/usb/usbnet.c
@@ -1790,6 +1790,7 @@ usbnet_probe (struct usb_interface *udev, const struct usb_device_id *prod)
dev->maxpacket = usb_maxpacket (dev->udev, dev->out, 1);
if (dev->maxpacket == 0) {
/* that is a broken device */
+ status = -ENODEV;
goto out4;
}

--
2.25.1

2021-10-26 16:33:26

by Johan Hovold

Subject: Re: [PATCH net v2] usbnet: fix error return code in usbnet_probe()

On Tue, Oct 26, 2021 at 08:40:15PM +0800, Wang Hai wrote:
> Return error code if usb_maxpacket() returns 0 in usbnet_probe()
>
> Fixes: 397430b50a36 ("usbnet: sanity check for maxpacket")
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Wang Hai <[email protected]>

This needs to go to stable as well as the offending patch is being
backported.

Cc: [email protected]
Reviewed-by: Johan Hovold <[email protected]>

> ---
> v1->v2: change '-EINVAL' to '-ENODEV'
> drivers/net/usb/usbnet.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c
> index 80432ee0ce69..a33d7fb82a00 100644
> --- a/drivers/net/usb/usbnet.c
> +++ b/drivers/net/usb/usbnet.c
> @@ -1790,6 +1790,7 @@ usbnet_probe (struct usb_interface *udev, const struct usb_device_id *prod)
> dev->maxpacket = usb_maxpacket (dev->udev, dev->out, 1);
> if (dev->maxpacket == 0) {
> /* that is a broken device */
> + status = -ENODEV;
> goto out4;
> }

Johan

2021-10-27 21:33:54

by patchwork-bot+netdevbpf

Subject: Re: [PATCH net v2] usbnet: fix error return code in usbnet_probe()

Hello:

This patch was applied to netdev/net.git (master)
by Jakub Kicinski <[email protected]>:

On Tue, 26 Oct 2021 20:40:15 +0800 you wrote:
> Return error code if usb_maxpacket() returns 0 in usbnet_probe()
>
> Fixes: 397430b50a36 ("usbnet: sanity check for maxpacket")
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Wang Hai <[email protected]>
> ---
> v1->v2: change '-EINVAL' to '-ENODEV'
> drivers/net/usb/usbnet.c | 1 +
> 1 file changed, 1 insertion(+)

Here is the summary with links:
- [net,v2] usbnet: fix error return code in usbnet_probe()
https://git.kernel.org/netdev/net/c/6f7c88691191

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html