2021-10-26 11:09:36

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: build warning after merge of the net-next tree

Hi all,

After merging the net-next tree, today's linux-next build (htmldocs)
produced this warning:

drivers/net/phy/phy-c45.c:624: warning: Function parameter or member 'enable' not described in 'genphy_c45_fast_retrain'

Introduced by commit

63c67f526db8 ("net: phy: add genphy_c45_fast_retrain")

--
Cheers,
Stephen Rothwell

Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2021-10-27 21:26:48

by Russell King (Oracle)

[permalink] [raw]
Subject: Re: linux-next: build warning after merge of the net-next tree

On Wed, Oct 27, 2021 at 10:07:21PM +1100, Stephen Rothwell wrote:
> Hi all,
>
> After merging the net-next tree, today's linux-next build (htmldocs)
> produced this warning:
>
> include/linux/phylink.h:82: warning: Function parameter or member 'DECLARE_PHY_INTERFACE_MASK(supported_interfaces' not described in 'phylink_config'
>
> Introduced by commit
>
> 38c310eb46f5 ("net: phylink: add MAC phy_interface_t bitmap")
>
> Or maybe this is a problem with the tool ...

Hmm. Looks like it is a tooling problem.

* @supported_interfaces: bitmap describing which PHY_INTERFACE_MODE_xxx
* are supported by the MAC/PCS.

DECLARE_PHY_INTERFACE_MASK(supported_interfaces);

I'm guessing the tool doesn't use the preprocessed source. I'm not sure
what the solution to this would be.

--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

2021-10-30 02:14:53

by Randy Dunlap

[permalink] [raw]
Subject: Re: linux-next: build warning after merge of the net-next tree

On 10/27/21 4:34 AM, Russell King (Oracle) wrote:
> On Wed, Oct 27, 2021 at 10:07:21PM +1100, Stephen Rothwell wrote:
>> Hi all,
>>
>> After merging the net-next tree, today's linux-next build (htmldocs)
>> produced this warning:
>>
>> include/linux/phylink.h:82: warning: Function parameter or member 'DECLARE_PHY_INTERFACE_MASK(supported_interfaces' not described in 'phylink_config'
>>
>> Introduced by commit
>>
>> 38c310eb46f5 ("net: phylink: add MAC phy_interface_t bitmap")
>>
>> Or maybe this is a problem with the tool ...
>
> Hmm. Looks like it is a tooling problem.
>
> * @supported_interfaces: bitmap describing which PHY_INTERFACE_MODE_xxx
> * are supported by the MAC/PCS.
>
> DECLARE_PHY_INTERFACE_MASK(supported_interfaces);
>
> I'm guessing the tool doesn't use the preprocessed source. I'm not sure
> what the solution to this would be.
>

I just sent a patch to scripts/kernel-doc to support that macro.

--
~Randy