2021-10-27 09:22:40

by Corentin LABBE

Subject: [PATCH] net: ethernet: cortina: permit to set mac address in DT

Add ability of setting mac address in DT for cortina ethernet driver.

Signed-off-by: Corentin Labbe <[email protected]>
---
drivers/net/ethernet/cortina/gemini.c | 8 ++++++++
1 file changed, 8 insertions(+)

diff --git a/drivers/net/ethernet/cortina/gemini.c b/drivers/net/ethernet/cortina/gemini.c
index 941f175fb911..f6aa2387a1af 100644
--- a/drivers/net/ethernet/cortina/gemini.c
+++ b/drivers/net/ethernet/cortina/gemini.c
@@ -2356,12 +2356,14 @@ static void gemini_port_save_mac_addr(struct gemini_ethernet_port *port)
static int gemini_ethernet_port_probe(struct platform_device *pdev)
{
char *port_names[2] = { "ethernet0", "ethernet1" };
+ struct device_node *np = pdev->dev.of_node;
struct gemini_ethernet_port *port;
struct device *dev = &pdev->dev;
struct gemini_ethernet *geth;
struct net_device *netdev;
struct device *parent;
unsigned int id;
+ u8 mac[ETH_ALEN];
int irq;
int ret;

@@ -2466,6 +2468,12 @@ static int gemini_ethernet_port_probe(struct platform_device *pdev)
netif_napi_add(netdev, &port->napi, gmac_napi_poll,
DEFAULT_NAPI_WEIGHT);

+ ret = of_get_mac_address(np, mac);
+ if (!ret) {
+ dev_info(dev, "Setting macaddr from DT %pM\n", mac);
+ memcpy(port->mac_addr, mac, ETH_ALEN);
+ }
+
if (is_valid_ether_addr((void *)port->mac_addr)) {
eth_hw_addr_set(netdev, (u8 *)port->mac_addr);
} else {
--
2.32.0

2021-10-27 10:15:34

by Linus Walleij

Subject: Re: [PATCH] net: ethernet: cortina: permit to set mac address in DT

On Tue, Oct 26, 2021 at 9:17 PM Corentin Labbe <[email protected]> wrote:

> Add ability of setting mac address in DT for cortina ethernet driver.
>
> Signed-off-by: Corentin Labbe <[email protected]>

That looks useful!
Reviewed-by: Linus Walleij <[email protected]>

Yours,
Linus Walleij

2021-10-27 13:43:37

by Andrew Lunn

Subject: Re: [PATCH] net: ethernet: cortina: permit to set mac address in DT

On Tue, Oct 26, 2021 at 07:17:03PM +0000, Corentin Labbe wrote:
> Add ability of setting mac address in DT for cortina ethernet driver.
>
> Signed-off-by: Corentin Labbe <[email protected]>
> ---
> drivers/net/ethernet/cortina/gemini.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/net/ethernet/cortina/gemini.c b/drivers/net/ethernet/cortina/gemini.c
> index 941f175fb911..f6aa2387a1af 100644
> --- a/drivers/net/ethernet/cortina/gemini.c
> +++ b/drivers/net/ethernet/cortina/gemini.c
> @@ -2356,12 +2356,14 @@ static void gemini_port_save_mac_addr(struct gemini_ethernet_port *port)
> static int gemini_ethernet_port_probe(struct platform_device *pdev)
> {
> char *port_names[2] = { "ethernet0", "ethernet1" };
> + struct device_node *np = pdev->dev.of_node;
> struct gemini_ethernet_port *port;
> struct device *dev = &pdev->dev;
> struct gemini_ethernet *geth;
> struct net_device *netdev;
> struct device *parent;
> unsigned int id;
> + u8 mac[ETH_ALEN];

Off by one in terms of reverse Christmas tree.

Andrew

2021-11-02 09:52:41

by Corentin Labbe

Subject: Re: [PATCH] net: ethernet: cortina: permit to set mac address in DT

Le Wed, Oct 27, 2021 at 02:08:04AM +0200, Andrew Lunn a ?crit :
> On Tue, Oct 26, 2021 at 07:17:03PM +0000, Corentin Labbe wrote:
> > Add ability of setting mac address in DT for cortina ethernet driver.
> >
> > Signed-off-by: Corentin Labbe <[email protected]>
> > ---
> > drivers/net/ethernet/cortina/gemini.c | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> >
> > diff --git a/drivers/net/ethernet/cortina/gemini.c b/drivers/net/ethernet/cortina/gemini.c
> > index 941f175fb911..f6aa2387a1af 100644
> > --- a/drivers/net/ethernet/cortina/gemini.c
> > +++ b/drivers/net/ethernet/cortina/gemini.c
> > @@ -2356,12 +2356,14 @@ static void gemini_port_save_mac_addr(struct gemini_ethernet_port *port)
> > static int gemini_ethernet_port_probe(struct platform_device *pdev)
> > {
> > char *port_names[2] = { "ethernet0", "ethernet1" };
> > + struct device_node *np = pdev->dev.of_node;
> > struct gemini_ethernet_port *port;
> > struct device *dev = &pdev->dev;
> > struct gemini_ethernet *geth;
> > struct net_device *netdev;
> > struct device *parent;
> > unsigned int id;
> > + u8 mac[ETH_ALEN];
>
> Off by one in terms of reverse Christmas tree.
>

Hello

I will fix it in a v2

Thanks
Regards