2021-12-03 13:35:22

by Geert Uytterhoeven

Subject: [PATCH 1/3] dt-bindings: input: gpio-keys: Fix interrupts in example

The "interrupts" property in the example looks weird:
- The type is not in the last cell,
- Level interrupts don't work well with gpio-keys, as they keep the
interrupt asserted as long as the key is pressed, causing an
interrupt storm.

Use a more realistic falling-edge interrupt instead.

Signed-off-by: Geert Uytterhoeven <[email protected]>
---
Documentation/devicetree/bindings/input/gpio-keys.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/input/gpio-keys.yaml b/Documentation/devicetree/bindings/input/gpio-keys.yaml
index 060a309ff8e7c757..dbe7ecc19ccb9423 100644
--- a/Documentation/devicetree/bindings/input/gpio-keys.yaml
+++ b/Documentation/devicetree/bindings/input/gpio-keys.yaml
@@ -142,7 +142,7 @@ examples:
down {
label = "GPIO Key DOWN";
linux,code = <108>;
- interrupts = <1 IRQ_TYPE_LEVEL_HIGH 7>;
+ interrupts = <1 IRQ_TYPE_EDGE_FALLING>;
};
};

--
2.25.1

2021-12-06 20:17:05

by Rob Herring

Subject: Re: [PATCH 1/3] dt-bindings: input: gpio-keys: Fix interrupts in example

On Fri, 03 Dec 2021 14:35:06 +0100, Geert Uytterhoeven wrote:
> The "interrupts" property in the example looks weird:
> - The type is not in the last cell,
> - Level interrupts don't work well with gpio-keys, as they keep the
> interrupt asserted as long as the key is pressed, causing an
> interrupt storm.
>
> Use a more realistic falling-edge interrupt instead.
>
> Signed-off-by: Geert Uytterhoeven <[email protected]>
> ---
> Documentation/devicetree/bindings/input/gpio-keys.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>

Applied, thanks!