2022-01-26 21:04:51

by Aditya Garg

Subject: [PATCH RESEND] media: uvcvideo: Add support for Apple T2-attached FaceTime HD Camera

From: Paul Pawlowski <[email protected]>

Adds the requisite device id to support detection of the Apple FaceTime
HD webcam exposed over the T2 BCE VHCI interface.

Tested-by: Aun-Ali Zaidi <[email protected]>
Signed-off-by: Paul Pawlowski <[email protected]>
Signed-off-by: Aun-Ali Zaidi <[email protected]>
Signed-off-by: Aditya Garg <[email protected]>
---
drivers/media/usb/uvc/uvc_driver.c | 9 +++++++++
1 file changed, 9 insertions(+)

diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c
index 7c007426e..88dc9e7aa 100644
--- a/drivers/media/usb/uvc/uvc_driver.c
+++ b/drivers/media/usb/uvc/uvc_driver.c
@@ -2848,6 +2848,15 @@ static const struct usb_device_id uvc_ids[] = {
.bInterfaceProtocol = 0,
.driver_info = UVC_INFO_QUIRK(UVC_QUIRK_PROBE_MINMAX
| UVC_QUIRK_BUILTIN_ISIGHT) },
+ /* Apple FaceTime HD Camera (Built-In) */
+ { .match_flags = USB_DEVICE_ID_MATCH_DEVICE
+ | USB_DEVICE_ID_MATCH_INT_INFO,
+ .idVendor = 0x05ac,
+ .idProduct = 0x8514,
+ .bInterfaceClass = USB_CLASS_VIDEO,
+ .bInterfaceSubClass = 1,
+ .bInterfaceProtocol = 0,
+ .driver_info = (kernel_ulong_t)&uvc_quirk_probe_def },
/* Apple Built-In iSight via iBridge */
{ .match_flags = USB_DEVICE_ID_MATCH_DEVICE
| USB_DEVICE_ID_MATCH_INT_INFO,
--
2.25.1

2022-02-01 15:50:01

by Aditya Garg

Subject: Re: [PATCH RESEND] media: uvcvideo: Add support for Apple T2-attached FaceTime HD Camera

Hi Maintainers

I sent this patch on 12.01.22 and then resent it on 26.01.22. I still haven't received a reply yet. Maybe I am not sending the mail to the correct maintainer? I request someone to reply cause no reply seems to create a confusion.

Linus, I am sending this mail to you too, since you are the ultimate maintainer.

Regards
Aditya
> On 26-Jan-2022, at 4:07 PM, Aditya Garg <[email protected]> wrote:
>
> From: Paul Pawlowski <[email protected]>
>
> Adds the requisite device id to support detection of the Apple FaceTime
> HD webcam exposed over the T2 BCE VHCI interface.
>
> Tested-by: Aun-Ali Zaidi <[email protected]>
> Signed-off-by: Paul Pawlowski <[email protected]>
> Signed-off-by: Aun-Ali Zaidi <[email protected]>
> Signed-off-by: Aditya Garg <[email protected]>
> ---
> drivers/media/usb/uvc/uvc_driver.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c
> index 7c007426e..88dc9e7aa 100644
> --- a/drivers/media/usb/uvc/uvc_driver.c
> +++ b/drivers/media/usb/uvc/uvc_driver.c
> @@ -2848,6 +2848,15 @@ static const struct usb_device_id uvc_ids[] = {
> .bInterfaceProtocol = 0,
> .driver_info = UVC_INFO_QUIRK(UVC_QUIRK_PROBE_MINMAX
> | UVC_QUIRK_BUILTIN_ISIGHT) },
> + /* Apple FaceTime HD Camera (Built-In) */
> + { .match_flags = USB_DEVICE_ID_MATCH_DEVICE
> + | USB_DEVICE_ID_MATCH_INT_INFO,
> + .idVendor = 0x05ac,
> + .idProduct = 0x8514,
> + .bInterfaceClass = USB_CLASS_VIDEO,
> + .bInterfaceSubClass = 1,
> + .bInterfaceProtocol = 0,
> + .driver_info = (kernel_ulong_t)&uvc_quirk_probe_def },
> /* Apple Built-In iSight via iBridge */
> { .match_flags = USB_DEVICE_ID_MATCH_DEVICE
> | USB_DEVICE_ID_MATCH_INT_INFO,
> --
> 2.25.1
>
>

2022-02-02 13:50:48

by Aditya Garg

Subject: Re: [PATCH RESEND] media: uvcvideo: Add support for Apple T2-attached FaceTime HD Camera

Hi Laurent

> On 02-Feb-2022, at 12:07 PM, Laurent Pinchart <[email protected]> wrote:
>
> Hi Aditya,
>
> Thank you for the patch, and sorry for the late reply.
>
> On Wed, Jan 26, 2022 at 10:37:13AM +0000, Aditya Garg wrote:
>> From: Paul Pawlowski <[email protected]>
>>
>> Adds the requisite device id to support detection of the Apple FaceTime
>> HD webcam exposed over the T2 BCE VHCI interface.
>>
>> Tested-by: Aun-Ali Zaidi <[email protected]>
>> Signed-off-by: Paul Pawlowski <[email protected]>
>> Signed-off-by: Aun-Ali Zaidi <[email protected]>
>> Signed-off-by: Aditya Garg <[email protected]>
>> ---
>> drivers/media/usb/uvc/uvc_driver.c | 9 +++++++++
>> 1 file changed, 9 insertions(+)
>>
>> diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c
>> index 7c007426e..88dc9e7aa 100644
>> --- a/drivers/media/usb/uvc/uvc_driver.c
>> +++ b/drivers/media/usb/uvc/uvc_driver.c
>> @@ -2848,6 +2848,15 @@ static const struct usb_device_id uvc_ids[] = {
>> .bInterfaceProtocol = 0,
>> .driver_info = UVC_INFO_QUIRK(UVC_QUIRK_PROBE_MINMAX
>> | UVC_QUIRK_BUILTIN_ISIGHT) },
>> + /* Apple FaceTime HD Camera (Built-In) */
>> + { .match_flags = USB_DEVICE_ID_MATCH_DEVICE
>> + | USB_DEVICE_ID_MATCH_INT_INFO,
>> + .idVendor = 0x05ac,
>> + .idProduct = 0x8514,
>> + .bInterfaceClass = USB_CLASS_VIDEO,
>> + .bInterfaceSubClass = 1,
>> + .bInterfaceProtocol = 0,
>> + .driver_info = (kernel_ulong_t)&uvc_quirk_probe_def },
>
> Have you tested that the device doesn't work without this quirk ?
uvcvideo 1-2:1.1: Failed to query (129) UVC probe control : -110 (exp. 48).
uvcvideo 1-2:1.1: Failed to initialize the device (-5).

These errors are encountered without this patch
>
>> /* Apple Built-In iSight via iBridge */
>> { .match_flags = USB_DEVICE_ID_MATCH_DEVICE
>> | USB_DEVICE_ID_MATCH_INT_INFO,
>
> --
> Regards,
>
> Laurent Pinchart

2022-02-03 14:33:39

by Laurent Pinchart

Subject: Re: [PATCH RESEND] media: uvcvideo: Add support for Apple T2-attached FaceTime HD Camera

Hi Aditya,

On Wed, Feb 02, 2022 at 07:08:21AM +0000, Aditya Garg wrote:
> > On 02-Feb-2022, at 12:07 PM, Laurent Pinchart wrote:
> > On Wed, Jan 26, 2022 at 10:37:13AM +0000, Aditya Garg wrote:
> >> From: Paul Pawlowski <[email protected]>
> >>
> >> Adds the requisite device id to support detection of the Apple FaceTime
> >> HD webcam exposed over the T2 BCE VHCI interface.
> >>
> >> Tested-by: Aun-Ali Zaidi <[email protected]>
> >> Signed-off-by: Paul Pawlowski <[email protected]>
> >> Signed-off-by: Aun-Ali Zaidi <[email protected]>
> >> Signed-off-by: Aditya Garg <[email protected]>
> >> ---
> >> drivers/media/usb/uvc/uvc_driver.c | 9 +++++++++
> >> 1 file changed, 9 insertions(+)
> >>
> >> diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c
> >> index 7c007426e..88dc9e7aa 100644
> >> --- a/drivers/media/usb/uvc/uvc_driver.c
> >> +++ b/drivers/media/usb/uvc/uvc_driver.c
> >> @@ -2848,6 +2848,15 @@ static const struct usb_device_id uvc_ids[] = {
> >> .bInterfaceProtocol = 0,
> >> .driver_info = UVC_INFO_QUIRK(UVC_QUIRK_PROBE_MINMAX
> >> | UVC_QUIRK_BUILTIN_ISIGHT) },
> >> + /* Apple FaceTime HD Camera (Built-In) */
> >> + { .match_flags = USB_DEVICE_ID_MATCH_DEVICE
> >> + | USB_DEVICE_ID_MATCH_INT_INFO,
> >> + .idVendor = 0x05ac,
> >> + .idProduct = 0x8514,
> >> + .bInterfaceClass = USB_CLASS_VIDEO,
> >> + .bInterfaceSubClass = 1,
> >> + .bInterfaceProtocol = 0,
> >> + .driver_info = (kernel_ulong_t)&uvc_quirk_probe_def },
> >
> > Have you tested that the device doesn't work without this quirk ?
>
> uvcvideo 1-2:1.1: Failed to query (129) UVC probe control : -110 (exp. 48).
> uvcvideo 1-2:1.1: Failed to initialize the device (-5).
>
> These errors are encountered without this patch

Thank you for the confirmation.

Reviewed-by: Laurent Pinchart <[email protected]>

and applied to my tree.

> >> /* Apple Built-In iSight via iBridge */
> >> { .match_flags = USB_DEVICE_ID_MATCH_DEVICE
> >> | USB_DEVICE_ID_MATCH_INT_INFO,

--
Regards,

Laurent Pinchart

2022-02-03 18:03:37

by Aditya Garg

Subject: Re: [PATCH RESEND] media: uvcvideo: Add support for Apple T2-attached FaceTime HD Camera

> On 03-Feb-2022, at 5:29 AM, Laurent Pinchart <[email protected]> wrote:
>
> Hi Aditya,
>
> On Wed, Feb 02, 2022 at 07:08:21AM +0000, Aditya Garg wrote:
>>> On 02-Feb-2022, at 12:07 PM, Laurent Pinchart wrote:
>>> On Wed, Jan 26, 2022 at 10:37:13AM +0000, Aditya Garg wrote:
>>>> From: Paul Pawlowski <[email protected]>
>>>>
>>>> Adds the requisite device id to support detection of the Apple FaceTime
>>>> HD webcam exposed over the T2 BCE VHCI interface.
>>>>
>>>> Tested-by: Aun-Ali Zaidi <[email protected]>
>>>> Signed-off-by: Paul Pawlowski <[email protected]>
>>>> Signed-off-by: Aun-Ali Zaidi <[email protected]>
>>>> Signed-off-by: Aditya Garg <[email protected]>
>>>> ---
>>>> drivers/media/usb/uvc/uvc_driver.c | 9 +++++++++
>>>> 1 file changed, 9 insertions(+)
>>>>
>>>> diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c
>>>> index 7c007426e..88dc9e7aa 100644
>>>> --- a/drivers/media/usb/uvc/uvc_driver.c
>>>> +++ b/drivers/media/usb/uvc/uvc_driver.c
>>>> @@ -2848,6 +2848,15 @@ static const struct usb_device_id uvc_ids[] = {
>>>> .bInterfaceProtocol = 0,
>>>> .driver_info = UVC_INFO_QUIRK(UVC_QUIRK_PROBE_MINMAX
>>>> | UVC_QUIRK_BUILTIN_ISIGHT) },
>>>> + /* Apple FaceTime HD Camera (Built-In) */
>>>> + { .match_flags = USB_DEVICE_ID_MATCH_DEVICE
>>>> + | USB_DEVICE_ID_MATCH_INT_INFO,
>>>> + .idVendor = 0x05ac,
>>>> + .idProduct = 0x8514,
>>>> + .bInterfaceClass = USB_CLASS_VIDEO,
>>>> + .bInterfaceSubClass = 1,
>>>> + .bInterfaceProtocol = 0,
>>>> + .driver_info = (kernel_ulong_t)&uvc_quirk_probe_def },
>>>
>>> Have you tested that the device doesn't work without this quirk ?
>>
>> uvcvideo 1-2:1.1: Failed to query (129) UVC probe control : -110 (exp. 48).
>> uvcvideo 1-2:1.1: Failed to initialize the device (-5).
>>
>> These errors are encountered without this patch
>
> Thank you for the confirmation.
>
> Reviewed-by: Laurent Pinchart <[email protected]>
>
> and applied to my tree.
Thanks !
>
>>>> /* Apple Built-In iSight via iBridge */
>>>> { .match_flags = USB_DEVICE_ID_MATCH_DEVICE
>>>> | USB_DEVICE_ID_MATCH_INT_INFO,
>
> --
> Regards,
>
> Laurent Pinchart

2022-02-03 22:01:34

by Sergey Senozhatsky

Subject: Re: [PATCH RESEND] media: uvcvideo: Add support for Apple T2-attached FaceTime HD Camera

On (22/01/31 09:12), Aditya Garg wrote:
> > On 26-Jan-2022, at 4:07 PM, Aditya Garg <[email protected]> wrote:
> >
> > From: Paul Pawlowski <[email protected]>
> >
> > Adds the requisite device id to support detection of the Apple FaceTime
> > HD webcam exposed over the T2 BCE VHCI interface.
> >
> > Tested-by: Aun-Ali Zaidi <[email protected]>
> > Signed-off-by: Paul Pawlowski <[email protected]>
> > Signed-off-by: Aun-Ali Zaidi <[email protected]>
> > Signed-off-by: Aditya Garg <[email protected]>

I'm not the maintainer, but the patch looks OK to me
FWIW
Reviewed-by: Sergey Senozhatsky <[email protected]>


Laurent, Ricardo, any thoughts?


> > drivers/media/usb/uvc/uvc_driver.c | 9 +++++++++
> > 1 file changed, 9 insertions(+)
> >
> > diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c
> > index 7c007426e..88dc9e7aa 100644
> > --- a/drivers/media/usb/uvc/uvc_driver.c
> > +++ b/drivers/media/usb/uvc/uvc_driver.c
> > @@ -2848,6 +2848,15 @@ static const struct usb_device_id uvc_ids[] = {
> > .bInterfaceProtocol = 0,
> > .driver_info = UVC_INFO_QUIRK(UVC_QUIRK_PROBE_MINMAX
> > | UVC_QUIRK_BUILTIN_ISIGHT) },
> > + /* Apple FaceTime HD Camera (Built-In) */
> > + { .match_flags = USB_DEVICE_ID_MATCH_DEVICE
> > + | USB_DEVICE_ID_MATCH_INT_INFO,
> > + .idVendor = 0x05ac,
> > + .idProduct = 0x8514,
> > + .bInterfaceClass = USB_CLASS_VIDEO,
> > + .bInterfaceSubClass = 1,
> > + .bInterfaceProtocol = 0,
> > + .driver_info = (kernel_ulong_t)&uvc_quirk_probe_def },
> > /* Apple Built-In iSight via iBridge */
> > { .match_flags = USB_DEVICE_ID_MATCH_DEVICE
> > | USB_DEVICE_ID_MATCH_INT_INFO,

2022-02-04 08:54:36

by Laurent Pinchart

Subject: Re: [PATCH RESEND] media: uvcvideo: Add support for Apple T2-attached FaceTime HD Camera

Hi Aditya,

Thank you for the patch, and sorry for the late reply.

On Wed, Jan 26, 2022 at 10:37:13AM +0000, Aditya Garg wrote:
> From: Paul Pawlowski <[email protected]>
>
> Adds the requisite device id to support detection of the Apple FaceTime
> HD webcam exposed over the T2 BCE VHCI interface.
>
> Tested-by: Aun-Ali Zaidi <[email protected]>
> Signed-off-by: Paul Pawlowski <[email protected]>
> Signed-off-by: Aun-Ali Zaidi <[email protected]>
> Signed-off-by: Aditya Garg <[email protected]>
> ---
> drivers/media/usb/uvc/uvc_driver.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c
> index 7c007426e..88dc9e7aa 100644
> --- a/drivers/media/usb/uvc/uvc_driver.c
> +++ b/drivers/media/usb/uvc/uvc_driver.c
> @@ -2848,6 +2848,15 @@ static const struct usb_device_id uvc_ids[] = {
> .bInterfaceProtocol = 0,
> .driver_info = UVC_INFO_QUIRK(UVC_QUIRK_PROBE_MINMAX
> | UVC_QUIRK_BUILTIN_ISIGHT) },
> + /* Apple FaceTime HD Camera (Built-In) */
> + { .match_flags = USB_DEVICE_ID_MATCH_DEVICE
> + | USB_DEVICE_ID_MATCH_INT_INFO,
> + .idVendor = 0x05ac,
> + .idProduct = 0x8514,
> + .bInterfaceClass = USB_CLASS_VIDEO,
> + .bInterfaceSubClass = 1,
> + .bInterfaceProtocol = 0,
> + .driver_info = (kernel_ulong_t)&uvc_quirk_probe_def },

Have you tested that the device doesn't work without this quirk ?

> /* Apple Built-In iSight via iBridge */
> { .match_flags = USB_DEVICE_ID_MATCH_DEVICE
> | USB_DEVICE_ID_MATCH_INT_INFO,

--
Regards,

Laurent Pinchart