2022-02-02 09:06:25

by Rafael J. Wysocki

Subject: [PATCH] IOMMU: Intel: DMAR: Replace acpi_bus_get_device()

From: Rafael J. Wysocki <[email protected]>

Replace acpi_bus_get_device() that is going to be dropped with
acpi_fetch_acpi_dev().

No intentional functional impact.

Signed-off-by: Rafael J. Wysocki <[email protected]>
---
drivers/iommu/intel/dmar.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

Index: linux-pm/drivers/iommu/intel/dmar.c
===================================================================
--- linux-pm.orig/drivers/iommu/intel/dmar.c
+++ linux-pm/drivers/iommu/intel/dmar.c
@@ -789,7 +789,8 @@ static int __init dmar_acpi_dev_scope_in
andd->device_name);
continue;
}
- if (acpi_bus_get_device(h, &adev)) {
+ adev = acpi_fetch_acpi_dev(h);
+ if (!adev) {
pr_err("Failed to get device for ACPI object %s\n",
andd->device_name);
continue;

2022-02-05 14:52:46

by Lu Baolu

Subject: Re: [PATCH] IOMMU: Intel: DMAR: Replace acpi_bus_get_device()

On 2022/2/2 2:11, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <[email protected]>
>
> Replace acpi_bus_get_device() that is going to be dropped with
> acpi_fetch_acpi_dev().
>
> No intentional functional impact.
>
> Signed-off-by: Rafael J. Wysocki <[email protected]>
> ---
> drivers/iommu/intel/dmar.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> Index: linux-pm/drivers/iommu/intel/dmar.c
> ===================================================================
> --- linux-pm.orig/drivers/iommu/intel/dmar.c
> +++ linux-pm/drivers/iommu/intel/dmar.c
> @@ -789,7 +789,8 @@ static int __init dmar_acpi_dev_scope_in
> andd->device_name);
> continue;
> }
> - if (acpi_bus_get_device(h, &adev)) {
> + adev = acpi_fetch_acpi_dev(h);
> + if (!adev) {
> pr_err("Failed to get device for ACPI object %s\n",
> andd->device_name);
> continue;

Please adjust the patch title to "iommu/vtd: Replace acpi_bus_get_device()"

Reviewed-by: Lu Baolu <[email protected]>

Best regards,
baolu

2022-02-14 21:05:08

by Joerg Roedel

Subject: Re: [PATCH] IOMMU: Intel: DMAR: Replace acpi_bus_get_device()

On Tue, Feb 01, 2022 at 07:11:40PM +0100, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <[email protected]>
>
> Replace acpi_bus_get_device() that is going to be dropped with
> acpi_fetch_acpi_dev().
>
> No intentional functional impact.
>
> Signed-off-by: Rafael J. Wysocki <[email protected]>
> ---
> drivers/iommu/intel/dmar.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)

Applied with adjusted subject, thanks Rafael.