The two members create_user_ah and create_ah in struct ib_device_ops
are very similar. we can use create_ah for all case. so get rid of
create_user_ah.
Yajun Deng (9):
RDMA/core: get rid of create_user_ah
RDMA/bnxt_re: get rid of create_user_ah
RDMA/efa: get rid of create_user_ah
RDMA/hns: get rid of create_user_ah
RDMA/irdma: get rid of create_user_ah
RDMA/mlx5: get rid of create_user_ah
RDMA/ocrdma: get rid of create_user_ah
RDMA/rdmavt: get rid of create_user_ah
RDMA/rxe: get rid of create_user_ah
drivers/infiniband/core/device.c | 1 -
drivers/infiniband/core/uverbs_cmd.c | 2 +-
drivers/infiniband/core/verbs.c | 7 ++-----
drivers/infiniband/hw/bnxt_re/main.c | 1 -
drivers/infiniband/hw/efa/efa_main.c | 2 +-
drivers/infiniband/hw/efa/efa_verbs.c | 5 +++++
drivers/infiniband/hw/hns/hns_roce_main.c | 1 -
drivers/infiniband/hw/irdma/verbs.c | 1 -
drivers/infiniband/hw/mlx5/main.c | 1 -
drivers/infiniband/hw/ocrdma/ocrdma_main.c | 1 -
drivers/infiniband/sw/rdmavt/vt.c | 1 -
drivers/infiniband/sw/rxe/rxe_verbs.c | 1 -
include/rdma/ib_verbs.h | 2 --
13 files changed, 9 insertions(+), 17 deletions(-)
--
2.25.1
Thank you for the tip.
-- Yajun
March 9, 2022 5:21 PM, "Leon Romanovsky" <[email protected]> wrote:
> On Tue, Mar 08, 2022 at 10:34:28PM +0800, Yajun Deng wrote:
>
>> The two members create_user_ah and create_ah in struct ib_device_ops
>> are very similar. we can use create_ah for all case. so get rid of
>> create_user_ah.
>
> 1. Please read commit message and content of commit 676a80adba01
> ("RDMA: Remove AH from uverbs_cmd_mask") that added that .create_user_ah()
> callback.
> 2. You should send patches as a series that is threaded and not as
> stand-alone patches.
>
> Thanks
On Tue, Mar 08, 2022 at 10:34:28PM +0800, Yajun Deng wrote:
> The two members create_user_ah and create_ah in struct ib_device_ops
> are very similar. we can use create_ah for all case. so get rid of
> create_user_ah.
1. Please read commit message and content of commit 676a80adba01
("RDMA: Remove AH from uverbs_cmd_mask") that added that .create_user_ah()
callback.
2. You should send patches as a series that is threaded and not as
stand-alone patches.
Thanks