2022-03-16 09:52:29

by Charlie Sands

Subject: [PATCH] staging: rts5208: Resolve checkpath.pl issues.

This patch remedies the following checkpath.pl issues:

WARNING: Unnecessary ftrace-like logging - prefer using ftrace
+ dev_info(&dev->pci->dev, "%s called\n", __func__);

WARNING: Unnecessary ftrace-like logging - prefer using ftrace
+ dev_info(&dev->pci->dev, "%s called\n", __func__);

WARNING: Unnecessary ftrace-like logging - prefer using ftrace
+ dev_info(&pci->dev, "%s called\n", __func__);

Signed-off-by: Charlie Sands <[email protected]>
---
drivers/staging/rts5208/rtsx.c | 6 ------
1 file changed, 6 deletions(-)

diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/rts5208/rtsx.c
index 5a58dac76c88..643d33b9a239 100644
--- a/drivers/staging/rts5208/rtsx.c
+++ b/drivers/staging/rts5208/rtsx.c
@@ -159,8 +159,6 @@ static int command_abort(struct scsi_cmnd *srb)
struct rtsx_dev *dev = host_to_rtsx(host);
struct rtsx_chip *chip = dev->chip;

- dev_info(&dev->pci->dev, "%s called\n", __func__);
-
scsi_lock(host);

/* Is this command still active? */
@@ -188,8 +186,6 @@ static int device_reset(struct scsi_cmnd *srb)
{
struct rtsx_dev *dev = host_to_rtsx(srb->device->host);

- dev_info(&dev->pci->dev, "%s called\n", __func__);
-
return SUCCESS;
}

@@ -968,8 +964,6 @@ static void rtsx_remove(struct pci_dev *pci)
{
struct rtsx_dev *dev = pci_get_drvdata(pci);

- dev_info(&pci->dev, "%s called\n", __func__);
-
quiesce_and_remove_host(dev);
release_everything(dev);
pci_release_regions(pci);
--
2.35.1

2022-03-17 03:20:24

by Charlie Sands

Subject: Re: [PATCH] staging: rts5208: Resolve checkpath.pl issues.

> Always test-build your patches. Applying this change results in a build
> failure :(
My apologies, I ran a build test on a copy of the repository with my changes
stashed in order to look at the original checkpatch warnings.

> Please fix up and resend.
It should now fix the below issues without build warnings.

WARNING: Unnecessary ftrace-like logging - prefer using ftrace
+ dev_info(&dev->pci->dev, "%s called\n", __func__);

WARNING: Unnecessary ftrace-like logging - prefer using ftrace
+ dev_info(&dev->pci->dev, "%s called\n", __func__);

WARNING: Unnecessary ftrace-like logging - prefer using ftrace
+ dev_info(&pci->dev, "%s called\n", __func__);

Signed-off-by: Charlie Sands <[email protected]>
---
drivers/staging/rts5208/rtsx.c | 8 --------
1 file changed, 8 deletions(-)

diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/rts5208/rtsx.c
index 5a58dac76c88..2284a96abcff 100644
--- a/drivers/staging/rts5208/rtsx.c
+++ b/drivers/staging/rts5208/rtsx.c
@@ -159,8 +159,6 @@ static int command_abort(struct scsi_cmnd *srb)
struct rtsx_dev *dev = host_to_rtsx(host);
struct rtsx_chip *chip = dev->chip;

- dev_info(&dev->pci->dev, "%s called\n", __func__);
-
scsi_lock(host);

/* Is this command still active? */
@@ -186,10 +184,6 @@ static int command_abort(struct scsi_cmnd *srb)
*/
static int device_reset(struct scsi_cmnd *srb)
{
- struct rtsx_dev *dev = host_to_rtsx(srb->device->host);
-
- dev_info(&dev->pci->dev, "%s called\n", __func__);
-
return SUCCESS;
}

@@ -968,8 +962,6 @@ static void rtsx_remove(struct pci_dev *pci)
{
struct rtsx_dev *dev = pci_get_drvdata(pci);

- dev_info(&pci->dev, "%s called\n", __func__);
-
quiesce_and_remove_host(dev);
release_everything(dev);
pci_release_regions(pci);
--
2.35.1

2022-03-17 06:11:47

by Greg Kroah-Hartman

Subject: Re: [PATCH] staging: rts5208: Resolve checkpath.pl issues.

On Tue, Mar 15, 2022 at 05:15:07PM -0400, Charlie Sands wrote:
> > Always test-build your patches. Applying this change results in a build
> > failure :(
> My apologies, I ran a build test on a copy of the repository with my changes
> stashed in order to look at the original checkpatch warnings.
>
> > Please fix up and resend.
> It should now fix the below issues without build warnings.

None of this should be in the changelog, please fix this up and send a
version 2 of this patch, properly listing what changed from the previous
version. Instructions on how to do that should be in the documentation.

thanks,

greg k-h