2022-04-11 09:08:35

by Randy Dunlap

Subject: [PATCH v2] sparc: cacheflush_32.h needs struct page

Add a struct page forward declaration to cacheflush_32.h.
Fixes this build warning:

CC drivers/crypto/xilinx/zynqmp-sha.o
In file included from ../arch/sparc/include/asm/cacheflush.h:11,
from ../include/linux/cacheflush.h:5,
from ../drivers/crypto/xilinx/zynqmp-sha.c:6:
../arch/sparc/include/asm/cacheflush_32.h:38:37: warning: 'struct page' declared inside parameter list will not be visible outside of this definition or declaration
38 | void sparc_flush_page_to_ram(struct page *page);

Exposed by commit 0e03b8fd2936
("crypto: xilinx - Turn SHA into a tristate and allow COMPILE_TEST")
but not Fixes: that commit.

Signed-off-by: Randy Dunlap <[email protected]>
Reported-by: kernel test robot <[email protected]>
Cc: Herbert Xu <[email protected]>
Cc: David S. Miller <[email protected]>
Cc: Sam Ravnborg <[email protected]>
Cc: [email protected]
---
v2: use forward declaration instead of adding <linux/mm.h> (Sam)

arch/sparc/include/asm/cacheflush_32.h | 1 +
1 file changed, 1 insertion(+)

--- a/arch/sparc/include/asm/cacheflush_32.h
+++ b/arch/sparc/include/asm/cacheflush_32.h
@@ -35,6 +35,7 @@
#define flush_page_for_dma(addr) \
sparc32_cachetlb_ops->page_for_dma(addr)

+struct page;
void sparc_flush_page_to_ram(struct page *page);

#define ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE 1

2022-04-11 17:12:36

by Herbert Xu

Subject: Re: [PATCH v2] sparc: cacheflush_32.h needs struct page

On Sat, Apr 09, 2022 at 08:16:09AM -0700, Randy Dunlap wrote:
> Add a struct page forward declaration to cacheflush_32.h.
> Fixes this build warning:
>
> CC drivers/crypto/xilinx/zynqmp-sha.o
> In file included from ../arch/sparc/include/asm/cacheflush.h:11,
> from ../include/linux/cacheflush.h:5,
> from ../drivers/crypto/xilinx/zynqmp-sha.c:6:
> ../arch/sparc/include/asm/cacheflush_32.h:38:37: warning: 'struct page' declared inside parameter list will not be visible outside of this definition or declaration
> 38 | void sparc_flush_page_to_ram(struct page *page);
>
> Exposed by commit 0e03b8fd2936
> ("crypto: xilinx - Turn SHA into a tristate and allow COMPILE_TEST")
> but not Fixes: that commit.
>
> Signed-off-by: Randy Dunlap <[email protected]>
> Reported-by: kernel test robot <[email protected]>
> Cc: Herbert Xu <[email protected]>
> Cc: David S. Miller <[email protected]>
> Cc: Sam Ravnborg <[email protected]>
> Cc: [email protected]
> ---
> v2: use forward declaration instead of adding <linux/mm.h> (Sam)
>
> arch/sparc/include/asm/cacheflush_32.h | 1 +
> 1 file changed, 1 insertion(+)

Acked-by: Herbert Xu <[email protected]>

Thanks,
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

2022-04-12 10:03:52

by Sam Ravnborg

Subject: Re: [PATCH v2] sparc: cacheflush_32.h needs struct page

On Sat, Apr 09, 2022 at 08:16:09AM -0700, Randy Dunlap wrote:
> Add a struct page forward declaration to cacheflush_32.h.
> Fixes this build warning:
>
> CC drivers/crypto/xilinx/zynqmp-sha.o
> In file included from ../arch/sparc/include/asm/cacheflush.h:11,
> from ../include/linux/cacheflush.h:5,
> from ../drivers/crypto/xilinx/zynqmp-sha.c:6:
> ../arch/sparc/include/asm/cacheflush_32.h:38:37: warning: 'struct page' declared inside parameter list will not be visible outside of this definition or declaration
> 38 | void sparc_flush_page_to_ram(struct page *page);
>
> Exposed by commit 0e03b8fd2936
> ("crypto: xilinx - Turn SHA into a tristate and allow COMPILE_TEST")
> but not Fixes: that commit.
>
> Signed-off-by: Randy Dunlap <[email protected]>
> Reported-by: kernel test robot <[email protected]>
> Cc: Herbert Xu <[email protected]>
> Cc: David S. Miller <[email protected]>
> Cc: Sam Ravnborg <[email protected]>
> Cc: [email protected]
Acked-by: Sam Ravnborg <[email protected]>

> ---
> v2: use forward declaration instead of adding <linux/mm.h> (Sam)
>
> arch/sparc/include/asm/cacheflush_32.h | 1 +
> 1 file changed, 1 insertion(+)
>
> --- a/arch/sparc/include/asm/cacheflush_32.h
> +++ b/arch/sparc/include/asm/cacheflush_32.h
> @@ -35,6 +35,7 @@
> #define flush_page_for_dma(addr) \
> sparc32_cachetlb_ops->page_for_dma(addr)
>
> +struct page;
> void sparc_flush_page_to_ram(struct page *page);
>
> #define ARCH_IMPLEMENTS_FLUSH_DCACHE_PAGE 1