2022-04-22 17:15:53

by Christopher Obbard

[permalink] [raw]
Subject: [PATCH 1/3] media: dt-bindings: media: rockchip-vdec: Add RK3328 compatible

Document the RK3328 compatible for rockchip-vdec.

Signed-off-by: Christopher Obbard <[email protected]>
---
Documentation/devicetree/bindings/media/rockchip,vdec.yaml | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/media/rockchip,vdec.yaml b/Documentation/devicetree/bindings/media/rockchip,vdec.yaml
index 089f11d21b25..23f9687d862c 100644
--- a/Documentation/devicetree/bindings/media/rockchip,vdec.yaml
+++ b/Documentation/devicetree/bindings/media/rockchip,vdec.yaml
@@ -19,6 +19,7 @@ properties:
- const: rockchip,rk3399-vdec
- items:
- const: rockchip,rk3228-vdec
+ - const: rockchip,rk3328-vdec
- const: rockchip,rk3399-vdec

reg:
--
2.34.1


2022-04-22 21:50:22

by Ezequiel Garcia

[permalink] [raw]
Subject: Re: [PATCH 1/3] media: dt-bindings: media: rockchip-vdec: Add RK3328 compatible

On Fri, Apr 22, 2022 at 02:38:01PM +0100, Christopher Obbard wrote:
> Document the RK3328 compatible for rockchip-vdec.
>
> Signed-off-by: Christopher Obbard <[email protected]>

Reviewed-by: Ezequiel Garcia <[email protected]>

> ---
> Documentation/devicetree/bindings/media/rockchip,vdec.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/media/rockchip,vdec.yaml b/Documentation/devicetree/bindings/media/rockchip,vdec.yaml
> index 089f11d21b25..23f9687d862c 100644
> --- a/Documentation/devicetree/bindings/media/rockchip,vdec.yaml
> +++ b/Documentation/devicetree/bindings/media/rockchip,vdec.yaml
> @@ -19,6 +19,7 @@ properties:
> - const: rockchip,rk3399-vdec
> - items:
> - const: rockchip,rk3228-vdec
> + - const: rockchip,rk3328-vdec
> - const: rockchip,rk3399-vdec
>
> reg:
> --
> 2.34.1
>

2022-04-23 17:39:42

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH 1/3] media: dt-bindings: media: rockchip-vdec: Add RK3328 compatible

On 22/04/2022 15:38, Christopher Obbard wrote:
> Document the RK3328 compatible for rockchip-vdec.
>
> Signed-off-by: Christopher Obbard <[email protected]>
> ---
> Documentation/devicetree/bindings/media/rockchip,vdec.yaml | 1 +
> 1 file changed, 1 insertion(+)


Acked-by: Krzysztof Kozlowski <[email protected]>


Best regards,
Krzysztof

2022-04-24 14:21:13

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH 1/3] media: dt-bindings: media: rockchip-vdec: Add RK3328 compatible

On 23/04/2022 13:10, Krzysztof Kozlowski wrote:
> On 22/04/2022 15:38, Christopher Obbard wrote:
>> Document the RK3328 compatible for rockchip-vdec.
>>
>> Signed-off-by: Christopher Obbard <[email protected]>
>> ---
>> Documentation/devicetree/bindings/media/rockchip,vdec.yaml | 1 +
>> 1 file changed, 1 insertion(+)
>
>
> Acked-by: Krzysztof Kozlowski <[email protected]>

I acked this but Johan pointed out that your intention was different and
missing patch context is quite important here. Please explain what
exactly you wanted in the patch? Now it looks actually wrong, so my ack
is not correct.

Best regards,
Krzysztof

2022-04-25 15:50:33

by Christopher Obbard

[permalink] [raw]
Subject: Re: [PATCH 1/3] media: dt-bindings: media: rockchip-vdec: Add RK3328 compatible


On 23/04/2022 18:31, Krzysztof Kozlowski wrote:
> On 23/04/2022 13:10, Krzysztof Kozlowski wrote:
>> On 22/04/2022 15:38, Christopher Obbard wrote:
>>> Document the RK3328 compatible for rockchip-vdec.
>>>
>>> Signed-off-by: Christopher Obbard <[email protected]>
>>> ---
>>> Documentation/devicetree/bindings/media/rockchip,vdec.yaml | 1 +
>>> 1 file changed, 1 insertion(+)
>>
>>
>> Acked-by: Krzysztof Kozlowski <[email protected]>
>
> I acked this but Johan pointed out that your intention was different and
> missing patch context is quite important here. Please explain what
> exactly you wanted in the patch? Now it looks actually wrong, so my ack
> is not correct.

Wow - I think i was in weekend mode and forgot to run dtbs_check ;-).
It will be solved in v2. I have now added the check to my "pre
send-patch" review checklist.

Just out of interest, I didn't get a mail from Johan and I can't seem to
find it the archive either. Is that message in public as I'd like to
address any other concerns at the same time ?

Cheers!
Chris

2022-04-26 07:00:59

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH 1/3] media: dt-bindings: media: rockchip-vdec: Add RK3328 compatible

On 25/04/2022 11:53, Christopher Obbard wrote:
>>> Acked-by: Krzysztof Kozlowski <[email protected]>
>>
>> I acked this but Johan pointed out that your intention was different and
>> missing patch context is quite important here. Please explain what
>> exactly you wanted in the patch? Now it looks actually wrong, so my ack
>> is not correct.
>
> Wow - I think i was in weekend mode and forgot to run dtbs_check ;-).
> It will be solved in v2. I have now added the check to my "pre
> send-patch" review checklist.
>
> Just out of interest, I didn't get a mail from Johan and I can't seem to
> find it the archive either. Is that message in public as I'd like to
> address any other concerns at the same time ?

No, it wasn't public. :(

Best regards,
Krzysztof