This patch series is changed from previous version as there's an
alternate contribution to convert BAM to DT schema. This patchset now
defines generic dma node name for Qualcomm armv7 based platforms.
Looking forward towards review comments. Thanks!
---
v4:
- Drop 3/6 and 6/6 patch from v3 series
- s/User/Use in commit description of all patches
- Didn't drop Krzysztof's R-b tag as I fixed a simple typo
- Alternate contribution for BAM:
https://lore.kernel.org/lkml/[email protected]/T/#m6700c2695ee78e79060ac338d208ffd08ac39%20+592
- Keep only armv7 based dts patches now
---
v3:
- https://lore.kernel.org/linux-devicetree/[email protected]/
- Add Krzysztof's R-b tags for dts changes
- Add qcom,ee as required property(Krzysztof)
- Use type as boolean
- Add min/max to qcom,ee
- Clocks are required ones, skip them as it's users are not fixed.
---
v2:
- https://lore.kernel.org/linux-devicetree/[email protected]/
- Add more variants of ip4019-ap/dk-{01/04/07} for dma node rename
- Add #dma-cells in binding file
- use additionalproperties as false
---
v1:
- https://lore.kernel.org/linux-devicetree/[email protected]/#t
---
Kuldeep Singh (4):
ARM: dts: qcom: apq8064: Use generic node name for DMA
ARM: dts: qcom: mdm9615: Use generic node name for DMA
ARM: dts: qcom: ipq4019: Use generic node name for DMA
ARM: dts: qcom: ipq8064: Use generic node name for DMA
arch/arm/boot/dts/qcom-apq8064.dtsi | 6 +++---
arch/arm/boot/dts/qcom-ipq4019-ap.dk01.1.dtsi | 4 ++--
arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1-c1.dts | 2 +-
arch/arm/boot/dts/qcom-ipq4019-ap.dk04.1.dtsi | 2 +-
arch/arm/boot/dts/qcom-ipq4019-ap.dk07.1.dtsi | 4 ++--
arch/arm/boot/dts/qcom-ipq4019.dtsi | 6 +++---
arch/arm/boot/dts/qcom-ipq8064.dtsi | 4 ++--
arch/arm/boot/dts/qcom-mdm9615.dtsi | 4 ++--
8 files changed, 16 insertions(+), 16 deletions(-)
--
2.25.1
Qcom BAM DT spec expects generic DMA controller node name as
"dma-controller" to enable validations.
Signed-off-by: Kuldeep Singh <[email protected]>
Reviewed-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm/boot/dts/qcom-mdm9615.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/qcom-mdm9615.dtsi b/arch/arm/boot/dts/qcom-mdm9615.dtsi
index 4d4f37cebf21..8f0752ce1c7b 100644
--- a/arch/arm/boot/dts/qcom-mdm9615.dtsi
+++ b/arch/arm/boot/dts/qcom-mdm9615.dtsi
@@ -330,7 +330,7 @@ pmicgpio: gpio@150 {
};
};
- sdcc1bam: dma@12182000{
+ sdcc1bam: dma-controller@12182000{
compatible = "qcom,bam-v1.3.0";
reg = <0x12182000 0x8000>;
interrupts = <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>;
@@ -340,7 +340,7 @@ sdcc1bam: dma@12182000{
qcom,ee = <0>;
};
- sdcc2bam: dma@12142000{
+ sdcc2bam: dma-controller@12142000{
compatible = "qcom,bam-v1.3.0";
reg = <0x12142000 0x8000>;
interrupts = <GIC_SPI 97 IRQ_TYPE_LEVEL_HIGH>;
--
2.25.1
Qcom BAM DT spec expects generic DMA controller node name as
"dma-controller" to enable validations.
Signed-off-by: Kuldeep Singh <[email protected]>
Reviewed-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm/boot/dts/qcom-ipq8064.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/qcom-ipq8064.dtsi b/arch/arm/boot/dts/qcom-ipq8064.dtsi
index 8cb04aa8ed2f..7e68d4b1527f 100644
--- a/arch/arm/boot/dts/qcom-ipq8064.dtsi
+++ b/arch/arm/boot/dts/qcom-ipq8064.dtsi
@@ -1155,7 +1155,7 @@ vsdcc_fixed: vsdcc-regulator {
regulator-always-on;
};
- sdcc1bam: dma@12402000 {
+ sdcc1bam: dma-controller@12402000 {
compatible = "qcom,bam-v1.3.0";
reg = <0x12402000 0x8000>;
interrupts = <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>;
@@ -1165,7 +1165,7 @@ sdcc1bam: dma@12402000 {
qcom,ee = <0>;
};
- sdcc3bam: dma@12182000 {
+ sdcc3bam: dma-controller@12182000 {
compatible = "qcom,bam-v1.3.0";
reg = <0x12182000 0x8000>;
interrupts = <GIC_SPI 96 IRQ_TYPE_LEVEL_HIGH>;
--
2.25.1
Qcom BAM DT spec expects generic DMA controller node name as
"dma-controller" to enable validations.
Signed-off-by: Kuldeep Singh <[email protected]>
Reviewed-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm/boot/dts/qcom-apq8064.dtsi | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/qcom-apq8064.dtsi b/arch/arm/boot/dts/qcom-apq8064.dtsi
index a1c8ae516d21..b2975be3ae04 100644
--- a/arch/arm/boot/dts/qcom-apq8064.dtsi
+++ b/arch/arm/boot/dts/qcom-apq8064.dtsi
@@ -1040,7 +1040,7 @@ sata0: sata@29000000 {
};
/* Temporary fixed regulator */
- sdcc1bam:dma@12402000{
+ sdcc1bam: dma-controller@12402000{
compatible = "qcom,bam-v1.3.0";
reg = <0x12402000 0x8000>;
interrupts = <0 98 IRQ_TYPE_LEVEL_HIGH>;
@@ -1050,7 +1050,7 @@ sdcc1bam:dma@12402000{
qcom,ee = <0>;
};
- sdcc3bam:dma@12182000{
+ sdcc3bam: dma-controller@12182000{
compatible = "qcom,bam-v1.3.0";
reg = <0x12182000 0x8000>;
interrupts = <0 96 IRQ_TYPE_LEVEL_HIGH>;
@@ -1060,7 +1060,7 @@ sdcc3bam:dma@12182000{
qcom,ee = <0>;
};
- sdcc4bam:dma@121c2000{
+ sdcc4bam: dma-controller@121c2000{
compatible = "qcom,bam-v1.3.0";
reg = <0x121c2000 0x8000>;
interrupts = <0 95 IRQ_TYPE_LEVEL_HIGH>;
--
2.25.1
On Thu 21 Apr 10:18 PDT 2022, Kuldeep Singh wrote:
> Qcom BAM DT spec expects generic DMA controller node name as
> "dma-controller" to enable validations.
>
> Signed-off-by: Kuldeep Singh <[email protected]>
> Reviewed-by: Krzysztof Kozlowski <[email protected]>
It seems that I picked up v3, but patchwork-bot didn't send out any
notifications.
Please double check linux-next to confirm that we got them all sorted
out.
Thanks,
Bjorn
> ---
> arch/arm/boot/dts/qcom-apq8064.dtsi | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/qcom-apq8064.dtsi b/arch/arm/boot/dts/qcom-apq8064.dtsi
> index a1c8ae516d21..b2975be3ae04 100644
> --- a/arch/arm/boot/dts/qcom-apq8064.dtsi
> +++ b/arch/arm/boot/dts/qcom-apq8064.dtsi
> @@ -1040,7 +1040,7 @@ sata0: sata@29000000 {
> };
>
> /* Temporary fixed regulator */
> - sdcc1bam:dma@12402000{
> + sdcc1bam: dma-controller@12402000{
> compatible = "qcom,bam-v1.3.0";
> reg = <0x12402000 0x8000>;
> interrupts = <0 98 IRQ_TYPE_LEVEL_HIGH>;
> @@ -1050,7 +1050,7 @@ sdcc1bam:dma@12402000{
> qcom,ee = <0>;
> };
>
> - sdcc3bam:dma@12182000{
> + sdcc3bam: dma-controller@12182000{
> compatible = "qcom,bam-v1.3.0";
> reg = <0x12182000 0x8000>;
> interrupts = <0 96 IRQ_TYPE_LEVEL_HIGH>;
> @@ -1060,7 +1060,7 @@ sdcc3bam:dma@12182000{
> qcom,ee = <0>;
> };
>
> - sdcc4bam:dma@121c2000{
> + sdcc4bam: dma-controller@121c2000{
> compatible = "qcom,bam-v1.3.0";
> reg = <0x121c2000 0x8000>;
> interrupts = <0 95 IRQ_TYPE_LEVEL_HIGH>;
> --
> 2.25.1
>
On Sat, Apr 23, 2022 at 09:03:39AM -0700, Bjorn Andersson wrote:
> On Thu 21 Apr 10:18 PDT 2022, Kuldeep Singh wrote:
>
> > Qcom BAM DT spec expects generic DMA controller node name as
> > "dma-controller" to enable validations.
> >
> > Signed-off-by: Kuldeep Singh <[email protected]>
> > Reviewed-by: Krzysztof Kozlowski <[email protected]>
>
> It seems that I picked up v3, but patchwork-bot didn't send out any
> notifications.
Yes, somehow there was no notification for this series as well as geni
uart/i2c patches also.
>
> Please double check linux-next to confirm that we got them all sorted
> out.
I checked dma dts patches[1] and they are in next/linux-next.
I hope I checked the right tree, please correct me if it's wrong.
Please note, there was one small typo fix from v3->v4 in commit
header(s/User/Use). Not sure if it's worth updating as it's already in
next tree, upto you. Thanks!
-Kuldeep
[1]
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=fb1bdb7e787a6037f501869b5aaf9e5cabe7a7bc
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=fbf64afd16b9581ae5a89c6924b50f83041463e0
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=095a7137ba3630bcca11e6017bfd4ab48b7fc12e
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=a86efc02b34104b93a0f9707d1e61577671fc4ad
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=7224013d4b5a64c43be23204bcfb4070dbd7fd76
On Sat 23 Apr 11:09 PDT 2022, Kuldeep Singh wrote:
> On Sat, Apr 23, 2022 at 09:03:39AM -0700, Bjorn Andersson wrote:
> > On Thu 21 Apr 10:18 PDT 2022, Kuldeep Singh wrote:
> >
> > > Qcom BAM DT spec expects generic DMA controller node name as
> > > "dma-controller" to enable validations.
> > >
> > > Signed-off-by: Kuldeep Singh <[email protected]>
> > > Reviewed-by: Krzysztof Kozlowski <[email protected]>
> >
> > It seems that I picked up v3, but patchwork-bot didn't send out any
> > notifications.
>
> Yes, somehow there was no notification for this series as well as geni
> uart/i2c patches also.
>
> >
> > Please double check linux-next to confirm that we got them all sorted
> > out.
>
> I checked dma dts patches[1] and they are in next/linux-next.
> I hope I checked the right tree, please correct me if it's wrong.
>
> Please note, there was one small typo fix from v3->v4 in commit
> header(s/User/Use). Not sure if it's worth updating as it's already in
> next tree, upto you. Thanks!
>
I generally never rebase my trees, as that's causing issues for anyone
references commits in my tree. So we'll have to live with this typo.
Thanks,
Bjorn
> I generally never rebase my trees, as that's causing issues for anyone
> references commits in my tree. So we'll have to live with this typo.
Sure Bjorn, this was completely unintentional and next time, will try to
fix it before it's accepted. Thanks!