2022-06-23 06:52:56

by Muchun Song

Subject: Re: [PATCH 01/16] mm/huge_memory: use flush_pmd_tlb_range in move_huge_pmd

On Thu, Jun 23, 2022 at 01:06:12AM +0800, Miaohe Lin wrote:
> ARCHes with special requirements for evicting THP backing TLB entries can
> implement flush_pmd_tlb_range. Otherwise also, it can help optimize TLB
> flush in THP regime. Using flush_pmd_tlb_range to take advantage of this
> in move_huge_pmd.
>
> Signed-off-by: Miaohe Lin <[email protected]>

LGTM.

Reviewed-by: Muchun Song <[email protected]>

2022-06-24 18:35:20

by Zach O'Keefe

Subject: Re: [PATCH 01/16] mm/huge_memory: use flush_pmd_tlb_range in move_huge_pmd

On 23 Jun 14:30, Muchun Song wrote:
> On Thu, Jun 23, 2022 at 01:06:12AM +0800, Miaohe Lin wrote:
> > ARCHes with special requirements for evicting THP backing TLB entries can
> > implement flush_pmd_tlb_range. Otherwise also, it can help optimize TLB
> > flush in THP regime. Using flush_pmd_tlb_range to take advantage of this
> > in move_huge_pmd.
> >
> > Signed-off-by: Miaohe Lin <[email protected]>
>
> LGTM.
>
> Reviewed-by: Muchun Song <[email protected]>

Reviewed-by: Zach O'Keefe <[email protected]>