we've been stuck with problems in the dual-amplifier configurations where
one of the two devices seems to become UNATTACHED and never regains sync,
see https://github.com/thesofproject/linux/issues/3638.
This is a rather infrequent issue that may happen once or twice per month,
but still it remains a concern.
One possibility is that the device does lose sync but somehow our hardware
detection fails to see it resync.
This series just adds a basic read directly from the PING frames to help
confirm if yes/no the device regain sync.
The change is mainly on soundwire. @Mark, Could you ack the ASoC patch
if it looks good to you?
Pierre-Louis Bossart (4):
soundwire: add read_ping_status helper definition in manager ops
soundwire: intel/cadence: expose PING status in manager ops
soundwire: add sdw_show_ping_status() helper
ASoC: codecs: show PING status on resume failures
drivers/soundwire/bus.c | 32 ++++++++++++++++++++++++++++++
drivers/soundwire/cadence_master.c | 8 ++++++++
drivers/soundwire/cadence_master.h | 2 ++
drivers/soundwire/intel.c | 1 +
include/linux/soundwire/sdw.h | 5 +++++
sound/soc/codecs/max98373-sdw.c | 2 ++
sound/soc/codecs/rt1308-sdw.c | 2 ++
sound/soc/codecs/rt1316-sdw.c | 2 ++
sound/soc/codecs/rt5682-sdw.c | 2 ++
sound/soc/codecs/rt700-sdw.c | 2 ++
sound/soc/codecs/rt711-sdca-sdw.c | 2 ++
sound/soc/codecs/rt715-sdca-sdw.c | 2 ++
sound/soc/codecs/rt715-sdw.c | 2 ++
13 files changed, 64 insertions(+)
--
2.25.1
On 14-07-22, 09:10, Bard Liao wrote:
> we've been stuck with problems in the dual-amplifier configurations where
> one of the two devices seems to become UNATTACHED and never regains sync,
> see https://github.com/thesofproject/linux/issues/3638.
>
> This is a rather infrequent issue that may happen once or twice per month,
> but still it remains a concern.
>
> One possibility is that the device does lose sync but somehow our hardware
> detection fails to see it resync.
>
> This series just adds a basic read directly from the PING frames to help
> confirm if yes/no the device regain sync.
>
> The change is mainly on soundwire. @Mark, Could you ack the ASoC patch
> if it looks good to you?
Mark,
The series lgtm, feel free to merge thru ASoC tree with:
Acked-By: Vinod Koul <[email protected]>
>
> Pierre-Louis Bossart (4):
> soundwire: add read_ping_status helper definition in manager ops
> soundwire: intel/cadence: expose PING status in manager ops
> soundwire: add sdw_show_ping_status() helper
> ASoC: codecs: show PING status on resume failures
>
> drivers/soundwire/bus.c | 32 ++++++++++++++++++++++++++++++
> drivers/soundwire/cadence_master.c | 8 ++++++++
> drivers/soundwire/cadence_master.h | 2 ++
> drivers/soundwire/intel.c | 1 +
> include/linux/soundwire/sdw.h | 5 +++++
> sound/soc/codecs/max98373-sdw.c | 2 ++
> sound/soc/codecs/rt1308-sdw.c | 2 ++
> sound/soc/codecs/rt1316-sdw.c | 2 ++
> sound/soc/codecs/rt5682-sdw.c | 2 ++
> sound/soc/codecs/rt700-sdw.c | 2 ++
> sound/soc/codecs/rt711-sdca-sdw.c | 2 ++
> sound/soc/codecs/rt715-sdca-sdw.c | 2 ++
> sound/soc/codecs/rt715-sdw.c | 2 ++
> 13 files changed, 64 insertions(+)
>
> --
> 2.25.1
--
~Vinod
> -----Original Message-----
> From: Vinod Koul <[email protected]>
> Sent: Monday, July 18, 2022 1:45 PM
> To: Bard Liao <[email protected]>
> Cc: [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> Liao, Bard <[email protected]>
> Subject: Re: [PATCH 0/4] ASoC/soundwire: log actual PING status on resume
> issues
>
> On 14-07-22, 09:10, Bard Liao wrote:
> > we've been stuck with problems in the dual-amplifier configurations where
> > one of the two devices seems to become UNATTACHED and never regains
> sync,
> > see https://github.com/thesofproject/linux/issues/3638.
> >
> > This is a rather infrequent issue that may happen once or twice per month,
> > but still it remains a concern.
> >
> > One possibility is that the device does lose sync but somehow our
> hardware
> > detection fails to see it resync.
> >
> > This series just adds a basic read directly from the PING frames to help
> > confirm if yes/no the device regain sync.
> >
> > The change is mainly on soundwire. @Mark, Could you ack the ASoC patch
> > if it looks good to you?
>
> Mark,
>
> The series lgtm, feel free to merge thru ASoC tree with:
>
> Acked-By: Vinod Koul <[email protected]>
Hi Mark/Vinod,
Both of you are acked.
Can this series be merged now?
Thanks.
>
> >
> > Pierre-Louis Bossart (4):
> > soundwire: add read_ping_status helper definition in manager ops
> > soundwire: intel/cadence: expose PING status in manager ops
> > soundwire: add sdw_show_ping_status() helper
> > ASoC: codecs: show PING status on resume failures
> >
> > drivers/soundwire/bus.c | 32 ++++++++++++++++++++++++++++++
> > drivers/soundwire/cadence_master.c | 8 ++++++++
> > drivers/soundwire/cadence_master.h | 2 ++
> > drivers/soundwire/intel.c | 1 +
> > include/linux/soundwire/sdw.h | 5 +++++
> > sound/soc/codecs/max98373-sdw.c | 2 ++
> > sound/soc/codecs/rt1308-sdw.c | 2 ++
> > sound/soc/codecs/rt1316-sdw.c | 2 ++
> > sound/soc/codecs/rt5682-sdw.c | 2 ++
> > sound/soc/codecs/rt700-sdw.c | 2 ++
> > sound/soc/codecs/rt711-sdca-sdw.c | 2 ++
> > sound/soc/codecs/rt715-sdca-sdw.c | 2 ++
> > sound/soc/codecs/rt715-sdw.c | 2 ++
> > 13 files changed, 64 insertions(+)
> >
> > --
> > 2.25.1
>
> --
> ~Vinod
On Wed, Aug 17, 2022 at 06:48:56AM +0000, Liao, Bard wrote:
> > > This series just adds a basic read directly from the PING frames to help
> > > confirm if yes/no the device regain sync.
> > > The change is mainly on soundwire. @Mark, Could you ack the ASoC patch
> > > if it looks good to you?
> > The series lgtm, feel free to merge thru ASoC tree with:
> > Acked-By: Vinod Koul <[email protected]>
> Both of you are acked.
> Can this series be merged now?
I guess I'll apply it - given that it's mainly a Soundwire change I
would have expected it to go via Soundwire as you'd suggested.
On Thu, 14 Jul 2022 09:10:39 +0800, Bard Liao wrote:
> we've been stuck with problems in the dual-amplifier configurations where
> one of the two devices seems to become UNATTACHED and never regains sync,
> see https://github.com/thesofproject/linux/issues/3638.
>
> This is a rather infrequent issue that may happen once or twice per month,
> but still it remains a concern.
>
> [...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/4] soundwire: add read_ping_status helper definition in manager ops
commit: 874de459488b8741afc0e9888d39f2e15a962b3d
[2/4] soundwire: intel/cadence: expose PING status in manager ops
commit: 133547a1ef16cbdadb5c0023e5917924ae326dcc
[3/4] soundwire: add sdw_show_ping_status() helper
commit: 79fe02cb7547fcc09e83b850cfd32896d7dc6289
[4/4] ASoC: codecs: show PING status on resume failures
commit: 917df025e1db1286afb6e46914ae3e8b40241568
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark