2022-07-16 13:39:16

by Jason Wang

Subject: [PATCH] drm/i915/gt: Remove unneeded semicolon

The semicolon after the `}' in line 648 is unneeded.

Signed-off-by: Jason Wang <[email protected]>
---
drivers/gpu/drm/i915/gt/intel_migrate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/gt/intel_migrate.c b/drivers/gpu/drm/i915/gt/intel_migrate.c
index 2c35324b5f68..a69b244f14d0 100644
--- a/drivers/gpu/drm/i915/gt/intel_migrate.c
+++ b/drivers/gpu/drm/i915/gt/intel_migrate.c
@@ -645,7 +645,7 @@ static int scatter_list_length(struct scatterlist *sg)
while (sg && sg_dma_len(sg)) {
len += sg_dma_len(sg);
sg = sg_next(sg);
- };
+ }

return len;
}
--
2.35.1

2022-07-18 18:54:10

by Rodrigo Vivi

Subject: Re: [PATCH] drm/i915/gt: Remove unneeded semicolon

On Sun, Jul 17, 2022 at 02:44:39AM +0800, Jason Wang wrote:
> The semicolon after the `}' in line 648 is unneeded.

same here

The line number changes... if you remove the "in line #"
the msg gets better.
With that changed:

Reviewed-by: Rodrigo Vivi <[email protected]>

>
> Signed-off-by: Jason Wang <[email protected]>
> ---
> drivers/gpu/drm/i915/gt/intel_migrate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_migrate.c b/drivers/gpu/drm/i915/gt/intel_migrate.c
> index 2c35324b5f68..a69b244f14d0 100644
> --- a/drivers/gpu/drm/i915/gt/intel_migrate.c
> +++ b/drivers/gpu/drm/i915/gt/intel_migrate.c
> @@ -645,7 +645,7 @@ static int scatter_list_length(struct scatterlist *sg)
> while (sg && sg_dma_len(sg)) {
> len += sg_dma_len(sg);
> sg = sg_next(sg);
> - };
> + }
>
> return len;
> }
> --
> 2.35.1
>

2022-07-21 08:17:41

by Rodrigo Vivi

Subject: Re: [PATCH] drm/i915/gt: Remove unneeded semicolon

On Sun, Jul 17, 2022 at 02:44:39AM +0800, Jason Wang wrote:
> The semicolon after the `}' in line 648 is unneeded.

I removed the line mention while pushing to drm-intel-gt-next.
Thanks for the patch.

>
> Signed-off-by: Jason Wang <[email protected]>
> ---
> drivers/gpu/drm/i915/gt/intel_migrate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_migrate.c b/drivers/gpu/drm/i915/gt/intel_migrate.c
> index 2c35324b5f68..a69b244f14d0 100644
> --- a/drivers/gpu/drm/i915/gt/intel_migrate.c
> +++ b/drivers/gpu/drm/i915/gt/intel_migrate.c
> @@ -645,7 +645,7 @@ static int scatter_list_length(struct scatterlist *sg)
> while (sg && sg_dma_len(sg)) {
> len += sg_dma_len(sg);
> sg = sg_next(sg);
> - };
> + }
>
> return len;
> }
> --
> 2.35.1
>