2022-07-15 21:40:19

by Andy Shevchenko

Subject: [PATCH v1 1/1] ALSA: isa: Use INVALID_HWIRQ definition

Use specific definition for invalid IRQ. It makes the
code uniform in respect to the constant used for that.
No functional change intended.

Signed-off-by: Andy Shevchenko <[email protected]>
---
sound/isa/sscape.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/sound/isa/sscape.c b/sound/isa/sscape.c
index 0bc0025f7c19..9adaf91045e9 100644
--- a/sound/isa/sscape.c
+++ b/sound/isa/sscape.c
@@ -140,8 +140,7 @@ struct soundscape {
unsigned char midi_vol;
};

-#define INVALID_IRQ ((unsigned)-1)
-
+#define INVALID_IRQ ((unsigned)INVALID_HWIRQ)

static inline struct soundscape *get_card_soundscape(struct snd_card *c)
{
--
2.35.1

2022-07-16 07:14:16

by Takashi Iwai

Subject: Re: [PATCH v1 1/1] ALSA: isa: Use INVALID_HWIRQ definition

On Fri, 15 Jul 2022 22:57:37 +0200,
Andy Shevchenko wrote:
>
> Use specific definition for invalid IRQ. It makes the
> code uniform in respect to the constant used for that.
> No functional change intended.
>
> Signed-off-by: Andy Shevchenko <[email protected]>
> ---
> sound/isa/sscape.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/sound/isa/sscape.c b/sound/isa/sscape.c
> index 0bc0025f7c19..9adaf91045e9 100644
> --- a/sound/isa/sscape.c
> +++ b/sound/isa/sscape.c
> @@ -140,8 +140,7 @@ struct soundscape {
> unsigned char midi_vol;
> };
>
> -#define INVALID_IRQ ((unsigned)-1)
> -
> +#define INVALID_IRQ ((unsigned)INVALID_HWIRQ)
>
> static inline struct soundscape *get_card_soundscape(struct snd_card *c)
> {

This seems failing to build on my local tree as is.
We need to include <linux/irq.h> explicitly.


thanks,

Takashi

2022-07-18 19:30:35

by Andy Shevchenko

Subject: Re: [PATCH v1 1/1] ALSA: isa: Use INVALID_HWIRQ definition

On Sat, Jul 16, 2022 at 08:54:17AM +0200, Takashi Iwai wrote:
> On Fri, 15 Jul 2022 22:57:37 +0200,
> Andy Shevchenko wrote:

...

> > -#define INVALID_IRQ ((unsigned)-1)
> > -
> > +#define INVALID_IRQ ((unsigned)INVALID_HWIRQ)
>
> This seems failing to build on my local tree as is.
> We need to include <linux/irq.h> explicitly.

As Marc told me this is probably the way to the wrong direction, so, please,
discard this patch anyway.

--
With Best Regards,
Andy Shevchenko