Hi all,
This series adds support for the variant of the Innosilicon MIPI CSI DPHY that
can be found in Rockchip RK356x SoCs.
Please note that only the basic operating mode is supported, in which all four
CSI lanes are controlled by the Rockchip ISP. Split lane operation (e.g., two
lanes to ISP and two lanes to VICAP) is not supported.
This has been tested on a Radxa ROCK3 Model A board together with an IMX219
camera sensor and a patched version of the rkisp1 driver (with support for the
RK356x variant V2.1 added in a very crude way).
Looking forward to your comments!
Best regards,
Michael
Michael Riesch (3):
dt-bindings: phy: add compatible for rk356x to rockchip-inno-csi-dphy
phy: rockchip: add support for the rk356x variant to
rockchip-inno-csidphy
arm64: dts: rockchip: add csi dphy node to rk356x
.../bindings/phy/rockchip-inno-csi-dphy.yaml | 1 +
arch/arm64/boot/dts/rockchip/rk356x.dtsi | 12 ++++++++++
.../phy/rockchip/phy-rockchip-inno-csidphy.c | 24 +++++++++++++++++++
3 files changed, 37 insertions(+)
--
2.30.2
Hi all,
On 7/20/22 11:15, Michael Riesch wrote:
> Hi all,
>
> This series adds support for the variant of the Innosilicon MIPI CSI DPHY that
> can be found in Rockchip RK356x SoCs.
>
> Please note that only the basic operating mode is supported, in which all four
> CSI lanes are controlled by the Rockchip ISP. Split lane operation (e.g., two
> lanes to ISP and two lanes to VICAP) is not supported.
>
> This has been tested on a Radxa ROCK3 Model A board together with an IMX219
> camera sensor and a patched version of the rkisp1 driver (with support for the
> RK356x variant V2.1 added in a very crude way).
If someone would like to test the patches, I pushed the hacks required
to bring up the RK3568 ISP to
https://github.com/mriesch-wv/linux/commits/feature/isp2
The following commands are required to set up streaming for my IMX219
module (Raspberry Pi Camera V2.1):
media-ctl -d "platform:rkisp1" --set-v4l2 '"rkisp1_isp":0
[fmt:SRGGB10_1X10/3280x2464 crop: (0,0)/3200x2400]'
media-ctl -d "platform:rkisp1" --set-v4l2 '"rkisp1_isp":2
[fmt:YUYV8_2X8/3200x2400 crop: (0,0)/3200x2400]'
media-ctl -d "platform:rkisp1" --set-v4l2 '"rkisp1_resizer_mainpath":0
[fmt:YUYV8_2X8/3200x2400 crop: (0,0)/3200x2400]'
media-ctl -d "platform:rkisp1" --set-v4l2 '"rkisp1_resizer_mainpath":1
[fmt:YUYV8_2X8/3200x2400]'
media-ctl -d "platform:rkisp1" --set-v4l2 '"rkisp1_resizer_selfpath":0
[fmt:YUYV8_2X8/3200x2400]'
media-ctl -d "platform:rkisp1" --set-v4l2 '"rkisp1_resizer_selfpath":1
[fmt:YUYV8_2X8/800x600]'
v4l2-ctl -z "platform:rkisp1" -d "rkisp1_mainpath" -v
"width=3200,height=2400"
(adjust to your camera module as required). After that, I can stream
with, e.g.,
gst-launch-1.0 v4l2src ! video/x-raw,width=3200,height=2400 ! waylandsink
The image quality is horrid, of course (I think the ISP is not even
debayering the sensor data), but one can recognize the objects before
the camera and it can be proved that the CSI DPHY works.
Best regards,
Michael
>
> Looking forward to your comments!
>
> Best regards,
> Michael
>
> Michael Riesch (3):
> dt-bindings: phy: add compatible for rk356x to rockchip-inno-csi-dphy
> phy: rockchip: add support for the rk356x variant to
> rockchip-inno-csidphy
> arm64: dts: rockchip: add csi dphy node to rk356x
>
> .../bindings/phy/rockchip-inno-csi-dphy.yaml | 1 +
> arch/arm64/boot/dts/rockchip/rk356x.dtsi | 12 ++++++++++
> .../phy/rockchip/phy-rockchip-inno-csidphy.c | 24 +++++++++++++++++++
> 3 files changed, 37 insertions(+)
>
On 7/20/22 11:15, Michael Riesch wrote:
> Hi all,
>
> This series adds support for the variant of the Innosilicon MIPI CSI DPHY that
> can be found in Rockchip RK356x SoCs.
>
> Please note that only the basic operating mode is supported, in which all four
> CSI lanes are controlled by the Rockchip ISP. Split lane operation (e.g., two
> lanes to ISP and two lanes to VICAP) is not supported.
>
> This has been tested on a Radxa ROCK3 Model A board together with an IMX219
> camera sensor and a patched version of the rkisp1 driver (with support for the
> RK356x variant V2.1 added in a very crude way).
>
> Looking forward to your comments!
>
> Best regards,
> Michael
>
> Michael Riesch (3):
> dt-bindings: phy: add compatible for rk356x to rockchip-inno-csi-dphy
> phy: rockchip: add support for the rk356x variant to
> rockchip-inno-csidphy
> arm64: dts: rockchip: add csi dphy node to rk356x
>
> .../bindings/phy/rockchip-inno-csi-dphy.yaml | 1 +
> arch/arm64/boot/dts/rockchip/rk356x.dtsi | 12 ++++++++++
> .../phy/rockchip/phy-rockchip-inno-csidphy.c | 24 +++++++++++++++++++
> 3 files changed, 37 insertions(+)
>
Gentle ping on this one. I am aware of course that it is still vacation
season and the merge window was there as well, but it would be nice to
have some feedback.
Thanks and best regards,
Michael
On 20-07-22, 11:15, Michael Riesch wrote:
> Hi all,
>
> This series adds support for the variant of the Innosilicon MIPI CSI DPHY that
> can be found in Rockchip RK356x SoCs.
>
> Please note that only the basic operating mode is supported, in which all four
> CSI lanes are controlled by the Rockchip ISP. Split lane operation (e.g., two
> lanes to ISP and two lanes to VICAP) is not supported.
>
> This has been tested on a Radxa ROCK3 Model A board together with an IMX219
> camera sensor and a patched version of the rkisp1 driver (with support for the
> RK356x variant V2.1 added in a very crude way).
Applied 1-2, thanks
--
~Vinod
On Wed, 20 Jul 2022 11:15:24 +0200, Michael Riesch wrote:
> This series adds support for the variant of the Innosilicon MIPI CSI DPHY that
> can be found in Rockchip RK356x SoCs.
>
> Please note that only the basic operating mode is supported, in which all four
> CSI lanes are controlled by the Rockchip ISP. Split lane operation (e.g., two
> lanes to ISP and two lanes to VICAP) is not supported.
>
> [...]
Applied, thanks!
[3/3] arm64: dts: rockchip: add csi dphy node to rk356x
commit: b6c228401b2565b7bd59ad7418074145cdaa316a
Best regards,
--
Heiko Stuebner <[email protected]>