2022-09-06 03:06:45

by Meng, Li (Jassmine)

Subject: [Patch] cpufreq: amd-pstate: modify type in argument 2 for filp_open

Modify restricted FMODE_PREAD to experted int O_RDONLY to
fix the sparse warnings below:
sparse warnings: (new ones prefixed by >>)
>> drivers/cpufreq/amd-pstate-ut.c:74:40: sparse: sparse: incorrect type
>> in argument 2 (different base types) @@ expected int @@ got
>> restricted fmode_t [usertype] @@
drivers/cpufreq/amd-pstate-ut.c:74:40: sparse: expected int
drivers/cpufreq/amd-pstate-ut.c:74:40: sparse: got restricted
fmode_t [usertype]

Signed-off-by: Meng Li <[email protected]>
Reported-by: kernel test robot <[email protected]>
---
drivers/cpufreq/amd-pstate-ut.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/cpufreq/amd-pstate-ut.c b/drivers/cpufreq/amd-pstate-ut.c
index 3947b7138184..e4a5b4d90f83 100644
--- a/drivers/cpufreq/amd-pstate-ut.c
+++ b/drivers/cpufreq/amd-pstate-ut.c
@@ -71,7 +71,7 @@ static bool get_shared_mem(void)
ssize_t ret;

if (!boot_cpu_has(X86_FEATURE_CPPC)) {
- filp = filp_open(path, FMODE_PREAD, 0);
+ filp = filp_open(path, O_RDONLY, 0);
if (IS_ERR(filp))
pr_err("%s unable to open %s file!\n", __func__, path);
else {
--
2.34.1

2022-09-06 03:36:55

by Huang Rui

Subject: Re: [Patch] cpufreq: amd-pstate: modify type in argument 2 for filp_open

On Tue, Sep 06, 2022 at 10:48:26AM +0800, Meng, Li (Jassmine) wrote:
> Modify restricted FMODE_PREAD to experted int O_RDONLY to
> fix the sparse warnings below:
> sparse warnings: (new ones prefixed by >>)
> >> drivers/cpufreq/amd-pstate-ut.c:74:40: sparse: sparse: incorrect type
> >> in argument 2 (different base types) @@ expected int @@ got
> >> restricted fmode_t [usertype] @@
> drivers/cpufreq/amd-pstate-ut.c:74:40: sparse: expected int
> drivers/cpufreq/amd-pstate-ut.c:74:40: sparse: got restricted
> fmode_t [usertype]
>
> Signed-off-by: Meng Li <[email protected]>
> Reported-by: kernel test robot <[email protected]>

Acked-by: Huang Rui <[email protected]>

> ---
> drivers/cpufreq/amd-pstate-ut.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/amd-pstate-ut.c b/drivers/cpufreq/amd-pstate-ut.c
> index 3947b7138184..e4a5b4d90f83 100644
> --- a/drivers/cpufreq/amd-pstate-ut.c
> +++ b/drivers/cpufreq/amd-pstate-ut.c
> @@ -71,7 +71,7 @@ static bool get_shared_mem(void)
> ssize_t ret;
>
> if (!boot_cpu_has(X86_FEATURE_CPPC)) {
> - filp = filp_open(path, FMODE_PREAD, 0);
> + filp = filp_open(path, O_RDONLY, 0);
> if (IS_ERR(filp))
> pr_err("%s unable to open %s file!\n", __func__, path);
> else {
> --
> 2.34.1
>