2022-09-09 08:32:01

by Liu Shixin

Subject: [PATCH] mm: kfence: convert to DEFINE_SEQ_ATTRIBUTE

Use DEFINE_SEQ_ATTRIBUTE helper macro to simplify the code.

Signed-off-by: Liu Shixin <[email protected]>
---
mm/kfence/core.c | 15 ++-------------
1 file changed, 2 insertions(+), 13 deletions(-)

diff --git a/mm/kfence/core.c b/mm/kfence/core.c
index 8c08ae2101d7..26de62a51665 100644
--- a/mm/kfence/core.c
+++ b/mm/kfence/core.c
@@ -719,24 +719,13 @@ static int show_object(struct seq_file *seq, void *v)
return 0;
}

-static const struct seq_operations object_seqops = {
+static const struct seq_operations objects_sops = {
.start = start_object,
.next = next_object,
.stop = stop_object,
.show = show_object,
};
-
-static int open_objects(struct inode *inode, struct file *file)
-{
- return seq_open(file, &object_seqops);
-}
-
-static const struct file_operations objects_fops = {
- .open = open_objects,
- .read = seq_read,
- .llseek = seq_lseek,
- .release = seq_release,
-};
+DEFINE_SEQ_ATTRIBUTE(objects);

static int __init kfence_debugfs_init(void)
{
--
2.25.1

2022-09-09 08:36:27

by Marco Elver

Subject: Re: [PATCH] mm: kfence: convert to DEFINE_SEQ_ATTRIBUTE

On Fri, Sep 09, 2022 at 04:31PM +0800, 'Liu Shixin' via kasan-dev wrote:
> Use DEFINE_SEQ_ATTRIBUTE helper macro to simplify the code.
>
> Signed-off-by: Liu Shixin <[email protected]>

Reviewed-by: Marco Elver <[email protected]>
Tested-by: Marco Elver <[email protected]>

> ---
> mm/kfence/core.c | 15 ++-------------
> 1 file changed, 2 insertions(+), 13 deletions(-)
>
> diff --git a/mm/kfence/core.c b/mm/kfence/core.c
> index 8c08ae2101d7..26de62a51665 100644
> --- a/mm/kfence/core.c
> +++ b/mm/kfence/core.c
> @@ -719,24 +719,13 @@ static int show_object(struct seq_file *seq, void *v)
> return 0;
> }
>
> -static const struct seq_operations object_seqops = {
> +static const struct seq_operations objects_sops = {
> .start = start_object,
> .next = next_object,
> .stop = stop_object,
> .show = show_object,
> };
> -
> -static int open_objects(struct inode *inode, struct file *file)
> -{
> - return seq_open(file, &object_seqops);
> -}
> -
> -static const struct file_operations objects_fops = {
> - .open = open_objects,
> - .read = seq_read,
> - .llseek = seq_lseek,
> - .release = seq_release,
> -};
> +DEFINE_SEQ_ATTRIBUTE(objects);
>
> static int __init kfence_debugfs_init(void)
> {
> --
> 2.25.1