perf_pmu_lex has been removed since
commit 65f3e56e0c81 ("perf tools: Remove auto-generated bison/flex files"),
so remove it.
Signed-off-by: Gaosheng Cui <[email protected]>
---
tools/perf/util/pmu.y | 2 --
1 file changed, 2 deletions(-)
diff --git a/tools/perf/util/pmu.y b/tools/perf/util/pmu.y
index bfd7e8509869..0dab0ec2eff7 100644
--- a/tools/perf/util/pmu.y
+++ b/tools/perf/util/pmu.y
@@ -10,8 +10,6 @@
#include <string.h>
#include "pmu.h"
-extern int perf_pmu_lex (void);
-
#define ABORT_ON(val) \
do { \
if (val) \
--
2.25.1
On 09/09/2022 05:45, Gaosheng Cui wrote:
> perf_pmu_lex has been removed since
> commit 65f3e56e0c81 ("perf tools: Remove auto-generated bison/flex files"),
> so remove it.
Not 100% sure if that is the right commit to reference because it didn't
touch pmu.y.
perf_pmu_lex is still used and there are plenty of references to it, but
maybe the extern declaration isn't needed anymore because it still
builds for me with this change.
>
> Signed-off-by: Gaosheng Cui <[email protected]>
> ---
> tools/perf/util/pmu.y | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/tools/perf/util/pmu.y b/tools/perf/util/pmu.y
> index bfd7e8509869..0dab0ec2eff7 100644
> --- a/tools/perf/util/pmu.y
> +++ b/tools/perf/util/pmu.y
> @@ -10,8 +10,6 @@
> #include <string.h>
> #include "pmu.h"
>
> -extern int perf_pmu_lex (void);
> -
> #define ABORT_ON(val) \
> do { \
> if (val) \
Em Fri, Sep 09, 2022 at 10:43:52AM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Fri, Sep 09, 2022 at 11:29:43AM +0100, James Clark escreveu:
> >
> >
> > On 09/09/2022 05:45, Gaosheng Cui wrote:
> > > perf_pmu_lex has been removed since
> > > commit 65f3e56e0c81 ("perf tools: Remove auto-generated bison/flex files"),
> > > so remove it.
> >
> > Not 100% sure if that is the right commit to reference because it didn't
> > touch pmu.y.
>
> Yeah, indeed, unsure if at that time the declaration was needed.
>
> > perf_pmu_lex is still used and there are plenty of references to it, but
> > maybe the extern declaration isn't needed anymore because it still
> > builds for me with this change.
>
> Ditto here, I'll remove the reference and rewrite the cset log a bit.
I left it as:
perf pmu: Remove perf_pmu_lex() needless declaration
It builds without it, perhaps with some older combination of flex/bison
we needed this, clean it up a bit removing this.
Em Fri, Sep 09, 2022 at 11:29:43AM +0100, James Clark escreveu:
>
>
> On 09/09/2022 05:45, Gaosheng Cui wrote:
> > perf_pmu_lex has been removed since
> > commit 65f3e56e0c81 ("perf tools: Remove auto-generated bison/flex files"),
> > so remove it.
>
> Not 100% sure if that is the right commit to reference because it didn't
> touch pmu.y.
Yeah, indeed, unsure if at that time the declaration was needed.
> perf_pmu_lex is still used and there are plenty of references to it, but
> maybe the extern declaration isn't needed anymore because it still
> builds for me with this change.
Ditto here, I'll remove the reference and rewrite the cset log a bit.
- Arnaldo