2022-09-17 18:58:43

by Kang Minchul

Subject: [PATCH 1/2] staging: rtl8723bs: Fix coding style issue in block comment

This patch removes the following warning generated by checkpatch.pl

WARNING: Block comments use * on subsequent lines
#206: FILE: rtw_recv.c:206:
+/*
+signed int rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *queue)

WARNING: Block comments use * on subsequent lines
#216: FILE: rtw_recv.c:216:
+/*
+caller : defrag ; recvframe_chk_defrag in recv_thread (passive)

Signed-off-by: Kang Minchul <[email protected]>
---
drivers/staging/rtl8723bs/core/rtw_recv.c | 22 +++++++++++-----------
1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c
index d8d394b67eeb..ad6fb6c3d1f0 100644
--- a/drivers/staging/rtl8723bs/core/rtw_recv.c
+++ b/drivers/staging/rtl8723bs/core/rtw_recv.c
@@ -203,22 +203,22 @@ signed int rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *q
}

/*
-signed int rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *queue)
-{
- return rtw_free_recvframe(precvframe, queue);
-}
-*/
+ * signed int rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *queue)
+ * {
+ * return rtw_free_recvframe(precvframe, queue);
+ * }
+ */




/*
-caller : defrag ; recvframe_chk_defrag in recv_thread (passive)
-pframequeue: defrag_queue : will be accessed in recv_thread (passive)
-
-using spinlock to protect
-
-*/
+ * caller : defrag ; recvframe_chk_defrag in recv_thread (passive)
+ * pframequeue: defrag_queue : will be accessed in recv_thread (passive)
+ *
+ * using spinlock to protect
+ *
+ */

void rtw_free_recvframe_queue(struct __queue *pframequeue, struct __queue *pfree_recv_queue)
{
--
2.34.1

2022-09-17 19:48:54

by Hans de Goede

Subject: Re: [PATCH 1/2] staging: rtl8723bs: Fix coding style issue in block comment

Hi,

On 9/17/22 20:11, Kang Minchul wrote:
> This patch removes the following warning generated by checkpatch.pl
>
> WARNING: Block comments use * on subsequent lines
> #206: FILE: rtw_recv.c:206:
> +/*
> +signed int rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *queue)
>
> WARNING: Block comments use * on subsequent lines
> #216: FILE: rtw_recv.c:216:
> +/*
> +caller : defrag ; recvframe_chk_defrag in recv_thread (passive)
>
> Signed-off-by: Kang Minchul <[email protected]>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <[email protected]>

Regards,

Hans


> ---
> drivers/staging/rtl8723bs/core/rtw_recv.c | 22 +++++++++++-----------
> 1 file changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c
> index d8d394b67eeb..ad6fb6c3d1f0 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_recv.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_recv.c
> @@ -203,22 +203,22 @@ signed int rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *q
> }
>
> /*
> -signed int rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *queue)
> -{
> - return rtw_free_recvframe(precvframe, queue);
> -}
> -*/
> + * signed int rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *queue)
> + * {
> + * return rtw_free_recvframe(precvframe, queue);
> + * }
> + */
>
>
>
>
> /*
> -caller : defrag ; recvframe_chk_defrag in recv_thread (passive)
> -pframequeue: defrag_queue : will be accessed in recv_thread (passive)
> -
> -using spinlock to protect
> -
> -*/
> + * caller : defrag ; recvframe_chk_defrag in recv_thread (passive)
> + * pframequeue: defrag_queue : will be accessed in recv_thread (passive)
> + *
> + * using spinlock to protect
> + *
> + */
>
> void rtw_free_recvframe_queue(struct __queue *pframequeue, struct __queue *pfree_recv_queue)
> {

2022-09-19 09:11:16

by Dan Carpenter

Subject: Re: [PATCH 1/2] staging: rtl8723bs: Fix coding style issue in block comment

On Sun, Sep 18, 2022 at 03:11:30AM +0900, Kang Minchul wrote:
> This patch removes the following warning generated by checkpatch.pl
>
> WARNING: Block comments use * on subsequent lines
> #206: FILE: rtw_recv.c:206:
> +/*
> +signed int rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *queue)
>
> WARNING: Block comments use * on subsequent lines
> #216: FILE: rtw_recv.c:216:
> +/*
> +caller : defrag ; recvframe_chk_defrag in recv_thread (passive)
>
> Signed-off-by: Kang Minchul <[email protected]>
> ---
> drivers/staging/rtl8723bs/core/rtw_recv.c | 22 +++++++++++-----------
> 1 file changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c
> index d8d394b67eeb..ad6fb6c3d1f0 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_recv.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_recv.c
> @@ -203,22 +203,22 @@ signed int rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *q
> }
>
> /*
> -signed int rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *queue)
> -{
> - return rtw_free_recvframe(precvframe, queue);
> -}
> -*/
> + * signed int rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *queue)
> + * {
> + * return rtw_free_recvframe(precvframe, queue);
> + * }
> + */

Just delete this dead code.

regards,
dan carpenter

2022-09-19 09:25:22

by Greg Kroah-Hartman

Subject: Re: [PATCH 1/2] staging: rtl8723bs: Fix coding style issue in block comment

On Sun, Sep 18, 2022 at 03:11:30AM +0900, Kang Minchul wrote:
> This patch removes the following warning generated by checkpatch.pl
>
> WARNING: Block comments use * on subsequent lines
> #206: FILE: rtw_recv.c:206:
> +/*
> +signed int rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *queue)
>
> WARNING: Block comments use * on subsequent lines
> #216: FILE: rtw_recv.c:216:
> +/*
> +caller : defrag ; recvframe_chk_defrag in recv_thread (passive)
>
> Signed-off-by: Kang Minchul <[email protected]>
> ---
> drivers/staging/rtl8723bs/core/rtw_recv.c | 22 +++++++++++-----------
> 1 file changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c
> index d8d394b67eeb..ad6fb6c3d1f0 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_recv.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_recv.c
> @@ -203,22 +203,22 @@ signed int rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *q
> }
>
> /*
> -signed int rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *queue)
> -{
> - return rtw_free_recvframe(precvframe, queue);
> -}
> -*/
> + * signed int rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *queue)
> + * {
> + * return rtw_free_recvframe(precvframe, queue);
> + * }
> + */

I agree with Dan, just remove these unused functions please.

thanks,

greg k-h

2022-09-19 14:09:44

by Kang Minchul

Subject: Re: [PATCH 1/2] staging: rtl8723bs: Fix coding style issue in block comment

Thank you for your feedback!
I just amended and re-submitted the patch.

Thank you.
Kang


2022년 9월 19일 (월) 오후 6:09, Greg Kroah-Hartman <[email protected]>님이 작성:
>
> On Sun, Sep 18, 2022 at 03:11:30AM +0900, Kang Minchul wrote:
> > This patch removes the following warning generated by checkpatch.pl
> >
> > WARNING: Block comments use * on subsequent lines
> > #206: FILE: rtw_recv.c:206:
> > +/*
> > +signed int rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *queue)
> >
> > WARNING: Block comments use * on subsequent lines
> > #216: FILE: rtw_recv.c:216:
> > +/*
> > +caller : defrag ; recvframe_chk_defrag in recv_thread (passive)
> >
> > Signed-off-by: Kang Minchul <[email protected]>
> > ---
> > drivers/staging/rtl8723bs/core/rtw_recv.c | 22 +++++++++++-----------
> > 1 file changed, 11 insertions(+), 11 deletions(-)
> >
> > diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c
> > index d8d394b67eeb..ad6fb6c3d1f0 100644
> > --- a/drivers/staging/rtl8723bs/core/rtw_recv.c
> > +++ b/drivers/staging/rtl8723bs/core/rtw_recv.c
> > @@ -203,22 +203,22 @@ signed int rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *q
> > }
> >
> > /*
> > -signed int rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *queue)
> > -{
> > - return rtw_free_recvframe(precvframe, queue);
> > -}
> > -*/
> > + * signed int rtw_enqueue_recvframe(union recv_frame *precvframe, struct __queue *queue)
> > + * {
> > + * return rtw_free_recvframe(precvframe, queue);
> > + * }
> > + */
>
> I agree with Dan, just remove these unused functions please.
>
> thanks,
>
> greg k-h