2022-09-21 19:48:23

by Wolfram Sang

[permalink] [raw]
Subject: Re: [PATCH v5 1/8] i2c: i2c-mlxbf.c: Fix frequency calculation

On Tue, Sep 20, 2022 at 01:47:29PM -0400, Asmaa Mnebhi wrote:
> The i2c-mlxbf.c driver is currently broken because there is a bug
> in the calculation of the frequency. core_f, core_r and core_od
> are components read from hardware registers and are used to
> compute the frequency used to compute different timing parameters.
> The shifting mechanism used to get core_f, core_r and core_od is
> wrong. Use FIELD_GET to mask and shift the bitfields properly.
>
> Fixes: b5b5b32081cd206b (i2c: mlxbf: I2C SMBus driver for Mellanox BlueField SoC)
> Reviewed-by: Khalil Blaiech <[email protected]>
> Signed-off-by: Asmaa Mnebhi <[email protected]>

Applied to for-current, thanks!


Attachments:
(No filename) (695.00 B)
signature.asc (849.00 B)
Download all attachments