2023-03-10 23:19:08

by Minwoo Im

Subject: [PATCH] mm: mmap: remove newline at the end of the trace

We already have newline in TP_printk so remove the redundant newline
character at the end of the mmap trace.

<...>-345 [006] ..... 95.589290: exit_mmap: mt_mod ...

<...>-345 [006] ..... 95.589413: vm_unmapped_area: addr=...

<...>-345 [006] ..... 95.589571: vm_unmapped_area: addr=...

<...>-345 [006] ..... 95.589606: vm_unmapped_area: addr=...

to

<...>-336 [006] ..... 44.762506: exit_mmap: mt_mod ...
<...>-336 [006] ..... 44.762654: vm_unmapped_area: addr=...
<...>-336 [006] ..... 44.762794: vm_unmapped_area: addr=...
<...>-336 [006] ..... 44.762835: vm_unmapped_area: addr=...

Signed-off-by: Minwoo Im <[email protected]>
---
include/trace/events/mmap.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/trace/events/mmap.h b/include/trace/events/mmap.h
index 216de5f03621..f8d61485de16 100644
--- a/include/trace/events/mmap.h
+++ b/include/trace/events/mmap.h
@@ -35,7 +35,7 @@ TRACE_EVENT(vm_unmapped_area,
__entry->align_offset = info->align_offset;
),

- TP_printk("addr=0x%lx err=%ld total_vm=0x%lx flags=0x%lx len=0x%lx lo=0x%lx hi=0x%lx mask=0x%lx ofs=0x%lx\n",
+ TP_printk("addr=0x%lx err=%ld total_vm=0x%lx flags=0x%lx len=0x%lx lo=0x%lx hi=0x%lx mask=0x%lx ofs=0x%lx",
IS_ERR_VALUE(__entry->addr) ? 0 : __entry->addr,
IS_ERR_VALUE(__entry->addr) ? __entry->addr : 0,
__entry->total_vm, __entry->flags, __entry->length,
@@ -110,7 +110,7 @@ TRACE_EVENT(exit_mmap,
__entry->mt = &mm->mm_mt;
),

- TP_printk("mt_mod %p, DESTROY\n",
+ TP_printk("mt_mod %p, DESTROY",
__entry->mt
)
);
--
2.34.1

2023-03-10 23:25:53

by Steven Rostedt

Subject: Re: [PATCH] mm: mmap: remove newline at the end of the trace

On Sat, 11 Mar 2023 08:18:00 +0900
Minwoo Im <[email protected]> wrote:

> We already have newline in TP_printk so remove the redundant newline
> character at the end of the mmap trace.
>
> <...>-345 [006] ..... 95.589290: exit_mmap: mt_mod ...
>
> <...>-345 [006] ..... 95.589413: vm_unmapped_area: addr=...
>
> <...>-345 [006] ..... 95.589571: vm_unmapped_area: addr=...
>
> <...>-345 [006] ..... 95.589606: vm_unmapped_area: addr=...
>
> to
>
> <...>-336 [006] ..... 44.762506: exit_mmap: mt_mod ...
> <...>-336 [006] ..... 44.762654: vm_unmapped_area: addr=...
> <...>-336 [006] ..... 44.762794: vm_unmapped_area: addr=...
> <...>-336 [006] ..... 44.762835: vm_unmapped_area: addr=...
>
> Signed-off-by: Minwoo Im <[email protected]>

This should go through the mm folks.

Acked-by: Steven Rostedt (Google) <[email protected]>

-- Steve

> ---
> include/trace/events/mmap.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/trace/events/mmap.h b/include/trace/events/mmap.h
> index 216de5f03621..f8d61485de16 100644
> --- a/include/trace/events/mmap.h
> +++ b/include/trace/events/mmap.h
> @@ -35,7 +35,7 @@ TRACE_EVENT(vm_unmapped_area,
> __entry->align_offset = info->align_offset;
> ),
>
> - TP_printk("addr=0x%lx err=%ld total_vm=0x%lx flags=0x%lx len=0x%lx lo=0x%lx hi=0x%lx mask=0x%lx ofs=0x%lx\n",
> + TP_printk("addr=0x%lx err=%ld total_vm=0x%lx flags=0x%lx len=0x%lx lo=0x%lx hi=0x%lx mask=0x%lx ofs=0x%lx",
> IS_ERR_VALUE(__entry->addr) ? 0 : __entry->addr,
> IS_ERR_VALUE(__entry->addr) ? __entry->addr : 0,
> __entry->total_vm, __entry->flags, __entry->length,
> @@ -110,7 +110,7 @@ TRACE_EVENT(exit_mmap,
> __entry->mt = &mm->mm_mt;
> ),
>
> - TP_printk("mt_mod %p, DESTROY\n",
> + TP_printk("mt_mod %p, DESTROY",
> __entry->mt
> )
> );

2023-03-14 05:28:37

by Mukesh Ojha

Subject: Re: [PATCH] mm: mmap: remove newline at the end of the trace

On 3/11/2023 4:48 AM, Minwoo Im wrote:
> We already have newline in TP_printk so remove the redundant newline
> character at the end of the mmap trace.
>
> <...>-345 [006] ..... 95.589290: exit_mmap: mt_mod ...
>
> <...>-345 [006] ..... 95.589413: vm_unmapped_area: addr=...
>
> <...>-345 [006] ..... 95.589571: vm_unmapped_area: addr=...
>
> <...>-345 [006] ..... 95.589606: vm_unmapped_area: addr=...
>
> to
>
> <...>-336 [006] ..... 44.762506: exit_mmap: mt_mod ...
> <...>-336 [006] ..... 44.762654: vm_unmapped_area: addr=...
> <...>-336 [006] ..... 44.762794: vm_unmapped_area: addr=...
> <...>-336 [006] ..... 44.762835: vm_unmapped_area: addr=...
>
> Signed-off-by: Minwoo Im <[email protected]>

Reviewed-by: Mukesh Ojha <[email protected]>

-Mukesh

> ---
> include/trace/events/mmap.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/trace/events/mmap.h b/include/trace/events/mmap.h
> index 216de5f03621..f8d61485de16 100644
> --- a/include/trace/events/mmap.h
> +++ b/include/trace/events/mmap.h
> @@ -35,7 +35,7 @@ TRACE_EVENT(vm_unmapped_area,
> __entry->align_offset = info->align_offset;
> ),
>
> - TP_printk("addr=0x%lx err=%ld total_vm=0x%lx flags=0x%lx len=0x%lx lo=0x%lx hi=0x%lx mask=0x%lx ofs=0x%lx\n",
> + TP_printk("addr=0x%lx err=%ld total_vm=0x%lx flags=0x%lx len=0x%lx lo=0x%lx hi=0x%lx mask=0x%lx ofs=0x%lx",
> IS_ERR_VALUE(__entry->addr) ? 0 : __entry->addr,
> IS_ERR_VALUE(__entry->addr) ? __entry->addr : 0,
> __entry->total_vm, __entry->flags, __entry->length,
> @@ -110,7 +110,7 @@ TRACE_EVENT(exit_mmap,
> __entry->mt = &mm->mm_mt;
> ),
>
> - TP_printk("mt_mod %p, DESTROY\n",
> + TP_printk("mt_mod %p, DESTROY",
> __entry->mt
> )
> );

2023-03-20 11:46:00

by Minwoo Im

Subject: Re: [PATCH] mm: mmap: remove newline at the end of the trace

Ping :)

On 23-03-11 08:18:00, Minwoo Im wrote:
> We already have newline in TP_printk so remove the redundant newline
> character at the end of the mmap trace.
>
> <...>-345 [006] ..... 95.589290: exit_mmap: mt_mod ...
>
> <...>-345 [006] ..... 95.589413: vm_unmapped_area: addr=...
>
> <...>-345 [006] ..... 95.589571: vm_unmapped_area: addr=...
>
> <...>-345 [006] ..... 95.589606: vm_unmapped_area: addr=...
>
> to
>
> <...>-336 [006] ..... 44.762506: exit_mmap: mt_mod ...
> <...>-336 [006] ..... 44.762654: vm_unmapped_area: addr=...
> <...>-336 [006] ..... 44.762794: vm_unmapped_area: addr=...
> <...>-336 [006] ..... 44.762835: vm_unmapped_area: addr=...
>
> Signed-off-by: Minwoo Im <[email protected]>
> ---
> include/trace/events/mmap.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/trace/events/mmap.h b/include/trace/events/mmap.h
> index 216de5f03621..f8d61485de16 100644
> --- a/include/trace/events/mmap.h
> +++ b/include/trace/events/mmap.h
> @@ -35,7 +35,7 @@ TRACE_EVENT(vm_unmapped_area,
> __entry->align_offset = info->align_offset;
> ),
>
> - TP_printk("addr=0x%lx err=%ld total_vm=0x%lx flags=0x%lx len=0x%lx lo=0x%lx hi=0x%lx mask=0x%lx ofs=0x%lx\n",
> + TP_printk("addr=0x%lx err=%ld total_vm=0x%lx flags=0x%lx len=0x%lx lo=0x%lx hi=0x%lx mask=0x%lx ofs=0x%lx",
> IS_ERR_VALUE(__entry->addr) ? 0 : __entry->addr,
> IS_ERR_VALUE(__entry->addr) ? __entry->addr : 0,
> __entry->total_vm, __entry->flags, __entry->length,
> @@ -110,7 +110,7 @@ TRACE_EVENT(exit_mmap,
> __entry->mt = &mm->mm_mt;
> ),
>
> - TP_printk("mt_mod %p, DESTROY\n",
> + TP_printk("mt_mod %p, DESTROY",
> __entry->mt
> )
> );
> --
> 2.34.1
>

2023-03-20 13:35:43

by David Hildenbrand

Subject: Re: [PATCH] mm: mmap: remove newline at the end of the trace

On 11.03.23 00:18, Minwoo Im wrote:
> We already have newline in TP_printk so remove the redundant newline
> character at the end of the mmap trace.
>
> <...>-345 [006] ..... 95.589290: exit_mmap: mt_mod ...
>
> <...>-345 [006] ..... 95.589413: vm_unmapped_area: addr=...
>
> <...>-345 [006] ..... 95.589571: vm_unmapped_area: addr=...
>
> <...>-345 [006] ..... 95.589606: vm_unmapped_area: addr=...
>
> to
>
> <...>-336 [006] ..... 44.762506: exit_mmap: mt_mod ...
> <...>-336 [006] ..... 44.762654: vm_unmapped_area: addr=...
> <...>-336 [006] ..... 44.762794: vm_unmapped_area: addr=...
> <...>-336 [006] ..... 44.762835: vm_unmapped_area: addr=...
>
> Signed-off-by: Minwoo Im <[email protected]>
> ---
> include/trace/events/mmap.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: David Hildenbrand <[email protected]>

--
Thanks,

David / dhildenb