The driver only supports normal polarity. Complete the implementation of
.get_state() by setting .polarity accordingly.
Signed-off-by: Uwe Kleine-König <[email protected]>
---
drivers/pwm/pwm-iqs620a.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pwm/pwm-iqs620a.c b/drivers/pwm/pwm-iqs620a.c
index 8362b4870c66..47b3141135f3 100644
--- a/drivers/pwm/pwm-iqs620a.c
+++ b/drivers/pwm/pwm-iqs620a.c
@@ -126,6 +126,7 @@ static int iqs620_pwm_get_state(struct pwm_chip *chip, struct pwm_device *pwm,
mutex_unlock(&iqs620_pwm->lock);
state->period = IQS620_PWM_PERIOD_NS;
+ state->polarity = PWM_POLARITY_NORMAL;
return 0;
}
--
2.39.1
[To += Jeff LaBundy]
On Tue, Feb 28, 2023 at 02:55:07PM +0100, Uwe Kleine-K?nig wrote:
> The driver only supports normal polarity. Complete the implementation of
> .get_state() by setting .polarity accordingly.
>
> Signed-off-by: Uwe Kleine-K?nig <[email protected]>
I think we should apply this patch as a fix to prevent similar failures
as reported for the meson driver. To justify that:
Fixes: 6f0841a8197b ("pwm: Add support for Azoteq IQS620A PWM generator")
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | https://www.pengutronix.de/ |
On Fri, Mar 10, 2023 at 07:48:15PM +0100, Uwe Kleine-K?nig wrote:
> [To += Jeff LaBundy]
>
> On Tue, Feb 28, 2023 at 02:55:07PM +0100, Uwe Kleine-K?nig wrote:
> > The driver only supports normal polarity. Complete the implementation of
> > .get_state() by setting .polarity accordingly.
> >
> > Signed-off-by: Uwe Kleine-K?nig <[email protected]>
>
> I think we should apply this patch as a fix to prevent similar failures
> as reported for the meson driver. To justify that:
>
> Fixes: 6f0841a8197b ("pwm: Add support for Azoteq IQS620A PWM generator")
Reviewed-by: Jeff LaBundy <[email protected]>
>
> Best regards
> Uwe
>
> --
> Pengutronix e.K. | Uwe Kleine-K?nig |
> Industrial Linux Solutions | https://www.pengutronix.de/ |