2023-03-19 14:11:56

by Tom Rix

Subject: [PATCH] usb: typec: tcpci_mt6360: remove unused mt6360_tcpc_read16 function

clang with W=1 reports
drivers/usb/typec/tcpm/tcpci_mt6360.c:46:19: error: unused function
'mt6360_tcpc_read16' [-Werror,-Wunused-function]
static inline int mt6360_tcpc_read16(struct regmap *regmap,
^
This function is not used, so remove it.

Signed-off-by: Tom Rix <[email protected]>
---
drivers/usb/typec/tcpm/tcpci_mt6360.c | 6 ------
1 file changed, 6 deletions(-)

diff --git a/drivers/usb/typec/tcpm/tcpci_mt6360.c b/drivers/usb/typec/tcpm/tcpci_mt6360.c
index 1b7c31278ebb..6fa8fd5c8041 100644
--- a/drivers/usb/typec/tcpm/tcpci_mt6360.c
+++ b/drivers/usb/typec/tcpm/tcpci_mt6360.c
@@ -43,12 +43,6 @@ struct mt6360_tcpc_info {
int irq;
};

-static inline int mt6360_tcpc_read16(struct regmap *regmap,
- unsigned int reg, u16 *val)
-{
- return regmap_raw_read(regmap, reg, val, sizeof(u16));
-}
-
static inline int mt6360_tcpc_write16(struct regmap *regmap,
unsigned int reg, u16 val)
{
--
2.27.0

2023-03-20 11:59:24

by Heikki Krogerus

Subject: Re: [PATCH] usb: typec: tcpci_mt6360: remove unused mt6360_tcpc_read16 function

On Sun, Mar 19, 2023 at 10:10:53AM -0400, Tom Rix wrote:
> clang with W=1 reports
> drivers/usb/typec/tcpm/tcpci_mt6360.c:46:19: error: unused function
> 'mt6360_tcpc_read16' [-Werror,-Wunused-function]
> static inline int mt6360_tcpc_read16(struct regmap *regmap,
> ^
> This function is not used, so remove it.
>
> Signed-off-by: Tom Rix <[email protected]>

Reviewed-by: Heikki Krogerus <[email protected]>

> ---
> drivers/usb/typec/tcpm/tcpci_mt6360.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/usb/typec/tcpm/tcpci_mt6360.c b/drivers/usb/typec/tcpm/tcpci_mt6360.c
> index 1b7c31278ebb..6fa8fd5c8041 100644
> --- a/drivers/usb/typec/tcpm/tcpci_mt6360.c
> +++ b/drivers/usb/typec/tcpm/tcpci_mt6360.c
> @@ -43,12 +43,6 @@ struct mt6360_tcpc_info {
> int irq;
> };
>
> -static inline int mt6360_tcpc_read16(struct regmap *regmap,
> - unsigned int reg, u16 *val)
> -{
> - return regmap_raw_read(regmap, reg, val, sizeof(u16));
> -}
> -
> static inline int mt6360_tcpc_write16(struct regmap *regmap,
> unsigned int reg, u16 val)
> {
> --
> 2.27.0

--
heikki