2023-03-23 20:02:15

by Khadija Kamran

Subject: [PATCH v3] staging: most: fix line ending with '(' in dim2/

Splitting function header to multiple lines because of 80 characters per
line limit, results in ending the function call line with '('.
This leads to CHECK reported by checkpatch.pl

Move the function parameters right after the '(' in the function call
line. Align the rest of the parameters to the opening parenthesis.

Signed-off-by: Khadija Kamran <[email protected]>
---

Changes in v3:
- Changed the subject because another patch for 'most/' with the same
name was causing confusion.

Changes in v2:
- Changed the description

drivers/staging/most/dim2/hal.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/most/dim2/hal.c b/drivers/staging/most/dim2/hal.c
index a5d40b5b138a..6abe3ab2b2cf 100644
--- a/drivers/staging/most/dim2/hal.c
+++ b/drivers/staging/most/dim2/hal.c
@@ -346,9 +346,8 @@ static void dim2_clear_ctram(void)
dim2_clear_ctr(ctr_addr);
}

-static void dim2_configure_channel(
- u8 ch_addr, u8 type, u8 is_tx, u16 dbr_address, u16 hw_buffer_size,
- u16 packet_length)
+static void dim2_configure_channel(u8 ch_addr, u8 type, u8 is_tx, u16 dbr_address,
+ u16 hw_buffer_size, u16 packet_length)
{
dim2_configure_cdt(ch_addr, dbr_address, hw_buffer_size, packet_length);
dim2_configure_cat(MLB_CAT, ch_addr, type, is_tx ? 1 : 0);
--
2.34.1

2023-03-24 22:27:55

by Ira Weiny

Subject: Re: [PATCH v3] staging: most: fix line ending with '(' in dim2/

Khadija Kamran wrote:
> Splitting function header to multiple lines because of 80 characters per
> line limit, results in ending the function call line with '('.
> This leads to CHECK reported by checkpatch.pl
>
> Move the function parameters right after the '(' in the function call
> line. Align the rest of the parameters to the opening parenthesis.
>
> Signed-off-by: Khadija Kamran <[email protected]>
> ---
>
> Changes in v3:
> - Changed the subject because another patch for 'most/' with the same
> name was causing confusion.
>
> Changes in v2:
> - Changed the description
>
> drivers/staging/most/dim2/hal.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/most/dim2/hal.c b/drivers/staging/most/dim2/hal.c
> index a5d40b5b138a..6abe3ab2b2cf 100644
> --- a/drivers/staging/most/dim2/hal.c
> +++ b/drivers/staging/most/dim2/hal.c
> @@ -346,9 +346,8 @@ static void dim2_clear_ctram(void)
> dim2_clear_ctr(ctr_addr);
> }
>
> -static void dim2_configure_channel(
> - u8 ch_addr, u8 type, u8 is_tx, u16 dbr_address, u16 hw_buffer_size,
> - u16 packet_length)
> +static void dim2_configure_channel(u8 ch_addr, u8 type, u8 is_tx, u16 dbr_address,
> + u16 hw_buffer_size, u16 packet_length)

Same comment as the previous version I saw.

Ira

> {
> dim2_configure_cdt(ch_addr, dbr_address, hw_buffer_size, packet_length);
> dim2_configure_cat(MLB_CAT, ch_addr, type, is_tx ? 1 : 0);
> --
> 2.34.1
>
>