2023-03-27 12:25:22

by Khadija Kamran

Subject: [PATCH] staging: nvec: replace udelay() with usleep_range()

Replace 'udelay()' with 'usleep_range()' with 1000us as upper limit.
This issue is reported by checkpatch.pl script.

CHECK: usleep_range is preferred over udelay; see
Documentation/timers/timers-howto.rst

Signed-off-by: Khadija Kamran <[email protected]>
---
drivers/staging/nvec/nvec.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c
index b3f114cb00dc..1b51935dba4f 100644
--- a/drivers/staging/nvec/nvec.c
+++ b/drivers/staging/nvec/nvec.c
@@ -627,7 +627,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev)
break;
case 2: /* first byte after command */
if (status == (I2C_SL_IRQ | RNW | RCVD)) {
- udelay(33);
+ usleep_range(33, 1000);
if (nvec->rx->data[0] != 0x01) {
dev_err(nvec->dev,
"Read without prior read command\n");
@@ -714,7 +714,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev)
* We experience less incomplete messages with this delay than without
* it, but we don't know why. Help is appreciated.
*/
- udelay(100);
+ usleep_range(100, 1000);

return IRQ_HANDLED;
}
--
2.34.1

2023-03-27 12:26:45

by Dan Carpenter

Subject: Re: [PATCH] staging: nvec: replace udelay() with usleep_range()

On Mon, Mar 27, 2023 at 05:24:03PM +0500, Khadija Kamran wrote:
> Replace 'udelay()' with 'usleep_range()' with 1000us as upper limit.
> This issue is reported by checkpatch.pl script.
>
> CHECK: usleep_range is preferred over udelay; see
> Documentation/timers/timers-howto.rst
>
> Signed-off-by: Khadija Kamran <[email protected]>
> ---

This kind of change requires you to test on the hardware and have
slightly in depth knowledge of the spec.

regards,
dan carpenter

2023-03-27 12:51:24

by Khadija Kamran

Subject: Re: [PATCH] staging: nvec: replace udelay() with usleep_range()

On Mon, Mar 27, 2023 at 03:25:43PM +0300, Dan Carpenter wrote:
> On Mon, Mar 27, 2023 at 05:24:03PM +0500, Khadija Kamran wrote:
> > Replace 'udelay()' with 'usleep_range()' with 1000us as upper limit.
> > This issue is reported by checkpatch.pl script.
> >
> > CHECK: usleep_range is preferred over udelay; see
> > Documentation/timers/timers-howto.rst
> >
> > Signed-off-by: Khadija Kamran <[email protected]>
> > ---
>
> This kind of change requires you to test on the hardware and have
> slightly in depth knowledge of the spec.

Okay, thank you!

Regards,
Khadija


>
> regards,
> dan carpenter
>