2023-03-27 11:58:58

by Manne, Nava kishore

Subject: [PATCH] fpga: xilinx-pr-decoupler: select FPGA_BRIDGE for 'Xilinx LogiCORE PR Decoupler'

The Xilinx LogiCORE PR Decoupler depends on the FPGA_BRIDGE always and
hence select it explicitly to make sure that it will be available all
the time when PR decoupler is enabled.

Signed-off-by: Nava kishore Manne <[email protected]>
---
drivers/fpga/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig
index 0a00763b9f28..71003f256c60 100644
--- a/drivers/fpga/Kconfig
+++ b/drivers/fpga/Kconfig
@@ -115,8 +115,8 @@ config ALTERA_FREEZE_BRIDGE

config XILINX_PR_DECOUPLER
tristate "Xilinx LogiCORE PR Decoupler"
- depends on FPGA_BRIDGE
depends on HAS_IOMEM
+ select FPGA_BRIDGE
help
Say Y to enable drivers for Xilinx LogiCORE PR Decoupler
or Xilinx Dynamic Function eXchange AIX Shutdown Manager.
--
2.25.1

2023-04-01 14:34:05

by Xu Yilun

Subject: Re: [PATCH] fpga: xilinx-pr-decoupler: select FPGA_BRIDGE for 'Xilinx LogiCORE PR Decoupler'

On 2023-03-27 at 17:21:03 +0530, Nava kishore Manne wrote:
> The Xilinx LogiCORE PR Decoupler depends on the FPGA_BRIDGE always and
> hence select it explicitly to make sure that it will be available all
> the time when PR decoupler is enabled.

FPGA_BRIDGE is available all the time if XILINX_PR_DECOUPLER is selected
by user. What's the problem now?

Thanks,
Yilun

>
> Signed-off-by: Nava kishore Manne <[email protected]>
> ---
> drivers/fpga/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig
> index 0a00763b9f28..71003f256c60 100644
> --- a/drivers/fpga/Kconfig
> +++ b/drivers/fpga/Kconfig
> @@ -115,8 +115,8 @@ config ALTERA_FREEZE_BRIDGE
>
> config XILINX_PR_DECOUPLER
> tristate "Xilinx LogiCORE PR Decoupler"
> - depends on FPGA_BRIDGE
> depends on HAS_IOMEM
> + select FPGA_BRIDGE
> help
> Say Y to enable drivers for Xilinx LogiCORE PR Decoupler
> or Xilinx Dynamic Function eXchange AIX Shutdown Manager.
> --
> 2.25.1
>