Add the missing i2c device id
Signed-off-by: Mehdi Djait <[email protected]>
---
v3:
- no changes, this patch is introduced in the v2
drivers/iio/accel/kionix-kx022a-i2c.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/iio/accel/kionix-kx022a-i2c.c b/drivers/iio/accel/kionix-kx022a-i2c.c
index e6fd02d931b6..8f23631a1fd3 100644
--- a/drivers/iio/accel/kionix-kx022a-i2c.c
+++ b/drivers/iio/accel/kionix-kx022a-i2c.c
@@ -30,6 +30,12 @@ static int kx022a_i2c_probe(struct i2c_client *i2c)
return kx022a_probe_internal(dev);
}
+static const struct i2c_device_id kx022a_i2c_id[] = {
+ { .name = "kx022a", 0 },
+ { }
+};
+MODULE_DEVICE_TABLE(i2c, kx022a_i2c_id);
+
static const struct of_device_id kx022a_of_match[] = {
{ .compatible = "kionix,kx022a", },
{ }
@@ -42,6 +48,7 @@ static struct i2c_driver kx022a_i2c_driver = {
.of_match_table = kx022a_of_match,
},
.probe_new = kx022a_i2c_probe,
+ .id_table = kx022a_i2c_id,
};
module_i2c_driver(kx022a_i2c_driver);
--
2.30.2
On 4/25/23 01:22, Mehdi Djait wrote:
> Add the missing i2c device id
>
> Signed-off-by: Mehdi Djait <[email protected]>
Reviewed-by: Matti Vaittinen <[email protected]>
Regarding the question (Jonathan asked in previous version) if this
really is a fix - I am unsure if this can be of help when dealing with
non OF-systems? (I don't have much of recent experience on those).
Yours,
-- Matti
--
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland
~~ When things go utterly wrong vim users can always type :help! ~~
On Tue, Apr 25, 2023 at 12:22:24AM +0200, Mehdi Djait wrote:
> Add the missing i2c device id
Seems like unfinished commit message (also note missing period, that's why
I paid attention to this).
...
> +static const struct i2c_device_id kx022a_i2c_id[] = {
> + { .name = "kx022a", 0 },
', 0' is redundant.
> + { }
> +};
> +MODULE_DEVICE_TABLE(i2c, kx022a_i2c_id);
--
With Best Regards,
Andy Shevchenko
Hi Andi,
On Tue, Apr 25, 2023 at 04:40:08PM +0300, Andy Shevchenko wrote:
> On Tue, Apr 25, 2023 at 12:22:24AM +0200, Mehdi Djait wrote:
> > Add the missing i2c device id
>
> Seems like unfinished commit message (also note missing period, that's why
> I paid attention to this).
>
While the period is indeed missing. I did not find anything else to
write in the commit message other than 'Add the missing i2c device id'
> ...
>
> > +static const struct i2c_device_id kx022a_i2c_id[] = {
> > + { .name = "kx022a", 0 },
>
> ', 0' is redundant.
I will remove it
--
Kind Regards
Mehdi Djait
On Tue, 25 Apr 2023 08:31:20 +0300
Matti Vaittinen <[email protected]> wrote:
> On 4/25/23 01:22, Mehdi Djait wrote:
> > Add the missing i2c device id
> >
> > Signed-off-by: Mehdi Djait <[email protected]>
>
> Reviewed-by: Matti Vaittinen <[email protected]>
>
> Regarding the question (Jonathan asked in previous version) if this
> really is a fix - I am unsure if this can be of help when dealing with
> non OF-systems? (I don't have much of recent experience on those).
I think it's fine to treat this as a 'feature' be it one that
we'd happily backport to stable if someone asked because the driver
didn't work as expected on their systems.
Jonathan
>
> Yours,
> -- Matti
>