2023-04-26 03:38:59

by Changbin Du

Subject: [PATCH] perf: unwind: suppress massive unsupported target platform errors

When cross-analyzing perf data recorded on an another platform, massive
unsupported target platform errors are printed. So let's show this message
as warning and only once.

Signed-off-by: Changbin Du <[email protected]>
---
tools/perf/util/unwind-libunwind.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/util/unwind-libunwind.c b/tools/perf/util/unwind-libunwind.c
index 509c287ee762..e95adbedf6ed 100644
--- a/tools/perf/util/unwind-libunwind.c
+++ b/tools/perf/util/unwind-libunwind.c
@@ -54,7 +54,7 @@ int unwind__prepare_access(struct maps *maps, struct map *map, bool *initialized
}

if (!ops) {
- pr_err("unwind: target platform=%s is not supported\n", arch);
+ pr_warning_once("unwind: target platform=%s is not supported\n", arch);
return 0;
}
out_register:
--
2.25.1

2023-04-29 01:59:10

by Arnaldo Carvalho de Melo

Subject: Re: [PATCH] perf: unwind: suppress massive unsupported target platform errors

Em Wed, Apr 26, 2023 at 11:22:46AM +0800, Changbin Du escreveu:
> When cross-analyzing perf data recorded on an another platform, massive
> unsupported target platform errors are printed. So let's show this message
> as warning and only once.

Thanks, applied.

- Arnaldo


> Signed-off-by: Changbin Du <[email protected]>
> ---
> tools/perf/util/unwind-libunwind.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/unwind-libunwind.c b/tools/perf/util/unwind-libunwind.c
> index 509c287ee762..e95adbedf6ed 100644
> --- a/tools/perf/util/unwind-libunwind.c
> +++ b/tools/perf/util/unwind-libunwind.c
> @@ -54,7 +54,7 @@ int unwind__prepare_access(struct maps *maps, struct map *map, bool *initialized
> }
>
> if (!ops) {
> - pr_err("unwind: target platform=%s is not supported\n", arch);
> + pr_warning_once("unwind: target platform=%s is not supported\n", arch);
> return 0;
> }
> out_register:
> --
> 2.25.1
>

--

- Arnaldo