2023-06-05 12:11:04

by Masahiro Yamada

Subject: [PATCH] scripts/kallsyms: constify long_options

getopt_long() does not modify this.

Signed-off-by: Masahiro Yamada <[email protected]>
---

scripts/kallsyms.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/kallsyms.c b/scripts/kallsyms.c
index 0d2db41177b2..8e97ac7b38a6 100644
--- a/scripts/kallsyms.c
+++ b/scripts/kallsyms.c
@@ -806,7 +806,7 @@ static void record_relative_base(void)
int main(int argc, char **argv)
{
while (1) {
- static struct option long_options[] = {
+ static const struct option long_options[] = {
{"all-symbols", no_argument, &all_symbols, 1},
{"absolute-percpu", no_argument, &absolute_percpu, 1},
{"base-relative", no_argument, &base_relative, 1},
--
2.39.2

2023-06-06 07:43:07

by Nicolas Schier

Subject: Re: [PATCH] scripts/kallsyms: constify long_options

On Mon, Jun 05, 2023 at 09:04:00PM +0900, Masahiro Yamada wrote:
> getopt_long() does not modify this.
>
> Signed-off-by: Masahiro Yamada <[email protected]>
> ---

Reviewed-by: Nicolas Schier <[email protected]>

>
> scripts/kallsyms.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/kallsyms.c b/scripts/kallsyms.c
> index 0d2db41177b2..8e97ac7b38a6 100644
> --- a/scripts/kallsyms.c
> +++ b/scripts/kallsyms.c
> @@ -806,7 +806,7 @@ static void record_relative_base(void)
> int main(int argc, char **argv)
> {
> while (1) {
> - static struct option long_options[] = {
> + static const struct option long_options[] = {
> {"all-symbols", no_argument, &all_symbols, 1},
> {"absolute-percpu", no_argument, &absolute_percpu, 1},
> {"base-relative", no_argument, &base_relative, 1},
> --
> 2.39.2
>