2023-06-07 10:04:57

by Jiasheng Jiang

Subject: [PATCH] pinctrl: npcm7xx: Add missing check for ioremap

Add check for ioremap() and return the error if it fails in order to
guarantee the success of ioremap().

Fixes: 3b588e43ee5c ("pinctrl: nuvoton: add NPCM7xx pinctrl and GPIO driver")
Signed-off-by: Jiasheng Jiang <[email protected]>
---
drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c b/drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c
index 21e61c2a3798..843ffcd96877 100644
--- a/drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c
+++ b/drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c
@@ -1884,6 +1884,8 @@ static int npcm7xx_gpio_of(struct npcm7xx_pinctrl *pctrl)
}

pctrl->gpio_bank[id].base = ioremap(res.start, resource_size(&res));
+ if (!pctrl->gpio_bank[id].base)
+ return -EINVAL;

ret = bgpio_init(&pctrl->gpio_bank[id].gc, dev, 4,
pctrl->gpio_bank[id].base + NPCM7XX_GP_N_DIN,
--
2.25.1

2023-06-07 18:12:55

by Andy Shevchenko

Subject: Re: [PATCH] pinctrl: npcm7xx: Add missing check for ioremap

Wed, Jun 07, 2023 at 05:58:29PM +0800, Jiasheng Jiang kirjoitti:
> Add check for ioremap() and return the error if it fails in order to
> guarantee the success of ioremap().

This one is correct, otherwise the GPIO is not functional at all.
Reviewed-by: Andy Shevchenko <[email protected]>

> Fixes: 3b588e43ee5c ("pinctrl: nuvoton: add NPCM7xx pinctrl and GPIO driver")
> Signed-off-by: Jiasheng Jiang <[email protected]>
> ---
> drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c b/drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c
> index 21e61c2a3798..843ffcd96877 100644
> --- a/drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c
> +++ b/drivers/pinctrl/nuvoton/pinctrl-npcm7xx.c
> @@ -1884,6 +1884,8 @@ static int npcm7xx_gpio_of(struct npcm7xx_pinctrl *pctrl)
> }
>
> pctrl->gpio_bank[id].base = ioremap(res.start, resource_size(&res));
> + if (!pctrl->gpio_bank[id].base)
> + return -EINVAL;
>
> ret = bgpio_init(&pctrl->gpio_bank[id].gc, dev, 4,
> pctrl->gpio_bank[id].base + NPCM7XX_GP_N_DIN,

--
With Best Regards,
Andy Shevchenko

2023-06-09 07:57:22

by Linus Walleij

Subject: Re: [PATCH] pinctrl: npcm7xx: Add missing check for ioremap

On Wed, Jun 7, 2023 at 11:58 AM Jiasheng Jiang <[email protected]> wrote:

> Add check for ioremap() and return the error if it fails in order to
> guarantee the success of ioremap().
>
> Fixes: 3b588e43ee5c ("pinctrl: nuvoton: add NPCM7xx pinctrl and GPIO driver")
> Signed-off-by: Jiasheng Jiang <[email protected]>

Patch applied as nonurgent fix.

Yours,
Linus Walleij