2023-06-14 08:41:05

by baomingtong001

Subject: [PATCH] perf parse-events: Remove unneeded semicolon

./tools/perf/util/parse-events.c:1466:2-3: Unneeded semicolon

Signed-off-by: Mingtong Bao <[email protected]>
---
tools/perf/util/parse-events.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/util/parse-events.c
b/tools/perf/util/parse-events.c
index 629f7bd9fd59..42f84f61fabc 100644
--- a/tools/perf/util/parse-events.c
+++ b/tools/perf/util/parse-events.c
@@ -1463,7 +1463,7 @@ static int __parse_events_add_numeric(struct
parse_events_state *parse_state,
if (extended_type && (type == PERF_TYPE_HARDWARE || type ==
PERF_TYPE_HW_CACHE)) {
assert(perf_pmus__supports_extended_type());
attr.config |= (u64)extended_type << PERF_PMU_TYPE_SHIFT;
- };
+ }

if (head_config) {
if (config_attr(&attr, head_config, parse_state->error,

2023-06-14 14:48:30

by Arnaldo Carvalho de Melo

Subject: Re: [PATCH] perf parse-events: Remove unneeded semicolon

Em Wed, Jun 14, 2023 at 04:13:53PM +0800, [email protected] escreveu:
> ./tools/perf/util/parse-events.c:1466:2-3: Unneeded semicolon

Was this detected by some tool? Which one?

- Arnaldo

> Signed-off-by: Mingtong Bao <[email protected]>
> ---
> tools/perf/util/parse-events.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c
> index 629f7bd9fd59..42f84f61fabc 100644
> --- a/tools/perf/util/parse-events.c
> +++ b/tools/perf/util/parse-events.c
> @@ -1463,7 +1463,7 @@ static int __parse_events_add_numeric(struct
> parse_events_state *parse_state,
> if (extended_type && (type == PERF_TYPE_HARDWARE || type ==
> PERF_TYPE_HW_CACHE)) {
> assert(perf_pmus__supports_extended_type());
> attr.config |= (u64)extended_type << PERF_PMU_TYPE_SHIFT;
> - };
> + }
>
> if (head_config) {
> if (config_attr(&attr, head_config, parse_state->error,

--

- Arnaldo

2023-06-21 00:06:23

by Namhyung Kim

Subject: Re: [PATCH] perf parse-events: Remove unneeded semicolon

Hello,

On Wed, Jun 14, 2023 at 1:13 AM <[email protected]> wrote:
>
> ./tools/perf/util/parse-events.c:1466:2-3: Unneeded semicolon
>
> Signed-off-by: Mingtong Bao <[email protected]>
> ---
> tools/perf/util/parse-events.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/parse-events.c
> b/tools/perf/util/parse-events.c
> index 629f7bd9fd59..42f84f61fabc 100644
> --- a/tools/perf/util/parse-events.c
> +++ b/tools/perf/util/parse-events.c
> @@ -1463,7 +1463,7 @@ static int __parse_events_add_numeric(struct
> parse_events_state *parse_state,
> if (extended_type && (type == PERF_TYPE_HARDWARE || type ==
> PERF_TYPE_HW_CACHE)) {

The format is broken, please fix your mail client not fix wrap long lines.
This time I fixed it manually, but you need to update your config.

Thanks,
Namhyung


> assert(perf_pmus__supports_extended_type());
> attr.config |= (u64)extended_type << PERF_PMU_TYPE_SHIFT;
> - };
> + }
>
> if (head_config) {
> if (config_attr(&attr, head_config, parse_state->error,

2023-06-21 17:47:06

by Namhyung Kim

Subject: Re: [PATCH] perf parse-events: Remove unneeded semicolon

On Tue, Jun 20, 2023 at 3:50 PM Namhyung Kim <[email protected]> wrote:
>
> Hello,
>
> On Wed, Jun 14, 2023 at 1:13 AM <[email protected]> wrote:
> >
> > ./tools/perf/util/parse-events.c:1466:2-3: Unneeded semicolon
> >
> > Signed-off-by: Mingtong Bao <[email protected]>
> > ---
> > tools/perf/util/parse-events.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/perf/util/parse-events.c
> > b/tools/perf/util/parse-events.c
> > index 629f7bd9fd59..42f84f61fabc 100644
> > --- a/tools/perf/util/parse-events.c
> > +++ b/tools/perf/util/parse-events.c
> > @@ -1463,7 +1463,7 @@ static int __parse_events_add_numeric(struct
> > parse_events_state *parse_state,
> > if (extended_type && (type == PERF_TYPE_HARDWARE || type ==
> > PERF_TYPE_HW_CACHE)) {
>
> The format is broken, please fix your mail client not fix wrap long lines.
> This time I fixed it manually, but you need to update your config.

Also there were other whitespace breakages, but applied to
perf-tools-next anyway, thanks!