2023-06-15 15:01:59

by Maciej Fijalkowski

[permalink] [raw]
Subject: Re: [PATCH net-next] xsk: Remove unused inline function xsk_buff_discard()

On Thu, Jun 15, 2023 at 08:46:12PM +0800, YueHaibing wrote:
> commit f2f167583601 ("xsk: Remove unused xsk_buff_discard")
> left behind this, remove it.
>
> Signed-off-by: YueHaibing <[email protected]>

Yeah this is a stub for !CONFIG_XDP_SOCKETS...

Acked-by: Maciej Fijalkowski <[email protected]>

> ---
> include/net/xdp_sock_drv.h | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/include/net/xdp_sock_drv.h b/include/net/xdp_sock_drv.h
> index 9c0d860609ba..c243f906ebed 100644
> --- a/include/net/xdp_sock_drv.h
> +++ b/include/net/xdp_sock_drv.h
> @@ -255,10 +255,6 @@ static inline void xsk_buff_free(struct xdp_buff *xdp)
> {
> }
>
> -static inline void xsk_buff_discard(struct xdp_buff *xdp)
> -{
> -}
> -
> static inline void xsk_buff_set_size(struct xdp_buff *xdp, u32 size)
> {
> }
> --
> 2.34.1
>
>