2023-06-12 15:01:30

by Nicolas Frattaroli

[permalink] [raw]
Subject: [PATCH] power: supply: rk817: Add missing module alias

Similar to the rk817 codec alias that was missing, the rk817 charger
driver is missing a module alias as well. This absence prevents the
driver from autoprobing on OF systems when it is built as a module.

Add the right MODULE_ALIAS to fix this.

Fixes: 11cb8da0189b ("power: supply: Add charger driver for Rockchip RK817")
Cc: [email protected]
Signed-off-by: Nicolas Frattaroli <[email protected]>
---
drivers/power/supply/rk817_charger.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/power/supply/rk817_charger.c b/drivers/power/supply/rk817_charger.c
index 1a2143641e66..76b991e112da 100644
--- a/drivers/power/supply/rk817_charger.c
+++ b/drivers/power/supply/rk817_charger.c
@@ -1211,3 +1211,4 @@ MODULE_DESCRIPTION("Battery power supply driver for RK817 PMIC");
MODULE_AUTHOR("Maya Matuszczyk <[email protected]>");
MODULE_AUTHOR("Chris Morgan <[email protected]>");
MODULE_LICENSE("GPL");
+MODULE_ALIAS("platform:rk817-charger");
--
2.41.0



2023-06-27 17:53:17

by Chris Morgan

[permalink] [raw]
Subject: Re: [PATCH] power: supply: rk817: Add missing module alias

On Mon, Jun 12, 2023 at 04:36:52PM +0200, Nicolas Frattaroli wrote:
> Similar to the rk817 codec alias that was missing, the rk817 charger
> driver is missing a module alias as well. This absence prevents the
> driver from autoprobing on OF systems when it is built as a module.
>
> Add the right MODULE_ALIAS to fix this.
>

Good catch, thank you.

Reviewed-by: Chris Morgan <[email protected]>

> Fixes: 11cb8da0189b ("power: supply: Add charger driver for Rockchip RK817")
> Cc: [email protected]
> Signed-off-by: Nicolas Frattaroli <[email protected]>
> ---
> drivers/power/supply/rk817_charger.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/power/supply/rk817_charger.c b/drivers/power/supply/rk817_charger.c
> index 1a2143641e66..76b991e112da 100644
> --- a/drivers/power/supply/rk817_charger.c
> +++ b/drivers/power/supply/rk817_charger.c
> @@ -1211,3 +1211,4 @@ MODULE_DESCRIPTION("Battery power supply driver for RK817 PMIC");
> MODULE_AUTHOR("Maya Matuszczyk <[email protected]>");
> MODULE_AUTHOR("Chris Morgan <[email protected]>");
> MODULE_LICENSE("GPL");
> +MODULE_ALIAS("platform:rk817-charger");
> --
> 2.41.0
>

2023-09-14 22:02:44

by Sebastian Reichel

[permalink] [raw]
Subject: Re: [PATCH] power: supply: rk817: Add missing module alias


On Mon, 12 Jun 2023 16:36:52 +0200, Nicolas Frattaroli wrote:
> Similar to the rk817 codec alias that was missing, the rk817 charger
> driver is missing a module alias as well. This absence prevents the
> driver from autoprobing on OF systems when it is built as a module.
>
> Add the right MODULE_ALIAS to fix this.
>
>
> [...]

Applied, thanks!

[1/1] power: supply: rk817: Add missing module alias
commit: cbcdfbf5a6cd66e47e5ee5d49c4c5a27a07ba082

Best regards,
--
Sebastian Reichel <[email protected]>