2023-07-11 11:28:56

by Geert Uytterhoeven

Subject: [PATCH] workqueue: Fix cpu_intensive_thresh_us name in help text

There exists no parameter called "cpu_intensive_threshold_us".
The actual parameter name is "cpu_intensive_thresh_us".

Fixes: 6363845005202148 ("workqueue: Report work funcs that trigger automatic CPU_INTENSIVE mechanism")
Signed-off-by: Geert Uytterhoeven <[email protected]>
---
lib/Kconfig.debug | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index c8371502b4b2e678..5da00849edebafdd 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -1200,7 +1200,7 @@ config WQ_CPU_INTENSIVE_REPORT
help
Say Y here to enable reporting of concurrency-managed per-cpu work
items that hog CPUs for longer than
- workqueue.cpu_intensive_threshold_us. Workqueue automatically
+ workqueue.cpu_intensive_thresh_us. Workqueue automatically
detects and excludes them from concurrency management to prevent
them from stalling other per-cpu work items. Occassional
triggering may not necessarily indicate a problem. Repeated
--
2.34.1

2023-07-11 15:17:34

by Randy Dunlap

Subject: Re: [PATCH] workqueue: Fix cpu_intensive_thresh_us name in help text

On 7/11/23 03:38, Geert Uytterhoeven wrote:
> There exists no parameter called "cpu_intensive_threshold_us".
> The actual parameter name is "cpu_intensive_thresh_us".
>
> Fixes: 6363845005202148 ("workqueue: Report work funcs that trigger automatic CPU_INTENSIVE mechanism")
> Signed-off-by: Geert Uytterhoeven <[email protected]>

Reviewed-by: Randy Dunlap <[email protected]>

Thanks.

> ---
> lib/Kconfig.debug | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index c8371502b4b2e678..5da00849edebafdd 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -1200,7 +1200,7 @@ config WQ_CPU_INTENSIVE_REPORT
> help
> Say Y here to enable reporting of concurrency-managed per-cpu work
> items that hog CPUs for longer than
> - workqueue.cpu_intensive_threshold_us. Workqueue automatically
> + workqueue.cpu_intensive_thresh_us. Workqueue automatically
> detects and excludes them from concurrency management to prevent
> them from stalling other per-cpu work items. Occassional
> triggering may not necessarily indicate a problem. Repeated

--
~Randy

2023-07-11 21:57:56

by Tejun Heo

Subject: Re: [PATCH] workqueue: Fix cpu_intensive_thresh_us name in help text

On Tue, Jul 11, 2023 at 12:38:20PM +0200, Geert Uytterhoeven wrote:
> There exists no parameter called "cpu_intensive_threshold_us".
> The actual parameter name is "cpu_intensive_thresh_us".
>
> Fixes: 6363845005202148 ("workqueue: Report work funcs that trigger automatic CPU_INTENSIVE mechanism")
> Signed-off-by: Geert Uytterhoeven <[email protected]>
> ---
> lib/Kconfig.debug | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index c8371502b4b2e678..5da00849edebafdd 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -1200,7 +1200,7 @@ config WQ_CPU_INTENSIVE_REPORT
> help
> Say Y here to enable reporting of concurrency-managed per-cpu work
> items that hog CPUs for longer than
> - workqueue.cpu_intensive_threshold_us. Workqueue automatically
> + workqueue.cpu_intensive_thresh_us. Workqueue automatically
> detects and excludes them from concurrency management to prevent
> them from stalling other per-cpu work items. Occassional
> triggering may not necessarily indicate a problem. Repeated

Applied to wq/for-6.5-fixes.

Thanks.

--
tejun