2023-07-11 07:38:49

by Krzysztof Kozlowski

Subject: [PATCH v2] Input: bcm-keypad - Correct dev_err_probe() error

Pass proper PTR_ERR as dev_err_probe() argument.

Fixes: a2c795b696b2 ("Input: bcm-keypad - simplify with dev_err_probe()")
Reported-by: kernel test robot <[email protected]>
Reported-by: Dan Carpenter <[email protected]>
Closes: https://lore.kernel.org/r/[email protected]/
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/input/keyboard/bcm-keypad.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/keyboard/bcm-keypad.c b/drivers/input/keyboard/bcm-keypad.c
index 05b09066df84..bcc480ff7c3b 100644
--- a/drivers/input/keyboard/bcm-keypad.c
+++ b/drivers/input/keyboard/bcm-keypad.c
@@ -367,7 +367,7 @@ static int bcm_kp_probe(struct platform_device *pdev)
/* Enable clock */
kp->clk = devm_clk_get_optional(&pdev->dev, "peri_clk");
if (IS_ERR(kp->clk)) {
- return dev_err_probe(&pdev->dev, error, "Failed to get clock\n");
+ return dev_err_probe(&pdev->dev, PTR_ERR(kp->clk), "Failed to get clock\n");
} else if (!kp->clk) {
dev_dbg(&pdev->dev, "No clock specified. Assuming it's enabled\n");
} else {
--
2.34.1

2023-07-12 19:29:22

by Dmitry Torokhov

Subject: Re: [PATCH v2] Input: bcm-keypad - Correct dev_err_probe() error

On Tue, Jul 11, 2023 at 09:24:49AM +0200, Krzysztof Kozlowski wrote:
> Pass proper PTR_ERR as dev_err_probe() argument.
>
> Fixes: a2c795b696b2 ("Input: bcm-keypad - simplify with dev_err_probe()")
> Reported-by: kernel test robot <[email protected]>
> Reported-by: Dan Carpenter <[email protected]>
> Closes: https://lore.kernel.org/r/[email protected]/
> Signed-off-by: Krzysztof Kozlowski <[email protected]>

Applied, thank you.

--
Dmitry