2023-07-12 11:37:59

by huzhi001

Subject: [PATCH] clocksource: Fix warnings in mshyperv.h

The following checkpatch warnings are removed:
WARNING: Use #include <linux/io.h> instead of <asm/io.h>

Signed-off-by: ZhiHu <[email protected]>
---
arch/x86/include/asm/mshyperv.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/include/asm/mshyperv.h
b/arch/x86/include/asm/mshyperv.h
index 88d9ef98e087..fa83d88e4c99 100644
--- a/arch/x86/include/asm/mshyperv.h
+++ b/arch/x86/include/asm/mshyperv.h
@@ -5,7 +5,7 @@
#include <linux/types.h>
#include <linux/nmi.h>
#include <linux/msi.h>
-#include <asm/io.h>
+#include <linux/io.h>
#include <asm/hyperv-tlfs.h>
#include <asm/nospec-branch.h>
#include <asm/paravirt.h>

2023-07-12 21:18:58

by Michael Kelley (LINUX)

Subject: RE: [PATCH] clocksource: Fix warnings in mshyperv.h

From: [email protected] <[email protected]> Sent: Wednesday, July 12, 2023 4:23 AM
>
> The following checkpatch warnings are removed:
> WARNING: Use #include <linux/io.h> instead of <asm/io.h>

The "Subject:" of the patch should probably start with "x86/hyperv",
not "clocksource". Usually I look back at the commit history of a
particular file and try to be consistent with the Subject: prefix that
has been used in the past. "x86/hyperv" is typical for this
include file.

Other than that,

Reviewed-by: Michael Kelley <[email protected]>
>
> Signed-off-by: ZhiHu <[email protected]>
> ---
> arch/x86/include/asm/mshyperv.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/include/asm/mshyperv.h
> b/arch/x86/include/asm/mshyperv.h
> index 88d9ef98e087..fa83d88e4c99 100644
> --- a/arch/x86/include/asm/mshyperv.h
> +++ b/arch/x86/include/asm/mshyperv.h
> @@ -5,7 +5,7 @@
> #include <linux/types.h>
> #include <linux/nmi.h>
> #include <linux/msi.h>
> -#include <asm/io.h>
> +#include <linux/io.h>
> #include <asm/hyperv-tlfs.h>
> #include <asm/nospec-branch.h>
> #include <asm/paravirt.h>

2023-07-23 23:45:46

by Wei Liu

Subject: Re: [PATCH] clocksource: Fix warnings in mshyperv.h

On Wed, Jul 12, 2023 at 09:06:30PM +0000, Michael Kelley (LINUX) wrote:
> From: [email protected] <[email protected]> Sent: Wednesday, July 12, 2023 4:23 AM
> >
> > The following checkpatch warnings are removed:
> > WARNING: Use #include <linux/io.h> instead of <asm/io.h>
>
> The "Subject:" of the patch should probably start with "x86/hyperv",
> not "clocksource". Usually I look back at the commit history of a
> particular file and try to be consistent with the Subject: prefix that
> has been used in the past. "x86/hyperv" is typical for this
> include file.
>
> Other than that,
>
> Reviewed-by: Michael Kelley <[email protected]>

There is only one warning fixed.

I changed the subject line and commit message.

Applied to hyperv-fixes. Thanks.

> >
> > Signed-off-by: ZhiHu <[email protected]>
> > ---
> > arch/x86/include/asm/mshyperv.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/x86/include/asm/mshyperv.h
> > b/arch/x86/include/asm/mshyperv.h
> > index 88d9ef98e087..fa83d88e4c99 100644
> > --- a/arch/x86/include/asm/mshyperv.h
> > +++ b/arch/x86/include/asm/mshyperv.h
> > @@ -5,7 +5,7 @@
> > #include <linux/types.h>
> > #include <linux/nmi.h>
> > #include <linux/msi.h>
> > -#include <asm/io.h>
> > +#include <linux/io.h>
> > #include <asm/hyperv-tlfs.h>
> > #include <asm/nospec-branch.h>
> > #include <asm/paravirt.h>