2023-08-08 20:24:42

by Andy Shevchenko

Subject: [PATCH v1 1/1] iio: accel: kionix-kx022a: Use correct header(s) instead of string_helpers.h

There is nothing from string_helpers.h used in the driver, correct
the header inclusion block accordingly.

Signed-off-by: Andy Shevchenko <[email protected]>
---
drivers/iio/accel/kionix-kx022a.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/accel/kionix-kx022a.c b/drivers/iio/accel/kionix-kx022a.c
index 4ea3c6718ed4..f164b09520c9 100644
--- a/drivers/iio/accel/kionix-kx022a.c
+++ b/drivers/iio/accel/kionix-kx022a.c
@@ -15,7 +15,7 @@
#include <linux/regmap.h>
#include <linux/regulator/consumer.h>
#include <linux/slab.h>
-#include <linux/string_helpers.h>
+#include <linux/string_choices.h>
#include <linux/units.h>

#include <linux/iio/iio.h>
--
2.40.0.1.gaa8946217a0b

2023-08-09 07:51:38

by Matti Vaittinen

Subject: Re: [PATCH v1 1/1] iio: accel: kionix-kx022a: Use correct header(s) instead of string_helpers.h

On 8/8/23 19:42, Andy Shevchenko wrote:
> There is nothing from string_helpers.h used in the driver, correct
> the header inclusion block accordingly.
>
> Signed-off-by: Andy Shevchenko <[email protected]>

Acked-by: Matti Vaittinen <[email protected]>

Out of the curiosity - is the goal to get rid of including choices from
helpers? (I think) then the header split would be more beneficial.

> ---
> drivers/iio/accel/kionix-kx022a.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/accel/kionix-kx022a.c b/drivers/iio/accel/kionix-kx022a.c
> index 4ea3c6718ed4..f164b09520c9 100644
> --- a/drivers/iio/accel/kionix-kx022a.c
> +++ b/drivers/iio/accel/kionix-kx022a.c
> @@ -15,7 +15,7 @@
> #include <linux/regmap.h>
> #include <linux/regulator/consumer.h>
> #include <linux/slab.h>
> -#include <linux/string_helpers.h>
> +#include <linux/string_choices.h>
> #include <linux/units.h>
>
> #include <linux/iio/iio.h>

--
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland

~~ When things go utterly wrong vim users can always type :help! ~~

2023-08-10 15:46:21

by Andy Shevchenko

Subject: Re: [PATCH v1 1/1] iio: accel: kionix-kx022a: Use correct header(s) instead of string_helpers.h

On Wed, Aug 09, 2023 at 09:00:39AM +0300, Matti Vaittinen wrote:
> On 8/8/23 19:42, Andy Shevchenko wrote:
> > There is nothing from string_helpers.h used in the driver, correct
> > the header inclusion block accordingly.
> >
> > Signed-off-by: Andy Shevchenko <[email protected]>
>
> Acked-by: Matti Vaittinen <[email protected]>
>
> Out of the curiosity - is the goal to get rid of including choices from
> helpers? (I think) then the header split would be more beneficial.

At the end, yes.

Thank you for acknowledging!

--
With Best Regards,
Andy Shevchenko